Skip to content

Commit 55d7fbb

Browse files
craig[bot]dhartunian
craig[bot]
and
dhartunian
committed
Merge #149375
149375: cli: debug zip captures execution traces from every node r=angles-n-daemons a=dhartunian debug zip will grab execution traces from each node if they're available. Release note: None Part of #97215 ---- Prior commit is being reviewed here: Co-authored-by: David Hartunian <[email protected]>
2 parents ac3b2b7 + 9500670 commit 55d7fbb

16 files changed

+73
-0
lines changed

‎pkg/cli/testdata/zip/partial1‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0s --validate-zip-file=false /d
3434
[node 1] requesting cpu profile list... received response...
3535
[node 1] requesting cpu profile list: last request failed: rpc error: ...
3636
[node 1] requesting cpu profile list: creating error output: debug/nodes/1/cpuprof.err.txt... done
37+
[node 1] requesting execution trace list... received response...
38+
[node 1] requesting execution trace list: last request failed: rpc error: ...
39+
[node 1] requesting execution trace list: creating error output: debug/nodes/1/executiontraces.err.txt... done
3740
[node 1] requesting log files list... received response... done
3841
[node ?] ? log files found
3942
[node 1] requesting ranges... received response... done
@@ -68,6 +71,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0s --validate-zip-file=false /d
6871
[node 2] requesting cpu profile list... received response...
6972
[node 2] requesting cpu profile list: last request failed: rpc error: ...
7073
[node 2] requesting cpu profile list: creating error output: debug/nodes/2/cpuprof.err.txt... done
74+
[node 2] requesting execution trace list... received response...
75+
[node 2] requesting execution trace list: last request failed: rpc error: ...
76+
[node 2] requesting execution trace list: creating error output: debug/nodes/2/executiontraces.err.txt... done
7177
[node 2] requesting log files list... received response...
7278
[node 2] requesting log files list: last request failed: rpc error: ...
7379
[node 2] requesting log files list: creating error output: debug/nodes/2/logs.err.txt... done
@@ -92,6 +98,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0s --validate-zip-file=false /d
9298
[node 3] requesting cpu profile list... received response...
9399
[node 3] requesting cpu profile list: last request failed: rpc error: ...
94100
[node 3] requesting cpu profile list: creating error output: debug/nodes/3/cpuprof.err.txt... done
101+
[node 3] requesting execution trace list... received response...
102+
[node 3] requesting execution trace list: last request failed: rpc error: ...
103+
[node 3] requesting execution trace list: creating error output: debug/nodes/3/executiontraces.err.txt... done
95104
[node 3] requesting log files list... received response... done
96105
[node ?] ? log files found
97106
[node 3] requesting ranges... received response... done

‎pkg/cli/testdata/zip/partial1_excluded‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ debug zip /dev/null --concurrency=1 --exclude-nodes=2 --cpu-profile-duration=0 -
3434
[node 1] requesting cpu profile list... received response...
3535
[node 1] requesting cpu profile list: last request failed: rpc error: ...
3636
[node 1] requesting cpu profile list: creating error output: debug/nodes/1/cpuprof.err.txt... done
37+
[node 1] requesting execution trace list... received response...
38+
[node 1] requesting execution trace list: last request failed: rpc error: ...
39+
[node 1] requesting execution trace list: creating error output: debug/nodes/1/executiontraces.err.txt... done
3740
[node 1] requesting log files list... received response... done
3841
[node ?] ? log files found
3942
[node 1] requesting ranges... received response... done
@@ -57,6 +60,9 @@ debug zip /dev/null --concurrency=1 --exclude-nodes=2 --cpu-profile-duration=0 -
5760
[node 3] requesting cpu profile list... received response...
5861
[node 3] requesting cpu profile list: last request failed: rpc error: ...
5962
[node 3] requesting cpu profile list: creating error output: debug/nodes/3/cpuprof.err.txt... done
63+
[node 3] requesting execution trace list... received response...
64+
[node 3] requesting execution trace list: last request failed: rpc error: ...
65+
[node 3] requesting execution trace list: creating error output: debug/nodes/3/executiontraces.err.txt... done
6066
[node 3] requesting log files list... received response... done
6167
[node ?] ? log files found
6268
[node 3] requesting ranges... received response... done

‎pkg/cli/testdata/zip/partial2‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0 --validate-zip-file=false /de
3434
[node 1] requesting cpu profile list... received response...
3535
[node 1] requesting cpu profile list: last request failed: rpc error: ...
3636
[node 1] requesting cpu profile list: creating error output: debug/nodes/1/cpuprof.err.txt... done
37+
[node 1] requesting execution trace list... received response...
38+
[node 1] requesting execution trace list: last request failed: rpc error: ...
39+
[node 1] requesting execution trace list: creating error output: debug/nodes/1/executiontraces.err.txt... done
3740
[node 1] requesting log files list... received response... done
3841
[node ?] ? log files found
3942
[node 1] requesting ranges... received response... done
@@ -56,6 +59,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0 --validate-zip-file=false /de
5659
[node 3] requesting cpu profile list... received response...
5760
[node 3] requesting cpu profile list: last request failed: rpc error: ...
5861
[node 3] requesting cpu profile list: creating error output: debug/nodes/3/cpuprof.err.txt... done
62+
[node 3] requesting execution trace list... received response...
63+
[node 3] requesting execution trace list: last request failed: rpc error: ...
64+
[node 3] requesting execution trace list: creating error output: debug/nodes/3/executiontraces.err.txt... done
5965
[node 3] requesting log files list... received response... done
6066
[node ?] ? log files found
6167
[node 3] requesting ranges... received response... done

‎pkg/cli/testdata/zip/testzip‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --validate-zip-file=false /d
3434
[node ?] ? goroutine dumps found
3535
[node 1] requesting cpu profile list... received response... done
3636
[node ?] ? cpu profiles found
37+
[node 1] requesting execution trace list... received response... done
38+
[node ?] ? execution traces found
3739
[node 1] requesting log files list... received response... done
3840
[node ?] ? log files found
3941
[node 1] requesting ranges... received response... done

‎pkg/cli/testdata/zip/testzip_concurrent‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,11 @@ zip
7373
[node 1] requesting engine stats: done
7474
[node 1] requesting engine stats: received response...
7575
[node 1] requesting engine stats: writing binary output: debug/nodes/1/lsm.txt...
76+
[node 1] requesting execution trace list...
77+
[node 1] requesting execution trace list: creating error output: debug/nodes/1/executiontraces.err.txt...
78+
[node 1] requesting execution trace list: done
79+
[node 1] requesting execution trace list: last request failed: rpc error: ...
80+
[node 1] requesting execution trace list: received response...
7681
[node 1] requesting goroutine dump list...
7782
[node 1] requesting goroutine dump list: creating error output: debug/nodes/1/goroutines.err.txt...
7883
[node 1] requesting goroutine dump list: done
@@ -125,6 +130,11 @@ zip
125130
[node 2] requesting engine stats: done
126131
[node 2] requesting engine stats: received response...
127132
[node 2] requesting engine stats: writing binary output: debug/nodes/2/lsm.txt...
133+
[node 2] requesting execution trace list...
134+
[node 2] requesting execution trace list: creating error output: debug/nodes/2/executiontraces.err.txt...
135+
[node 2] requesting execution trace list: done
136+
[node 2] requesting execution trace list: last request failed: rpc error: ...
137+
[node 2] requesting execution trace list: received response...
128138
[node 2] requesting goroutine dump list...
129139
[node 2] requesting goroutine dump list: creating error output: debug/nodes/2/goroutines.err.txt...
130140
[node 2] requesting goroutine dump list: done
@@ -177,6 +187,11 @@ zip
177187
[node 3] requesting engine stats: done
178188
[node 3] requesting engine stats: received response...
179189
[node 3] requesting engine stats: writing binary output: debug/nodes/3/lsm.txt...
190+
[node 3] requesting execution trace list...
191+
[node 3] requesting execution trace list: creating error output: debug/nodes/3/executiontraces.err.txt...
192+
[node 3] requesting execution trace list: done
193+
[node 3] requesting execution trace list: last request failed: rpc error: ...
194+
[node 3] requesting execution trace list: received response...
180195
[node 3] requesting goroutine dump list...
181196
[node 3] requesting goroutine dump list: creating error output: debug/nodes/3/goroutines.err.txt...
182197
[node 3] requesting goroutine dump list: done

‎pkg/cli/testdata/zip/testzip_exclude_goroutine_stacks‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --validate-zip-file=false --
3333
[node ?] ? goroutine dumps found
3434
[node 1] requesting cpu profile list... received response... done
3535
[node ?] ? cpu profiles found
36+
[node 1] requesting execution trace list... received response... done
37+
[node ?] ? execution traces found
3638
[node 1] requesting log files list... received response... done
3739
[node ?] ? log files found
3840
[node 1] requesting ranges... received response... done

‎pkg/cli/testdata/zip/testzip_exclude_range_info‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --include-range-info=false -
3030
[node ?] ? goroutine dumps found
3131
[node 1] requesting cpu profile list... received response... done
3232
[node ?] ? cpu profiles found
33+
[node 1] requesting execution trace list... received response... done
34+
[node ?] ? execution traces found
3335
[node 1] requesting log files list... received response... done
3436
[node ?] ? log files found
3537
[cluster] pprof summary script... writing binary output: debug/pprof-summary.sh... done

‎pkg/cli/testdata/zip/testzip_external_process_virtualization‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --validate-zip-file=false /d
5050
[node ?] ? goroutine dumps found
5151
[node 1] requesting cpu profile list... received response... done
5252
[node ?] ? cpu profiles found
53+
[node 1] requesting execution trace list... received response... done
54+
[node ?] ? execution traces found
5355
[node 1] requesting log files list... received response... done
5456
[node ?] ? log files found
5557
[node 1] requesting ranges... received response... done

‎pkg/cli/testdata/zip/testzip_fallback‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --validate-zip-file=false /d
8080
[node ?] ? goroutine dumps found
8181
[node 1] requesting cpu profile list... received response... done
8282
[node ?] ? cpu profiles found
83+
[node 1] requesting execution trace list... received response... done
84+
[node ?] ? execution traces found
8385
[node 1] requesting log files list... received response... done
8486
[node ?] ? log files found
8587
[node 1] requesting ranges... received response... done

‎pkg/cli/testdata/zip/testzip_include_goroutine_stacks‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ debug zip --concurrency=1 --cpu-profile-duration=1s --validate-zip-file=false /d
3434
[node ?] ? goroutine dumps found
3535
[node 1] requesting cpu profile list... received response... done
3636
[node ?] ? cpu profiles found
37+
[node 1] requesting execution trace list... received response... done
38+
[node ?] ? execution traces found
3739
[node 1] requesting log files list... received response... done
3840
[node ?] ? log files found
3941
[node 1] requesting ranges... received response... done

0 commit comments

Comments
 (0)