Skip to content

Commit 594ea7a

Browse files
committed
workloadccl: remove stale comment around importing fixtures
This commit deletes now-stale comment that was added in 09abc26. That change made a switch from using IMPORT TABLE to IMPORT INTO for importing fixtures as a temporary workaround. However, since then we completely deprecated IMPORT TABLE syntax, so the only way to import the data now is to create the tables separately, which makes the comment confusing. Release note: None
1 parent 38afd01 commit 594ea7a

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

pkg/ccl/workloadccl/fixture.go

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -374,17 +374,7 @@ func ImportFixture(
374374
defer enableFn()
375375
}
376376

377-
pathPrefix := csvServer
378-
if pathPrefix == `` {
379-
pathPrefix = `workload://`
380-
}
381-
382-
// Pre-create tables. It's required that we pre-create the tables before we
383-
// parallelize the IMPORT because for multi-region setups, the create table
384-
// will end up modifying the crdb_internal_region type (to install back
385-
// references). If create table is done in parallel with IMPORT, some IMPORT
386-
// jobs may fail because the type is being modified concurrently with the
387-
// IMPORT. Removing the need to pre-create is being tracked with #70987.
377+
// Prepare the tables for ingestion via IMPORT INTO.
388378
const maxTableBatchSize = 5000
389379
currentTable := 0
390380
for currentTable < len(tables) {
@@ -404,6 +394,11 @@ func ImportFixture(
404394
currentTable += maxTableBatchSize
405395
}
406396

397+
pathPrefix := csvServer
398+
if pathPrefix == `` {
399+
pathPrefix = `workload://`
400+
}
401+
407402
// Default to unbounded unless a flag exists for it.
408403
concurrencyLimit := math.MaxInt
409404
if flagser, ok := gen.(workload.Flagser); ok {

0 commit comments

Comments
 (0)