Merge #150524

150524: storage: re-enable value separation by default, metamorphically r=annrpom a=jbowens

This commit re-enables value separation by default now that #150216 is resolved. It's now metamorphically toggled on/off as well.

Epic: none
Release note: none

Co-authored-by: Jackson Owens <[email protected]>

Author: craig[bot]

pkg/storage/pebble.go

@@ -421,7 +421,8 @@ var (
 		settings.SystemVisible,
 		"storage.value_separation.enabled",
 		"whether or not values may be separated into blob files",
-		false, /* defaultValue */
+		metamorphic.ConstantWithTestBool(
+			"storage.value_separation.enabled", true /* defaultValue */),
 	)
 	valueSeparationMinimumSize = settings.RegisterIntSetting(
 		settings.SystemVisible,