Skip to content

Commit 61fda6b

Browse files
committed
storage: bump Pebble format version
Start using the latest Pebble format version. Epic: none Release note: None
1 parent 75212a9 commit 61fda6b

File tree

5 files changed

+16
-11
lines changed

5 files changed

+16
-11
lines changed

docs/generated/settings/settings-for-tenants.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,4 +420,4 @@ trace.zipkin.collector string the address of a Zipkin instance to receive trace
420420
ui.database_locality_metadata.enabled boolean true if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute application
421421
ui.default_timezone string the default timezone used to format timestamps in the ui application
422422
ui.display_timezone enumeration etc/utc the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the 'ui.default_timezone' setting instead. 'ui.default_timezone' takes precedence over this setting. [etc/utc = 0, america/new_york = 1] application
423-
version version 1000025.3-upgrading-to-1000025.4-step-004 set the active cluster version in the format '<major>.<minor>' application
423+
version version 1000025.3-upgrading-to-1000025.4-step-006 set the active cluster version in the format '<major>.<minor>' application

docs/generated/settings/settings.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,6 +378,6 @@
378378
<tr><td><div id="setting-ui-database-locality-metadata-enabled" class="anchored"><code>ui.database_locality_metadata.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
379379
<tr><td><div id="setting-ui-default-timezone" class="anchored"><code>ui.default_timezone</code></div></td><td>string</td><td><code></code></td><td>the default timezone used to format timestamps in the ui</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
380380
<tr><td><div id="setting-ui-display-timezone" class="anchored"><code>ui.display_timezone</code></div></td><td>enumeration</td><td><code>etc/utc</code></td><td>the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the &#39;ui.default_timezone&#39; setting instead. &#39;ui.default_timezone&#39; takes precedence over this setting. [etc/utc = 0, america/new_york = 1]</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
381-
<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000025.3-upgrading-to-1000025.4-step-004</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
381+
<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000025.3-upgrading-to-1000025.4-step-006</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
382382
</tbody>
383383
</table>

pkg/cli/testdata/ear-list

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ list
88
000004.log:
99
env type: Data, AES128_CTR
1010
keyID: bbb65a9d114c2a18740f27b6933b74f61018bd5adf545c153b48ffe6473336ef
11-
nonce: 31 d3 cd 5a 69 e2 13 64 21 53 57 64
12-
counter: 3952287331
11+
nonce: 86 a7 78 ad 4b da 62 56 d5 e2 d1 70
12+
counter: 798955289
1313
000005.sst:
1414
env type: Data, AES128_CTR
1515
keyID: bbb65a9d114c2a18740f27b6933b74f61018bd5adf545c153b48ffe6473336ef
16-
nonce: 23 d9 b2 e1 39 b0 87 ed f9 6d 49 20
17-
counter: 3481614039
16+
nonce: d1 05 79 53 68 35 a0 f1 44 01 22 79
17+
counter: 1497766936
1818
COCKROACHDB_DATA_KEYS_000001_monolith:
1919
env type: Store, AES128_CTR
2020
keyID: f594229216d81add7811c4360212eb7629b578ef4eab6e5d05679b3c5de48867
@@ -35,11 +35,11 @@ marker.datakeys.000001.COCKROACHDB_DATA_KEYS_000001_monolith:
3535
keyID: f594229216d81add7811c4360212eb7629b578ef4eab6e5d05679b3c5de48867
3636
nonce: 55 d7 d4 27 6c 97 9b dd f1 5d 40 c8
3737
counter: 467030050
38-
marker.format-version.000011.024:
38+
marker.format-version.000013.026:
3939
env type: Data, AES128_CTR
4040
keyID: bbb65a9d114c2a18740f27b6933b74f61018bd5adf545c153b48ffe6473336ef
41-
nonce: c3 6d b2 7b 3f 3e 67 b9 28 b9 81 b1
42-
counter: 3050109376
41+
nonce: 23 d9 b2 e1 39 b0 87 ed f9 6d 49 20
42+
counter: 3481614039
4343
marker.manifest.000001.MANIFEST-000001:
4444
env type: Data, AES128_CTR
4545
keyID: bbb65a9d114c2a18740f27b6933b74f61018bd5adf545c153b48ffe6473336ef

pkg/clusterversion/cockroach_versions.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ const (
210210
// constructing the split write batch.
211211
V25_4_WriteInitialTruncStateBeforeSplitApplication
212212

213+
// V25_4_PebbleFormatV2BlobFiles bumps the pebble format to FormatV2BlobFiles.
214+
V25_4_PebbleFormatV2BlobFiles
215+
213216
// *************************************************
214217
// Step (1) Add new versions above this comment.
215218
// Do not add new versions to a patch release.
@@ -263,6 +266,7 @@ var versionTable = [numKeys]roachpb.Version{
263266
V25_4_Start: {Major: 25, Minor: 3, Internal: 2},
264267

265268
V25_4_WriteInitialTruncStateBeforeSplitApplication: {Major: 25, Minor: 3, Internal: 4},
269+
V25_4_PebbleFormatV2BlobFiles: {Major: 25, Minor: 3, Internal: 6},
266270

267271
// *************************************************
268272
// Step (2): Add new versions above this comment.

pkg/storage/pebble.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2326,8 +2326,9 @@ func (p *Pebble) CreateCheckpoint(dir string, spans []roachpb.Span) error {
23262326
// named version, it can be assumed all *nodes* have ratcheted to the pebble
23272327
// version associated with it, since they did so during the fence version.
23282328
var pebbleFormatVersionMap = map[clusterversion.Key]pebble.FormatMajorVersion{
2329-
clusterversion.V25_3: pebble.FormatValueSeparation,
2330-
clusterversion.V25_2: pebble.FormatTableFormatV6,
2329+
clusterversion.V25_4_PebbleFormatV2BlobFiles: pebble.FormatV2BlobFiles,
2330+
clusterversion.V25_3: pebble.FormatValueSeparation,
2331+
clusterversion.V25_2: pebble.FormatTableFormatV6,
23312332
}
23322333

23332334
// MinimumSupportedFormatVersion is the version that provides features that the

0 commit comments

Comments
 (0)