Skip to content

Commit 642f0e9

Browse files
logictest: update logictests data
Update logictest testdata to skip a statement in mixed version scenarios. Epic: none Release note: None
1 parent 9709f01 commit 642f0e9

File tree

5 files changed

+21
-33
lines changed

5 files changed

+21
-33
lines changed

pkg/sql/logictest/logictestbase/logictestbase.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -511,11 +511,6 @@ var LogicTestConfigs = []TestClusterConfig{
511511
BootstrapVersion: clusterversion.V25_3,
512512
DisableUpgrade: true,
513513
DeclarativeCorpusCollection: true,
514-
// Mixed version clusters do not support disabling schema_locked
515-
// automatically, since we added more statements in 25.3.
516-
// Note: This can be removed once the mixed version level is 25.3,
517-
// since the entire test suite should be compatible.
518-
DisableSchemaLockedByDefault: true,
519514
},
520515
{
521516
// This config runs a cluster with 3 nodes, with a separate process per

pkg/sql/logictest/testdata/logic_test/crdb_internal_catalog

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ SELECT id, strip_volatile(descriptor) FROM crdb_internal.kv_catalog_descriptor W
129129
113 {"function": {"functionBody": "SELECT json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(json_remove_path(d, ARRAY['table':::STRING, 'families':::STRING]:::STRING[]), ARRAY['table':::STRING, 'nextFamilyId':::STRING]:::STRING[]), ARRAY['table':::STRING, 'indexes':::STRING, '0':::STRING, 'createdAtNanos':::STRING]:::STRING[]), ARRAY['table':::STRING, 'indexes':::STRING, '1':::STRING, 'createdAtNanos':::STRING]:::STRING[]), ARRAY['table':::STRING, 'indexes':::STRING, '2':::STRING, 'createdAtNanos':::STRING]:::STRING[]), ARRAY['table':::STRING, 'primaryIndex':::STRING, 'createdAtNanos':::STRING]:::STRING[]), ARRAY['table':::STRING, 'createAsOfTime':::STRING]:::STRING[]), ARRAY['table':::STRING, 'modificationTime':::STRING]:::STRING[]), ARRAY['function':::STRING, 'modificationTime':::STRING]:::STRING[]), ARRAY['type':::STRING, 'modificationTime':::STRING]:::STRING[]), ARRAY['schema':::STRING, 'modificationTime':::STRING]:::STRING[]), ARRAY['database':::STRING, 'modificationTime':::STRING]:::STRING[]);", "id": 113, "lang": "SQL", "name": "strip_volatile", "nullInputBehavior": "CALLED_ON_NULL_INPUT", "params": [{"class": "IN", "name": "d", "type": {"family": "JsonFamily", "oid": 3802}}], "parentId": 104, "parentSchemaId": 105, "privileges": {"ownerProto": "root", "users": [{"privileges": "2", "userProto": "admin", "withGrantOption": "2"}, {"privileges": "1048576", "userProto": "public"}, {"privileges": "2", "userProto": "root", "withGrantOption": "2"}], "version": 3}, "returnType": {"type": {"family": "JsonFamily", "oid": 3802}}, "version": "1", "volatility": "STABLE"}}
130130
4294966962 {"table": {"columns": [{"id": 1, "name": "f_table_catalog", "nullable": true, "type": {"family": 11, "oid": 19}}, {"id": 2, "name": "f_table_schema", "nullable": true, "type": {"family": 11, "oid": 19}}, {"id": 3, "name": "f_table_name", "nullable": true, "type": {"family": 11, "oid": 19}}, {"id": 4, "name": "f_geometry_column", "nullable": true, "type": {"family": 11, "oid": 19}}, {"id": 5, "name": "coord_dimension", "nullable": true, "type": {"family": "IntFamily", "oid": 20, "width": 64}}, {"id": 6, "name": "srid", "nullable": true, "type": {"family": "IntFamily", "oid": 20, "width": 64}}, {"id": 7, "name": "type", "nullable": true, "type": {"family": "StringFamily", "oid": 25}}], "formatVersion": 3, "id": 4294966962, "name": "geometry_columns", "nextColumnId": 8, "nextConstraintId": 2, "nextIndexId": 2, "nextMutationId": 1, "primaryIndex": {"constraintId": 1, "foreignKey": {}, "geoConfig": {}, "id": 1, "interleave": {}, "partitioning": {}, "sharded": {}, "vecConfig": {}}, "privileges": {"ownerProto": "node", "users": [{"privileges": "32", "userProto": "public"}], "version": 3}, "replacementOf": {"time": {}}, "unexposedParentSchemaId": 4294966964, "version": "1"}}
131131

132-
skipif config schema-locked-disabled
132+
skipif config schema-locked-disabled local-mixed-25.3
133133
query IT
134134
SELECT id, strip_volatile(descriptor) FROM crdb_internal.kv_catalog_descriptor WHERE id IN (1, 2, 3, 29, 4294966962) OR (id > 100 and id < 200) ORDER BY id
135135
----

pkg/sql/logictest/testdata/logic_test/owner

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -258,46 +258,46 @@ DROP ROLE testuser
258258

259259
user root
260260

261-
skipif config local-mixed-25.2
261+
skipif config local-mixed-25.2 local-mixed-25.3
262262
let $testuser_job_id
263263
SELECT id FROM system.jobs WHERE owner = 'testuser' LIMIT 1
264264

265-
skipif config local-mixed-25.2
265+
skipif config local-mixed-25.2 local-mixed-25.3
266266
let $testuser2_job_id
267267
SELECT id FROM system.jobs WHERE owner = 'testuser2' LIMIT 1
268268

269-
skipif config local-mixed-25.2
269+
skipif config local-mixed-25.2 local-mixed-25.3
270270
let $node_job_id
271271
SELECT id FROM system.jobs WHERE owner = 'node' LIMIT 1
272272

273-
skipif config local-mixed-25.2
273+
skipif config local-mixed-25.2 local-mixed-25.3
274274
# Verify a simple transfer by an admin from testuser to testuser2 and back.
275275
statement ok
276276
ALTER JOB $testuser_job_id OWNER TO testuser2
277277

278-
skipif config local-mixed-25.2
278+
skipif config local-mixed-25.2 local-mixed-25.3
279279
query T
280280
SELECT owner FROM system.jobs WHERE id = $testuser_job_id
281281
----
282282
testuser2
283283

284-
skipif config local-mixed-25.2
284+
skipif config local-mixed-25.2 local-mixed-25.3
285285
statement ok
286286
ALTER JOB $testuser_job_id OWNER TO testuser
287287

288-
skipif config local-mixed-25.2
288+
skipif config local-mixed-25.2 local-mixed-25.3
289289
query T
290290
SELECT owner FROM system.jobs WHERE id = $testuser_job_id
291291
----
292292
testuser
293293

294294
# Verify that ownership cannot transfer to or from 'node'.
295295

296-
skipif config local-mixed-25.2
296+
skipif config local-mixed-25.2 local-mixed-25.3
297297
statement error cannot transfer ownership
298298
ALTER JOB $node_job_id OWNER TO testuser
299299

300-
skipif config local-mixed-25.2
300+
skipif config local-mixed-25.2 local-mixed-25.3
301301
statement error cannot transfer ownership
302302
ALTER JOB $testuser_job_id OWNER TO node
303303

@@ -316,58 +316,58 @@ CREATE USER testuser3
316316
statement ok
317317
GRANT testrole TO testuser3
318318

319-
skipif config local-mixed-25.2
319+
skipif config local-mixed-25.2 local-mixed-25.3
320320
statement ok
321321
ALTER JOB $testuser_job_id OWNER TO testrole
322322

323-
skipif config local-mixed-25.2
323+
skipif config local-mixed-25.2 local-mixed-25.3
324324
query T
325325
SELECT owner FROM system.jobs WHERE id = $testuser_job_id
326326
----
327327
testrole
328328

329-
skipif config local-mixed-25.2
329+
skipif config local-mixed-25.2 local-mixed-25.3
330330
# Verify testuser2 can transfer ownership to themselves and back to testuser.
331331
statement ok
332332
ALTER JOB $testuser_job_id OWNER TO testuser2
333333

334-
skipif config local-mixed-25.2
334+
skipif config local-mixed-25.2 local-mixed-25.3
335335
query T
336336
SELECT owner FROM system.jobs WHERE id = $testuser_job_id
337337
----
338338
testuser2
339339

340-
skipif config local-mixed-25.2
340+
skipif config local-mixed-25.2 local-mixed-25.3
341341
statement ok
342342
ALTER JOB $testuser_job_id OWNER TO testuser
343343

344-
skipif config local-mixed-25.2
344+
skipif config local-mixed-25.2 local-mixed-25.3
345345
query T
346346
SELECT owner FROM system.jobs WHERE id = $testuser_job_id
347347
----
348348
testuser
349349

350350
user testuser3
351351

352-
skipif config local-mixed-25.2
352+
skipif config local-mixed-25.2 local-mixed-25.3
353353
# Verify testuser3 cannot transfer since they do not own it, including via role.
354354
statement error testuser3 does not own job
355355
ALTER JOB $testuser_job_id OWNER TO testuser3
356356

357357
# Now move ownership to testrole so testuser3 can transfer it.
358358
user testuser2
359359

360-
skipif config local-mixed-25.2
360+
skipif config local-mixed-25.2 local-mixed-25.3
361361
statement ok
362362
ALTER JOB $testuser_job_id OWNER TO testrole
363363

364364
user testuser3
365365

366-
skipif config local-mixed-25.2
366+
skipif config local-mixed-25.2 local-mixed-25.3
367367
statement ok
368368
ALTER JOB $testuser_job_id OWNER TO testuser3
369369

370-
skipif config local-mixed-25.2
370+
skipif config local-mixed-25.2 local-mixed-25.3
371371
# Verify testuser3, who is not an admin, cannot transfer to otherrole which they
372372
# are not a member of.
373373
statement error testuser3 cannot transfer ownership to otherrole

pkg/sql/logictest/testdata/logic_test/row_level_security

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# LogicTest: !local-legacy-schema-changer !local-mixed-25.2
1+
# LogicTest: !local-legacy-schema-changer !local-mixed-25.2 !local-mixed-25.3
22

33
subtest setup
44

pkg/sql/logictest/tests/local-mixed-25.3/generated_test.go

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)