Skip to content

Commit 66c2745

Browse files
committed
multiregionccl: update comments in test after a bug was fixed
The test had comments that described the buggy behavior. bb61a22 fixed the bug, so the comment needed updating. Release note: None
1 parent 22f815b commit 66c2745

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/ccl/multiregionccl/multiregion_system_table_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -632,12 +632,11 @@ func TestDropRegionFromUserDatabaseCleansUpSystemTables(t *testing.T) {
632632
// Drop a region from the USER database (not system database)
633633
sDB.Exec(t, `ALTER DATABASE userdb DROP REGION "us-east2"`)
634634

635-
// BUG: sql_instances table is now empty, but it shouldn't be
636-
// The region still exists in the system database, so instances should remain
635+
// Verify that dropping a region from a user database doesn't affect system.sql_instances.
636+
// The region still exists in the system database, so instances should remain unchanged.
637637
finalCount := sDB.QueryStr(t, `SELECT count(*) FROM system.sql_instances`)
638638
require.NotEmpty(t, finalCount)
639-
// This assertion will fail, demonstrating the bug.
640-
// The count should remain the same since we only dropped from userdb, not system
639+
// The count should remain the same since we only dropped from userdb, not system.
641640
require.Equal(t, initialCount[0][0], finalCount[0][0],
642641
"sql_instances count should not change when dropping region from user database")
643642
}

0 commit comments

Comments
 (0)