Skip to content

Commit 6b86260

Browse files
committed
roachtest: mark invalid step for network partition
The `waitForStableClusterVersionStep` cannot be run during a network partition as the nodes require communication between each other. This change marks it as incompatible when searching for a recovery index. Epic: none Release note: none Fixes: #151384
1 parent 7c9cfa3 commit 6b86260

File tree

1 file changed

+5
-1
lines changed
  • pkg/cmd/roachtest/roachtestutil/mixedversion

1 file changed

+5
-1
lines changed

pkg/cmd/roachtest/roachtestutil/mixedversion/mutators.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,6 +557,10 @@ func (m networkPartitionMutator) Generate(
557557
// Many hook steps require communication between specific nodes, so we
558558
// should recover the network partition before running them.
559559
_, runHook := s.impl.(runHookStep)
560+
// Waiting for stable cluster version requires communication between
561+
// all nodes in the cluster, so we should recover the network partition
562+
// before running it.
563+
_, waitForStable := s.impl.(waitForStableClusterVersionStep)
560564

561565
if idx.IsConcurrent(s) {
562566
if firstStepInConcurrentBlock == nil {
@@ -574,7 +578,7 @@ func (m networkPartitionMutator) Generate(
574578
} else {
575579
unavailableNodes = s.context.System.hasUnavailableNodes
576580
}
577-
return unavailableNodes || restartTenant || restartSystem || runHook
581+
return unavailableNodes || restartTenant || restartSystem || runHook || waitForStable
578582
}
579583

580584
_, validStartStep := upgrade.CutAfter(func(s *singleStep) bool {

0 commit comments

Comments
 (0)