Skip to content

Commit 6c161fa

Browse files
craig[bot]rafiss
andcommitted
Merge #146589
146589: roachtest: increase size of schemachange/bulkingest r=rafiss a=rafiss We are starting to test index backfills at larger scales. Let's make this test bigger so we can more easily track improvements over time. informs #146571 Release note: None Co-authored-by: Rafi Shamim <[email protected]>
2 parents 6113624 + f63c388 commit 6c161fa

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

pkg/cmd/roachtest/tests/schemachange.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ func makeIndexAddTpccTest(
330330
func registerSchemaChangeBulkIngest(r registry.Registry) {
331331
// Allow a long running time to account for runs that use a
332332
// cockroach build with runtime assertions enabled.
333-
r.Add(makeSchemaChangeBulkIngestTest(r, 5, 100000000, time.Minute*60))
333+
r.Add(makeSchemaChangeBulkIngestTest(r, 12, 4_000_000_000, 2*time.Hour))
334334
}
335335

336336
func makeSchemaChangeBulkIngestTest(
@@ -346,18 +346,20 @@ func makeSchemaChangeBulkIngestTest(
346346
Timeout: length * 2,
347347
// `fixtures import` (with the workload paths) is not supported in 2.1
348348
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
349-
// Configure column a to have sequential ascending values, and columns b and c to be constant.
350-
// The payload column will be randomized and thus uncorrelated with the primary key (a, b, c).
351-
aNum := numRows
349+
// Configure column a to have sequential ascending values. The payload
350+
// column will be randomized and thus uncorrelated with the primary key
351+
// (a, b, c).
352+
bNum := 1000
353+
cNum := 1000
354+
aNum := numRows / (bNum * cNum)
352355
if c.IsLocal() {
353356
aNum = 100000
357+
bNum = 1
358+
cNum = 1
354359
}
355-
bNum := 1
356-
cNum := 1
357-
payloadBytes := 4
360+
payloadBytes := 40
358361

359-
// TODO (lucy): Remove flag once the faster import is enabled by default
360-
settings := install.MakeClusterSettings(install.EnvOption([]string{"COCKROACH_IMPORT_WORKLOAD_FASTER=true"}))
362+
settings := install.MakeClusterSettings()
361363
c.Start(ctx, t.L(), option.DefaultStartOpts(), settings, c.CRDBNodes())
362364

363365
// Don't add another index when importing.

0 commit comments

Comments
 (0)