roachprod: improve instances filtering when listing on IBM

Cloud instance listing on IBM was previously filtering out VMs that
lacked the `roachprod` tag. However, the IBM API occasionally returns a
successful response for tagging requests without actually acting on it.
This inconsistency resulted in some VMs being skipped in the garbage
colelction process because lacking the required tags.

This PR removes the dependency on the `roachprod` tag, and all resources
within the `roachprod` resource group are now considered game for
garbage collection.

Epic: none
Release note: None

Author: golgeek

pkg/roachprod/vm/ibm/helpers.go

@@ -833,7 +833,7 @@ func (p *Provider) listRegion(l *logger.Logger, r string, opts vm.ListOptions) (
 			}
 		}
 
-		valid, reason := i.isRoachprodAndValidStatus()
+		valid, reason := i.isValidStatus()
 		if !valid {
 			l.Printf("WARN: discarding instance %s in region %s (%s)", *i.instance.CRN, r, reason)
 			continue

pkg/roachprod/vm/ibm/ibm_extended_types.go

@@ -485,25 +485,11 @@ func (i *instance) getPrimaryNetworkInterface() (*vpcv1NetworkInterface, error)
 	return i.networkInterface, nil
 }
 
-// isRoachprodAndValidStatus checks if a roahcprod instance in valid status.
-func (i *instance) isRoachprodAndValidStatus() (bool, string) {
+// isValidStatus checks if an instance has a valid status.
+func (i *instance) isValidStatus() (bool, string) {
 	if i == nil || i.instance == nil || i.instance.Status == nil {
 		return false, InstanceNotInitialized
 	}
-
-	tags, err := i.getTagsAsMap()
-	if err != nil {
-		return false, InstanceInvalidTags
-	}
-
-	if tags[vm.TagRoachprod] != "true" {
-		return false, InstanceNotRochprod
-	}
-
-	// if *i.instance.Status != "pending" && *i.instance.Status != "running" {
-	// 	return false, InstanceInvalidStatus
-	// }
-
 	return true, ""
 }
 
@@ -585,6 +571,11 @@ func (i *instance) toVM() vm.VM {
 		vpcID = i.provider.config.regions[region].vpcID
 	}
 
+	// Check if the instance is in a valid state.
+	if core.StringNilMapper(i.instance.Status) == "failed" {
+		vmErrors = append(vmErrors, errors.New("instance is in failed state"))
+	}
+
 	// Gather tags
 	tags, err := i.getTagsAsMap()
 	if err != nil {