Skip to content

Commit 6c5e164

Browse files
committed
ui: reorder storage dashboard graphs
Move the file descriptor and time series graphs to the bottom of the storage dashboard. These graphs are relatively niche and less useful than the other graphs within the dashboard. Epic: none Release note: none
1 parent 736723e commit 6c5e164

File tree

1 file changed

+69
-68
lines changed
  • pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards

1 file changed

+69
-68
lines changed

pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/storage.tsx

Lines changed: 69 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -260,21 +260,6 @@ export default function (props: GraphDashboardProps) {
260260
</Axis>
261261
</LineGraph>,
262262

263-
<LineGraph
264-
title="File Descriptors"
265-
sources={nodeSources}
266-
isKvGraph={true}
267-
tenantSource={tenantSource}
268-
tooltip={`The number of open file descriptors ${tooltipSelection}, compared with
269-
the file descriptor limit.`}
270-
showMetricsInTooltip={true}
271-
>
272-
<Axis label="descriptors">
273-
<Metric name="cr.node.sys.fd.open" title="Open" />
274-
<Metric name="cr.node.sys.fd.softlimit" title="Limit" />
275-
</Axis>
276-
</LineGraph>,
277-
278263
<LineGraph
279264
title="Flushes"
280265
sources={storeSources}
@@ -374,59 +359,6 @@ export default function (props: GraphDashboardProps) {
374359
</Axis>
375360
</LineGraph>,
376361

377-
<LineGraph
378-
title="Time Series Writes"
379-
sources={nodeSources}
380-
isKvGraph={true}
381-
tenantSource={tenantSource}
382-
tooltip={`The number of successfully written time series samples, and number of
383-
errors attempting to write time series, per second ${tooltipSelection}.`}
384-
showMetricsInTooltip={true}
385-
>
386-
<Axis label="count">
387-
<Metric
388-
name="cr.node.timeseries.write.samples"
389-
title="Samples Written"
390-
nonNegativeRate
391-
/>
392-
<Metric
393-
name="cr.node.timeseries.write.errors"
394-
title="Errors"
395-
nonNegativeRate
396-
/>
397-
</Axis>
398-
</LineGraph>,
399-
400-
<LineGraph
401-
title="Time Series Bytes Written"
402-
sources={nodeSources}
403-
isKvGraph={true}
404-
tenantSource={tenantSource}
405-
tooltip={
406-
<div>
407-
The number of bytes written by the time series system per second{" "}
408-
{tooltipSelection}.
409-
<br />
410-
Note that this does not reflect the rate at which disk space is
411-
consumed by time series; the data is highly compressed on disk. This
412-
rate is instead intended to indicate the amount of network traffic and
413-
disk activity generated by time series writes.
414-
<br />
415-
See the "databases" tab to find the current disk usage for time series
416-
data.
417-
</div>
418-
}
419-
showMetricsInTooltip={true}
420-
>
421-
<Axis units={AxisUnits.Bytes}>
422-
<Metric
423-
name="cr.node.timeseries.write.bytes"
424-
title="Bytes Written"
425-
nonNegativeRate
426-
/>
427-
</Axis>
428-
</LineGraph>,
429-
430362
<LineGraph
431363
title="Disk Write Breakdown"
432364
sources={storeSources}
@@ -516,5 +448,74 @@ export default function (props: GraphDashboardProps) {
516448
)}
517449
</Axis>
518450
</LineGraph>,
451+
452+
<LineGraph
453+
title="File Descriptors"
454+
sources={nodeSources}
455+
isKvGraph={true}
456+
tenantSource={tenantSource}
457+
tooltip={`The number of open file descriptors ${tooltipSelection}, compared with
458+
the file descriptor limit.`}
459+
showMetricsInTooltip={true}
460+
>
461+
<Axis label="descriptors">
462+
<Metric name="cr.node.sys.fd.open" title="Open" />
463+
<Metric name="cr.node.sys.fd.softlimit" title="Limit" />
464+
</Axis>
465+
</LineGraph>,
466+
467+
<LineGraph
468+
title="Time Series Writes"
469+
sources={nodeSources}
470+
isKvGraph={true}
471+
tenantSource={tenantSource}
472+
tooltip={`The number of successfully written time series samples, and number of
473+
errors attempting to write time series, per second ${tooltipSelection}.`}
474+
showMetricsInTooltip={true}
475+
>
476+
<Axis label="count">
477+
<Metric
478+
name="cr.node.timeseries.write.samples"
479+
title="Samples Written"
480+
nonNegativeRate
481+
/>
482+
<Metric
483+
name="cr.node.timeseries.write.errors"
484+
title="Errors"
485+
nonNegativeRate
486+
/>
487+
</Axis>
488+
</LineGraph>,
489+
490+
<LineGraph
491+
title="Time Series Bytes Written"
492+
sources={nodeSources}
493+
isKvGraph={true}
494+
tenantSource={tenantSource}
495+
tooltip={
496+
<div>
497+
The number of bytes written by the time series system per second{" "}
498+
{tooltipSelection}.
499+
<br />
500+
Note that this does not reflect the rate at which disk space is
501+
consumed by time series; the data is highly compressed on disk. This
502+
rate is instead intended to indicate the amount of network traffic and
503+
disk activity generated by time series writes.
504+
<br />
505+
See the "databases" tab to find the current disk usage for time series
506+
data.
507+
</div>
508+
}
509+
showMetricsInTooltip={true}
510+
>
511+
<Axis units={AxisUnits.Bytes}>
512+
<Metric
513+
name="cr.node.timeseries.write.bytes"
514+
title="Bytes Written"
515+
nonNegativeRate
516+
/>
517+
</Axis>
518+
</LineGraph>,
519+
519520
];
520521
}

0 commit comments

Comments
 (0)