storage: update pebble configuration code

Update Pebble configuration code to use compression definitions from
`sstable` and to use the separated `TargetFileSizes`.

Epic: none
Release note: None

Author: RaduBerinde

pkg/storage/metamorphic/options.go

@@ -110,17 +110,14 @@ func randomOptions() *pebble.Options {
 	if opts.L0StopWritesThreshold < opts.L0CompactionThreshold {
 		opts.L0StopWritesThreshold = opts.L0CompactionThreshold
 	}
-	for i := range opts.Levels {
-		if i == 0 {
-			opts.Levels[i].BlockRestartInterval = int(rngIntRange(rng, 1, 64))
-			opts.Levels[i].BlockSize = 1 << rngIntRange(rng, 1, 20)
-			opts.Levels[i].BlockSizeThreshold = int(rngIntRange(rng, 50, 100))
-			opts.Levels[i].IndexBlockSize = opts.Levels[i].BlockSize
-			opts.Levels[i].TargetFileSize = 1 << rngIntRange(rng, 1, 20)
-		} else {
-			opts.Levels[i] = opts.Levels[i-1]
-			opts.Levels[i].TargetFileSize = opts.Levels[i-1].TargetFileSize * 2
-		}
+	opts.Levels[0].BlockRestartInterval = int(rngIntRange(rng, 1, 64))
+	opts.Levels[0].BlockSize = 1 << rngIntRange(rng, 1, 20)
+	opts.Levels[0].BlockSizeThreshold = int(rngIntRange(rng, 50, 100))
+	opts.Levels[0].IndexBlockSize = opts.Levels[0].BlockSize
+	opts.TargetFileSizes[0] = 1 << rngIntRange(rng, 1, 20)
+	for i := 1; i < len(opts.Levels); i++ {
+		opts.Levels[i] = opts.Levels[i-1]
+		opts.TargetFileSizes[i] = opts.TargetFileSizes[i-1] * 2
 	}
 	opts.MaxManifestFileSize = 1 << rngIntRange(rng, 1, 28)
 	opts.MaxOpenFiles = int(rngIntRange(rng, 20, 2000))

pkg/storage/open.go

@@ -127,8 +127,8 @@ func BlockSize(size int) ConfigOption {
 // primarily for testing purposes.
 func TargetFileSize(size int64) ConfigOption {
 	return func(cfg *engineConfig) error {
-		for i := range cfg.opts.Levels {
-			cfg.opts.Levels[i].TargetFileSize = size
+		for i := range cfg.opts.TargetFileSizes {
+			cfg.opts.TargetFileSizes[i] = size
 		}
 		return nil
 	}

pkg/storage/pebble.go

@@ -267,20 +267,20 @@ func getCompressionProfile(
 	ctx context.Context,
 	settings *cluster.Settings,
 	setting *settings.EnumSetting[CompressionAlgorithm],
-) *pebble.CompressionProfile {
+) *sstable.CompressionProfile {
 	switch setting.Get(&settings.SV) {
 	case CompressionAlgorithmSnappy:
-		return pebble.SnappyCompression
+		return sstable.SnappyCompression
 	case CompressionAlgorithmZstd:
-		return pebble.ZstdCompression
+		return sstable.ZstdCompression
 	case CompressionAlgorithmNone:
-		return pebble.NoCompression
+		return sstable.NoCompression
 	case CompressionAlgorithmMinLZ:
-		return pebble.MinLZCompression
+		return sstable.MinLZCompression
 	case CompressionAlgorithmFastest:
-		return pebble.FastestCompression
+		return sstable.FastestCompression
 	default:
-		return pebble.DefaultCompression
+		return sstable.DefaultCompression
 	}
 }
 
@@ -494,7 +494,6 @@ func DefaultPebbleOptions() *pebble.Options {
 		l.IndexBlockSize = 256 << 10 // 256 KB
 		l.FilterPolicy = bloom.FilterPolicy(10)
 		l.FilterType = pebble.TableFilter
-		l.TargetFileSize = opts.Levels[i-1].TargetFileSize * 2
 		l.EnsureL1PlusDefaults(&opts.Levels[i-1])
 	}