Skip to content

Commit 6f0252f

Browse files
shghasemishghasemi
committed
sql: rename schema changer attr Comment to a generic name
This change renames `Comment` to `Value` to be used as a generic string type in other schema changer elements. This attr is not used to filter schema change element, and can be used as a generic type to avoid adding new attrs. Epic: CRDB-31283 Release note: None
1 parent ae0b3d7 commit 6f0252f

33 files changed

+194
-189
lines changed

‎pkg/sql/schemachanger/scbuild/testdata/alter_table_alter_primary_key‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ ALTER TABLE defaultdb.foo ALTER PRIMARY KEY USING COLUMNS (j)
1616
{constraintId: 1, indexId: 1, isUnique: true, tableId: 104}
1717
- [[IndexName:{DescID: 104, Name: pkey, IndexID: 1}, ABSENT], PUBLIC]
1818
{indexId: 1, name: pkey, tableId: 104}
19-
- [[IndexComment:{DescID: 104, IndexID: 1, Comment: pkey is an index}, ABSENT], PUBLIC]
19+
- [[IndexComment:{DescID: 104, IndexID: 1, Value: pkey is an index}, ABSENT], PUBLIC]
2020
{comment: pkey is an index, indexId: 1, tableId: 104}
21-
- [[ConstraintComment:{DescID: 104, ConstraintID: 1, Comment: pkey is a constraint}, ABSENT], PUBLIC]
21+
- [[ConstraintComment:{DescID: 104, ConstraintID: 1, Value: pkey is a constraint}, ABSENT], PUBLIC]
2222
{comment: pkey is a constraint, constraintId: 1, tableId: 104}
2323
- [[IndexData:{DescID: 104, IndexID: 1}, ABSENT], PUBLIC]
2424
{indexId: 1, tableId: 104}
@@ -32,9 +32,9 @@ ALTER TABLE defaultdb.foo ALTER PRIMARY KEY USING COLUMNS (j)
3232
{columnId: 1, indexId: 4, kind: STORED, tableId: 104}
3333
- [[IndexColumn:{DescID: 104, ColumnID: 2, IndexID: 4}, PUBLIC], ABSENT]
3434
{columnId: 2, indexId: 4, tableId: 104}
35-
- [[IndexComment:{DescID: 104, IndexID: 4, Comment: pkey is an index}, PUBLIC], ABSENT]
35+
- [[IndexComment:{DescID: 104, IndexID: 4, Value: pkey is an index}, PUBLIC], ABSENT]
3636
{comment: pkey is an index, indexId: 4, tableId: 104}
37-
- [[ConstraintComment:{DescID: 104, ConstraintID: 4, Comment: pkey is a constraint}, PUBLIC], ABSENT]
37+
- [[ConstraintComment:{DescID: 104, ConstraintID: 4, Value: pkey is a constraint}, PUBLIC], ABSENT]
3838
{comment: pkey is a constraint, constraintId: 4, tableId: 104}
3939
- [[IndexData:{DescID: 104, IndexID: 4}, PUBLIC], ABSENT]
4040
{indexId: 4, tableId: 104}

‎pkg/sql/schemachanger/scbuild/testdata/alter_table_drop_column‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ ALTER TABLE defaultdb.t DROP COLUMN j
2424
{columnId: 2, tableId: 104}
2525
- [[ColumnDefaultExpression:{DescID: 104, ColumnID: 2, Expr: 42:::INT8}, ABSENT], PUBLIC]
2626
{columnId: 2, expr: '42:::INT8', tableId: 104}
27-
- [[ColumnComment:{DescID: 104, ColumnID: 2, Comment: column will drop}, ABSENT], PUBLIC]
27+
- [[ColumnComment:{DescID: 104, ColumnID: 2, Value: column will drop}, ABSENT], PUBLIC]
2828
{columnId: 2, comment: column will drop, pgAttributeNum: 2, tableId: 104}
2929
- [[IndexColumn:{DescID: 104, ColumnID: 1, IndexID: 1}, ABSENT], PUBLIC]
3030
{columnId: 1, indexId: 1, tableId: 104}

‎pkg/sql/schemachanger/scbuild/testdata/comment_on‎

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ CREATE TABLE customer (
1111
build
1212
COMMENT ON DATABASE defaultdb IS 'defaultdb is good';
1313
----
14-
- [[DatabaseComment:{DescID: 100, Comment: defaultdb is good}, PUBLIC], ABSENT]
14+
- [[DatabaseComment:{DescID: 100, Value: defaultdb is good}, PUBLIC], ABSENT]
1515
{comment: defaultdb is good, databaseId: 100}
1616

1717
setup
@@ -21,13 +21,13 @@ COMMENT ON DATABASE defaultdb IS 'defaultdb real comment';
2121
build
2222
COMMENT ON DATABASE defaultdb IS 'defaultdb is better';
2323
----
24-
- [[DatabaseComment:{DescID: 100, Comment: defaultdb is better}, PUBLIC], ABSENT]
24+
- [[DatabaseComment:{DescID: 100, Value: defaultdb is better}, PUBLIC], ABSENT]
2525
{comment: defaultdb is better, databaseId: 100}
2626

2727
build
2828
COMMENT ON DATABASE defaultdb IS NULL;
2929
----
30-
- [[DatabaseComment:{DescID: 100, Comment: defaultdb real comment}, ABSENT], PUBLIC]
30+
- [[DatabaseComment:{DescID: 100, Value: defaultdb real comment}, ABSENT], PUBLIC]
3131
{comment: defaultdb real comment, databaseId: 100}
3232

3333
setup
@@ -41,7 +41,7 @@ COMMENT ON SCHEMA test_schema IS 'public schema real comment';
4141
build
4242
COMMENT ON SCHEMA test_schema IS 'public schema is good';
4343
----
44-
- [[SchemaComment:{DescID: 105, Comment: public schema is good}, PUBLIC], ABSENT]
44+
- [[SchemaComment:{DescID: 105, Value: public schema is good}, PUBLIC], ABSENT]
4545
{comment: public schema is good, schemaId: 105}
4646

4747
setup
@@ -51,13 +51,13 @@ COMMENT ON SCHEMA test_schema IS 'public schema real comment';
5151
build
5252
COMMENT ON SCHEMA test_schema IS 'public schema is better';
5353
----
54-
- [[SchemaComment:{DescID: 105, Comment: public schema is better}, PUBLIC], ABSENT]
54+
- [[SchemaComment:{DescID: 105, Value: public schema is better}, PUBLIC], ABSENT]
5555
{comment: public schema is better, schemaId: 105}
5656

5757
build
5858
COMMENT ON SCHEMA test_schema IS NULL;
5959
----
60-
- [[SchemaComment:{DescID: 105, Comment: public schema real comment}, ABSENT], PUBLIC]
60+
- [[SchemaComment:{DescID: 105, Value: public schema real comment}, ABSENT], PUBLIC]
6161
{comment: public schema real comment, schemaId: 105}
6262

6363
build
@@ -69,7 +69,7 @@ COMMENT ON TABLE customer IS 'customer is god';
6969
{indexId: 2, tableId: 104}
7070
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
7171
{databaseId: 100, tableId: 104}
72-
- [[TableComment:{DescID: 104, Comment: customer is god}, PUBLIC], ABSENT]
72+
- [[TableComment:{DescID: 104, Value: customer is god}, PUBLIC], ABSENT]
7373
{comment: customer is god, tableId: 104}
7474

7575
setup
@@ -85,13 +85,13 @@ COMMENT ON TABLE customer IS 'customer gets better';
8585
{indexId: 2, tableId: 104}
8686
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
8787
{databaseId: 100, tableId: 104}
88-
- [[TableComment:{DescID: 104, Comment: customer gets better}, PUBLIC], ABSENT]
88+
- [[TableComment:{DescID: 104, Value: customer gets better}, PUBLIC], ABSENT]
8989
{comment: customer gets better, tableId: 104}
9090

9191
build
9292
COMMENT ON TABLE customer IS NULL;
9393
----
94-
- [[TableComment:{DescID: 104, Comment: customer real comment}, ABSENT], PUBLIC]
94+
- [[TableComment:{DescID: 104, Value: customer real comment}, ABSENT], PUBLIC]
9595
{comment: customer real comment, tableId: 104}
9696
- [[IndexData:{DescID: 104, IndexID: 1}, PUBLIC], PUBLIC]
9797
{indexId: 1, tableId: 104}
@@ -109,7 +109,7 @@ COMMENT ON COLUMN customer.name IS 'some comment for name';
109109
{indexId: 2, tableId: 104}
110110
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
111111
{databaseId: 100, tableId: 104}
112-
- [[ColumnComment:{DescID: 104, ColumnID: 2, Comment: some comment for name}, PUBLIC], ABSENT]
112+
- [[ColumnComment:{DescID: 104, ColumnID: 2, Value: some comment for name}, PUBLIC], ABSENT]
113113
{columnId: 2, comment: some comment for name, tableId: 104}
114114

115115
setup
@@ -125,13 +125,13 @@ COMMENT ON COLUMN customer.name IS 'some better comment for name';
125125
{indexId: 2, tableId: 104}
126126
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
127127
{databaseId: 100, tableId: 104}
128-
- [[ColumnComment:{DescID: 104, ColumnID: 2, Comment: some better comment for name}, PUBLIC], ABSENT]
128+
- [[ColumnComment:{DescID: 104, ColumnID: 2, Value: some better comment for name}, PUBLIC], ABSENT]
129129
{columnId: 2, comment: some better comment for name, tableId: 104}
130130

131131
build
132132
COMMENT ON COLUMN customer.name IS NULL;
133133
----
134-
- [[ColumnComment:{DescID: 104, ColumnID: 2, Comment: real comment for name}, ABSENT], PUBLIC]
134+
- [[ColumnComment:{DescID: 104, ColumnID: 2, Value: real comment for name}, ABSENT], PUBLIC]
135135
{columnId: 2, comment: real comment for name, pgAttributeNum: 2, tableId: 104}
136136
- [[IndexData:{DescID: 104, IndexID: 1}, PUBLIC], PUBLIC]
137137
{indexId: 1, tableId: 104}
@@ -149,7 +149,7 @@ COMMENT ON INDEX customer@idx_customer_name IS 'comment on name index';
149149
{indexId: 2, tableId: 104}
150150
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
151151
{databaseId: 100, tableId: 104}
152-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: comment on name index}, PUBLIC], ABSENT]
152+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: comment on name index}, PUBLIC], ABSENT]
153153
{comment: comment on name index, indexId: 2, tableId: 104}
154154

155155
build
@@ -161,7 +161,7 @@ COMMENT ON INDEX public.idx_customer_name IS 'comment on name index';
161161
{indexId: 2, tableId: 104}
162162
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
163163
{databaseId: 100, tableId: 104}
164-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: comment on name index}, PUBLIC], ABSENT]
164+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: comment on name index}, PUBLIC], ABSENT]
165165
{comment: comment on name index, indexId: 2, tableId: 104}
166166

167167
build
@@ -173,7 +173,7 @@ COMMENT ON INDEX defaultdb.idx_customer_name IS 'comment on name index';
173173
{indexId: 2, tableId: 104}
174174
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
175175
{databaseId: 100, tableId: 104}
176-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: comment on name index}, PUBLIC], ABSENT]
176+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: comment on name index}, PUBLIC], ABSENT]
177177
{comment: comment on name index, indexId: 2, tableId: 104}
178178

179179
setup
@@ -189,15 +189,15 @@ COMMENT ON INDEX customer@idx_customer_name IS 'better comment for name index';
189189
{indexId: 2, tableId: 104}
190190
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
191191
{databaseId: 100, tableId: 104}
192-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: better comment for name index}, PUBLIC], ABSENT]
192+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: better comment for name index}, PUBLIC], ABSENT]
193193
{comment: better comment for name index, indexId: 2, tableId: 104}
194194

195195
build
196196
COMMENT ON INDEX customer@idx_customer_name IS NULL;
197197
----
198198
- [[IndexData:{DescID: 104, IndexID: 1}, PUBLIC], PUBLIC]
199199
{indexId: 1, tableId: 104}
200-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: real comment on name index}, ABSENT], PUBLIC]
200+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: real comment on name index}, ABSENT], PUBLIC]
201201
{comment: real comment on name index, indexId: 2, tableId: 104}
202202
- [[IndexData:{DescID: 104, IndexID: 2}, PUBLIC], PUBLIC]
203203
{indexId: 2, tableId: 104}
@@ -213,15 +213,15 @@ COMMENT ON INDEX customer@idx_customer_name IS 'better comment for name index'
213213
{indexId: 2, tableId: 104}
214214
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
215215
{databaseId: 100, tableId: 104}
216-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: better comment for name index}, PUBLIC], ABSENT]
216+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: better comment for name index}, PUBLIC], ABSENT]
217217
{comment: better comment for name index, indexId: 2, tableId: 104}
218218

219219
build
220220
COMMENT ON INDEX customer@idx_customer_name IS NULL;
221221
----
222222
- [[IndexData:{DescID: 104, IndexID: 1}, PUBLIC], PUBLIC]
223223
{indexId: 1, tableId: 104}
224-
- [[IndexComment:{DescID: 104, IndexID: 2, Comment: real comment on name index}, ABSENT], PUBLIC]
224+
- [[IndexComment:{DescID: 104, IndexID: 2, Value: real comment on name index}, ABSENT], PUBLIC]
225225
{comment: real comment on name index, indexId: 2, tableId: 104}
226226
- [[IndexData:{DescID: 104, IndexID: 2}, PUBLIC], PUBLIC]
227227
{indexId: 2, tableId: 104}
@@ -237,7 +237,7 @@ COMMENT ON CONSTRAINT customer_age_gt_21 ON customer IS 'better be old enough'
237237
{indexId: 2, tableId: 104}
238238
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
239239
{databaseId: 100, tableId: 104}
240-
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Comment: better be old enough}, PUBLIC], ABSENT]
240+
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Value: better be old enough}, PUBLIC], ABSENT]
241241
{comment: better be old enough, constraintId: 2, tableId: 104}
242242

243243
setup
@@ -253,7 +253,7 @@ COMMENT ON CONSTRAINT customer_age_gt_21 ON customer IS 'better be old enough'
253253
{indexId: 2, tableId: 104}
254254
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
255255
{databaseId: 100, tableId: 104}
256-
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Comment: better be old enough}, PUBLIC], ABSENT]
256+
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Value: better be old enough}, PUBLIC], ABSENT]
257257
{comment: better be old enough, constraintId: 2, tableId: 104}
258258

259259
build
@@ -263,7 +263,7 @@ COMMENT ON CONSTRAINT customer_age_gt_21 ON customer IS NULL
263263
{indexId: 1, tableId: 104}
264264
- [[IndexData:{DescID: 104, IndexID: 2}, PUBLIC], PUBLIC]
265265
{indexId: 2, tableId: 104}
266-
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Comment: real constraint comment}, ABSENT], PUBLIC]
266+
- [[ConstraintComment:{DescID: 104, ConstraintID: 2, Value: real constraint comment}, ABSENT], PUBLIC]
267267
{comment: real constraint comment, constraintId: 2, tableId: 104}
268268
- [[TableData:{DescID: 104, ReferencedDescID: 100}, PUBLIC], PUBLIC]
269269
{databaseId: 100, tableId: 104}
@@ -276,13 +276,13 @@ CREATE TYPE roach_legs AS (legs INT);
276276
build
277277
COMMENT ON TYPE roach_dwellings IS 'First CRDB comment on types';
278278
----
279-
- [[TypeComment:{DescID: 106, Comment: First CRDB comment on types}, PUBLIC], ABSENT]
279+
- [[TypeComment:{DescID: 106, Value: First CRDB comment on types}, PUBLIC], ABSENT]
280280
{comment: First CRDB comment on types, typeId: 106}
281281

282282
build
283283
COMMENT ON TYPE roach_legs IS 'Second CRDB comment on types';
284284
----
285-
- [[TypeComment:{DescID: 108, Comment: Second CRDB comment on types}, PUBLIC], ABSENT]
285+
- [[TypeComment:{DescID: 108, Value: Second CRDB comment on types}, PUBLIC], ABSENT]
286286
{comment: Second CRDB comment on types, typeId: 108}
287287

288288
setup
@@ -293,11 +293,11 @@ COMMENT ON TYPE roach_legs IS 'Second CRDB comment on types';
293293
build
294294
COMMENT ON TYPE roach_dwellings IS NULL;
295295
----
296-
- [[TypeComment:{DescID: 106, Comment: First CRDB comment on types}, ABSENT], PUBLIC]
296+
- [[TypeComment:{DescID: 106, Value: First CRDB comment on types}, ABSENT], PUBLIC]
297297
{comment: First CRDB comment on types, typeId: 106}
298298

299299
build
300300
COMMENT ON TYPE roach_legs IS NULL;
301301
----
302-
- [[TypeComment:{DescID: 108, Comment: Second CRDB comment on types}, ABSENT], PUBLIC]
302+
- [[TypeComment:{DescID: 108, Value: Second CRDB comment on types}, ABSENT], PUBLIC]
303303
{comment: Second CRDB comment on types, typeId: 108}

‎pkg/sql/schemachanger/scbuild/testdata/drop_database‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ DROP DATABASE db1 CASCADE
3535
{databaseId: 104}
3636
- [[DatabaseRoleSetting:{DescID: 104, Name: __placeholder_role_name__}, ABSENT], PUBLIC]
3737
{databaseId: 104, roleName: __placeholder_role_name__}
38-
- [[DatabaseComment:{DescID: 104, Comment: db1 is good}, ABSENT], PUBLIC]
38+
- [[DatabaseComment:{DescID: 104, Value: db1 is good}, ABSENT], PUBLIC]
3939
{comment: db1 is good, databaseId: 104}
4040
- [[DatabaseData:{DescID: 104}, ABSENT], PUBLIC]
4141
{databaseId: 104}
@@ -65,7 +65,7 @@ DROP DATABASE db1 CASCADE
6565
{schemaId: 106}
6666
- [[SchemaParent:{DescID: 106, ReferencedDescID: 104}, ABSENT], PUBLIC]
6767
{parentDatabaseId: 104, schemaId: 106}
68-
- [[SchemaComment:{DescID: 106, Comment: sc1 is good}, ABSENT], PUBLIC]
68+
- [[SchemaComment:{DescID: 106, Value: sc1 is good}, ABSENT], PUBLIC]
6969
{comment: sc1 is good, schemaId: 106}
7070
- [[Namespace:{DescID: 107, Name: sq1, ReferencedDescID: 104}, ABSENT], PUBLIC]
7171
{databaseId: 104, descriptorId: 107, name: sq1, schemaId: 105}
@@ -181,7 +181,7 @@ DROP DATABASE db1 CASCADE
181181
{tableId: 109}
182182
- [[SchemaChild:{DescID: 109, ReferencedDescID: 106}, ABSENT], PUBLIC]
183183
{childObjectId: 109, schemaId: 106}
184-
- [[TableComment:{DescID: 109, Comment: t1 is good}, ABSENT], PUBLIC]
184+
- [[TableComment:{DescID: 109, Value: t1 is good}, ABSENT], PUBLIC]
185185
{comment: t1 is good, tableId: 109}
186186
- [[ColumnFamily:{DescID: 109, Name: primary, ColumnFamilyID: 0}, ABSENT], PUBLIC]
187187
{name: primary, tableId: 109}
@@ -193,7 +193,7 @@ DROP DATABASE db1 CASCADE
193193
{columnId: 1, elementCreationMetadata: {in243OrLater: true, in261OrLater: true}, tableId: 109, type: {family: IntFamily, oid: 20, width: 64}, typeName: INT8}
194194
- [[ColumnNotNull:{DescID: 109, ColumnID: 1, IndexID: 0}, ABSENT], PUBLIC]
195195
{columnId: 1, tableId: 109}
196-
- [[ColumnComment:{DescID: 109, ColumnID: 1, Comment: id is good}, ABSENT], PUBLIC]
196+
- [[ColumnComment:{DescID: 109, ColumnID: 1, Value: id is good}, ABSENT], PUBLIC]
197197
{columnId: 1, comment: id is good, pgAttributeNum: 1, tableId: 109}
198198
- [[Column:{DescID: 109, ColumnID: 2}, ABSENT], PUBLIC]
199199
{columnId: 2, tableId: 109}
@@ -243,7 +243,7 @@ DROP DATABASE db1 CASCADE
243243
{constraintId: 1, indexId: 1, isUnique: true, tableId: 109}
244244
- [[IndexName:{DescID: 109, Name: t1_pkey, IndexID: 1}, ABSENT], PUBLIC]
245245
{indexId: 1, name: t1_pkey, tableId: 109}
246-
- [[IndexComment:{DescID: 109, IndexID: 1, Comment: t1_pkey is good}, ABSENT], PUBLIC]
246+
- [[IndexComment:{DescID: 109, IndexID: 1, Value: t1_pkey is good}, ABSENT], PUBLIC]
247247
{comment: t1_pkey is good, indexId: 1, tableId: 109}
248248
- [[IndexData:{DescID: 109, IndexID: 1}, ABSENT], PUBLIC]
249249
{indexId: 1, tableId: 109}

‎pkg/sql/schemachanger/scbuild/testdata/drop_schema‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ DROP SCHEMA defaultdb.SC1 CASCADE
3131
{schemaId: 104}
3232
- [[SchemaParent:{DescID: 104, ReferencedDescID: 100}, ABSENT], PUBLIC]
3333
{parentDatabaseId: 100, schemaId: 104}
34-
- [[SchemaComment:{DescID: 104, Comment: sc1 is good}, ABSENT], PUBLIC]
34+
- [[SchemaComment:{DescID: 104, Value: sc1 is good}, ABSENT], PUBLIC]
3535
{comment: sc1 is good, schemaId: 104}
3636
- [[Namespace:{DescID: 106, Name: sq1, ReferencedDescID: 100}, ABSENT], PUBLIC]
3737
{databaseId: 100, descriptorId: 106, name: sq1, schemaId: 104}
@@ -59,7 +59,7 @@ DROP SCHEMA defaultdb.SC1 CASCADE
5959
{tableId: 107}
6060
- [[SchemaChild:{DescID: 107, ReferencedDescID: 104}, ABSENT], PUBLIC]
6161
{childObjectId: 107, schemaId: 104}
62-
- [[TableComment:{DescID: 107, Comment: t1 is good}, ABSENT], PUBLIC]
62+
- [[TableComment:{DescID: 107, Value: t1 is good}, ABSENT], PUBLIC]
6363
{comment: t1 is good, tableId: 107}
6464
- [[ColumnFamily:{DescID: 107, Name: primary, ColumnFamilyID: 0}, ABSENT], PUBLIC]
6565
{name: primary, tableId: 107}
@@ -71,7 +71,7 @@ DROP SCHEMA defaultdb.SC1 CASCADE
7171
{columnId: 1, elementCreationMetadata: {in243OrLater: true, in261OrLater: true}, tableId: 107, type: {family: IntFamily, oid: 20, width: 64}, typeName: INT8}
7272
- [[ColumnNotNull:{DescID: 107, ColumnID: 1, IndexID: 0}, ABSENT], PUBLIC]
7373
{columnId: 1, tableId: 107}
74-
- [[ColumnComment:{DescID: 107, ColumnID: 1, Comment: id is good}, ABSENT], PUBLIC]
74+
- [[ColumnComment:{DescID: 107, ColumnID: 1, Value: id is good}, ABSENT], PUBLIC]
7575
{columnId: 1, comment: id is good, pgAttributeNum: 1, tableId: 107}
7676
- [[Column:{DescID: 107, ColumnID: 2}, ABSENT], PUBLIC]
7777
{columnId: 2, tableId: 107}
@@ -121,7 +121,7 @@ DROP SCHEMA defaultdb.SC1 CASCADE
121121
{constraintId: 1, indexId: 1, isUnique: true, tableId: 107}
122122
- [[IndexName:{DescID: 107, Name: t1_pkey, IndexID: 1}, ABSENT], PUBLIC]
123123
{indexId: 1, name: t1_pkey, tableId: 107}
124-
- [[IndexComment:{DescID: 107, IndexID: 1, Comment: t1_pkey is good}, ABSENT], PUBLIC]
124+
- [[IndexComment:{DescID: 107, IndexID: 1, Value: t1_pkey is good}, ABSENT], PUBLIC]
125125
{comment: t1_pkey is good, indexId: 1, tableId: 107}
126126
- [[IndexData:{DescID: 107, IndexID: 1}, ABSENT], PUBLIC]
127127
{indexId: 1, tableId: 107}

0 commit comments

Comments
 (0)