Skip to content

Commit 70acc70

Browse files
craig[bot]ajstorm
andcommitted
Merge #149676
149676: perf: faster allocator on sysbench settings r=tbg a=ajstorm We're seeing some inter-run instability when running sysbench oltp_read_write to the tune of 1-2% CoV with repeated 10 minute runs. Some digging has pointed to the fact that the allocator is both not aggressive enough at the beginning of runs, and that its CPU threshold for moving leaseholders is too large. Racheting up the aggressiveness and lowering the thresholds helps improve repeated run performance and lower the CoV. Adding these settings to the "settings" run to see if it helps stabilize things there. Epic: none Release note: none Co-authored-by: Adam Storm <[email protected]>
2 parents 5128b47 + 7c7aa20 commit 70acc70

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/cmd/roachtest/tests/sysbench.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,8 @@ func registerSysbench(r registry.Registry) {
380380
`set cluster setting sql.metrics.statement_details.enabled = false`,
381381
`set cluster setting kv.split_queue.enabled = false`,
382382
`set cluster setting kv.transaction.write_buffering.enabled = true`,
383+
`set cluster setting kv.allocator.load_based_rebalancing_interval = '10s'`,
384+
`set cluster setting kv.allocator.store_cpu_rebalance_threshold = 0.01`,
383385
},
384386
useDRPC: true,
385387
}

0 commit comments

Comments
 (0)