Merge #154487 #154627

154487: roachprod/opentelemetry: add missing metrics for changefeed stage hists r=log-head,asg0451 a=andyyang890

This patch adds the histogram time series for the various changefeed
stage latency metrics, which appear to have been missing.

Epic: None

Release note: None

154627: sql/inspect: remove obsolete TODO r=spilchen a=spilchen

We have no plans to add a replanner to INSPECT for topology changes. See #149460 for rationale. Removing the TODO that was previously added for it.

Closes #149460

Epic: CRDB-30356
Release note: none

Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Matt Spilchen <[email protected]>

Author: 3 people

pkg/roachprod/opentelemetry/cockroachdb_metrics.go

@@ -418,13 +418,37 @@ var cockroachdbMetrics = map[string]string{
 	"changefeed_sink_io_inflight":                                         "changefeed.sink_io_inflight",
 	"changefeed_size_based_flushes":                                       "changefeed.size_based_flushes",
 	"changefeed_stage_checkpoint_job_progress_latency":                    "changefeed.stage.checkpoint_job_progress.latency",
+	"changefeed_stage_checkpoint_job_progress_latency_bucket":             "changefeed.stage.checkpoint_job_progress.latency.bucket",
+	"changefeed_stage_checkpoint_job_progress_latency_count":              "changefeed.stage.checkpoint_job_progress.latency.count",
+	"changefeed_stage_checkpoint_job_progress_latency_sum":                "changefeed.stage.checkpoint_job_progress.latency.sum",
 	"changefeed_stage_downstream_client_send_latency":                     "changefeed.stage.downstream_client_send.latency",
+	"changefeed_stage_downstream_client_send_latency_bucket":              "changefeed.stage.downstream_client_send.latency.bucket",
+	"changefeed_stage_downstream_client_send_latency_count":               "changefeed.stage.downstream_client_send.latency.count",
+	"changefeed_stage_downstream_client_send_latency_sum":                 "changefeed.stage.downstream_client_send.latency.sum",
 	"changefeed_stage_emit_row_latency":                                   "changefeed.stage.emit_row.latency",
+	"changefeed_stage_emit_row_latency_bucket":                            "changefeed.stage.emit_row.latency.bucket",
+	"changefeed_stage_emit_row_latency_count":                             "changefeed.stage.emit_row.latency.count",
+	"changefeed_stage_emit_row_latency_sum":                               "changefeed.stage.emit_row.latency.sum",
 	"changefeed_stage_encode_latency":                                     "changefeed.stage.encode.latency",
+	"changefeed_stage_encode_latency_bucket":                              "changefeed.stage.encode.latency.bucket",
+	"changefeed_stage_encode_latency_count":                               "changefeed.stage.encode.latency.count",
+	"changefeed_stage_encode_latency_sum":                                 "changefeed.stage.encode.latency.sum",
 	"changefeed_stage_kv_feed_buffer_latency":                             "changefeed.stage.kv_feed_buffer.latency",
+	"changefeed_stage_kv_feed_buffer_latency_bucket":                      "changefeed.stage.kv_feed_buffer.latency.bucket",
+	"changefeed_stage_kv_feed_buffer_latency_count":                       "changefeed.stage.kv_feed_buffer.latency.count",
+	"changefeed_stage_kv_feed_buffer_latency_sum":                         "changefeed.stage.kv_feed_buffer.latency.sum",
 	"changefeed_stage_kv_feed_wait_for_table_event_latency":               "changefeed.stage.kv_feed_wait_for_table_event.latency",
+	"changefeed_stage_kv_feed_wait_for_table_event_latency_bucket":        "changefeed.stage.kv_feed_wait_for_table_event.latency.bucket",
+	"changefeed_stage_kv_feed_wait_for_table_event_latency_count":         "changefeed.stage.kv_feed_wait_for_table_event.latency.count",
+	"changefeed_stage_kv_feed_wait_for_table_event_latency_sum":           "changefeed.stage.kv_feed_wait_for_table_event.latency.sum",
 	"changefeed_stage_rangefeed_buffer_checkpoint_latency":                "changefeed.stage.rangefeed_buffer_checkpoint.latency",
+	"changefeed_stage_rangefeed_buffer_checkpoint_latency_bucket":         "changefeed.stage.rangefeed_buffer_checkpoint.latency.bucket",
+	"changefeed_stage_rangefeed_buffer_checkpoint_latency_count":          "changefeed.stage.rangefeed_buffer_checkpoint.latency.count",
+	"changefeed_stage_rangefeed_buffer_checkpoint_latency_sum":            "changefeed.stage.rangefeed_buffer_checkpoint.latency.sum",
 	"changefeed_stage_rangefeed_buffer_value_latency":                     "changefeed.stage.rangefeed_buffer_value.latency",
+	"changefeed_stage_rangefeed_buffer_value_latency_bucket":              "changefeed.stage.rangefeed_buffer_value.latency.bucket",
+	"changefeed_stage_rangefeed_buffer_value_latency_count":               "changefeed.stage.rangefeed_buffer_value.latency.count",
+	"changefeed_stage_rangefeed_buffer_value_latency_sum":                 "changefeed.stage.rangefeed_buffer_value.latency.sum",
 	"clock_offset_meannanos":                                              "clock.offset.meannanos",
 	"clock_offset_stddevnanos":                                            "clock.offset.stddevnanos",
 	"cloud_conns_opened":                                                  "cloud.conns_opened",

pkg/sql/inspect/inspect_job.go

@@ -60,7 +60,6 @@ func (c *inspectResumer) Resume(ctx context.Context, execCtx interface{}) error
 		return err
 	}
 
-	// TODO(149460): add a goroutine that will replan the job on topology changes
 	plan, planCtx, err := c.planInspectProcessors(ctx, jobExecCtx, pkSpans)
 	if err != nil {
 		return err