Skip to content

Commit 70b2d0f

Browse files
committed
logictest: fix user logictest for provisioning gating validation
The current logictest validates the version gating logic for provisioning but checks for skipif version instead of onlyif version config which was pointed out in the discussion #149405 (comment) and needs to change. Additionally, we need to add a comment for version gating logic as both are failure scenarios owing to "cert-password" currently being a non support provisioning auth method as in the discussion #149405 (comment). fixes #147599 Epic CRDB-21590 Release note: None
1 parent 923e3b0 commit 70b2d0f

File tree

1 file changed

+7
-3
lines changed
  • pkg/sql/logictest/testdata/logic_test

1 file changed

+7
-3
lines changed

pkg/sql/logictest/testdata/logic_test/user

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -227,14 +227,13 @@ user root
227227
statement ok
228228
set cluster setting security.provisioning.ldap.enabled = true;
229229

230-
skipif config local 3node-tenant
230+
onlyif config local-mixed-25.2
231231
statement ok
232232
DROP user testuser
233233

234-
skipif config local 3node-tenant
234+
onlyif config local-mixed-25.2
235235
user testuser nodeidx=0 newsession
236236

237-
skipif config local 3node-tenant
238237
statement error pq: password authentication failed for user testuser
239238
SHOW session_user
240239

@@ -254,6 +253,11 @@ DROP user testuser
254253
skipif config local-mixed-25.2
255254
user testuser nodeidx=0 newsession
256255

256+
# The logictest suite currently doesn't work for external authentication methods
257+
# as the register auth method for "ldap" is invoked outside of the sql package.
258+
# For the purpose of validating the release flags for provisioning, test only
259+
# auth method "cert-password" has been enabled which hasn't been provided with a
260+
# provisioner(handler for provisioning) which is the obtained error here.
257261
skipif config local-mixed-25.2
258262
statement error pq: user identity unknown for identity provider
259263
SHOW session_user

0 commit comments

Comments
 (0)