Merge #148456

148456: importer: remove now-dead code r=yuzefovich a=yuzefovich

**importer: remove no longer used fields from the jobs proto**

`SkipFKs`, `ParseBundleSchema`, and `DefaultIntSize` fields are no
longer used.

**importer: remove all code associated with creating new tables**

We no longer have the code for IMPORT formats that might create new
tables, so we can now assume everywhere that `Table.IsNew` is always
`false`.

**importer: remove schema-publishing related code**

The ability to create new schemas as part of the IMPORT was added in
f36a95a and it was only supported in
PGDUMP. That code is now gone, so we can remove the schema-publishing
related code too.

Epic: None
Release note: None

Co-authored-by: Yahor Yuzefovich <[email protected]>

Author: craig[bot]

pkg/jobs/jobspb/jobs.proto

@@ -683,26 +683,21 @@ message ImportDetails {
     sqlbase.TableDescriptor desc = 1;
     string name = 18;
     int64 seq_val = 19;
-    bool is_new = 20;
     bool was_empty = 22;
     repeated string target_cols = 21;
-    reserved 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17;
-  }
-  message Schema {
-    sqlbase.SchemaDescriptor desc = 1;
+    reserved 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 20;
   }
   message Type {
     sqlbase.TypeDescriptor desc = 1;
   }
+  // TODO(yuzefovich): we now can only support importing into a single table via
+  // a single IMPORT job, so we could change this field.
   repeated Table tables = 1 [(gogoproto.nullable) = false];
-  repeated Schema schemas = 23 [(gogoproto.nullable) = false];
   repeated Type types = 26 [(gogoproto.nullable) = false];
 
   repeated string uris = 2 [(gogoproto.customname) = "URIs"];
   roachpb.IOFileFormat format = 3 [(gogoproto.nullable) = false];
 
-  bool skip_fks = 10 [(gogoproto.customname) = "SkipFKs"];
-
   // walltime is the time at which an import job will write KVs.
   int64 walltime = 5;
   uint32 parent_id = 6 [
@@ -711,24 +706,15 @@ message ImportDetails {
   ];
 
   bool prepare_complete = 12;
-  bool schemas_published = 24;
   bool tables_published = 13;
 
-  // TODO(yuzefovich): remove this.
-  bool parse_bundle_schema = 14;
-
-  // DefaultIntSize is the integer type that a "naked" int will be resolved
-  // to during the import. This is set based on the session variable DefaultIntSize
-  // when the import is planned.
-  int32 default_int_size = 25;
-
   // If the database being imported into is a multi-region database, then this
   // field stores the databases' primary region.
   string database_primary_region = 27 [
     (gogoproto.casttype) = "github.com/cockroachdb/cockroach/pkg/sql/catalog/catpb.RegionName"
   ];
 
-  reserved 4, 7, 8, 9, 11, 22;
+  reserved 4, 7, 8, 9, 10, 11, 14, 22, 23, 24, 25;
 
   // next val: 28
 }

pkg/sql/importer/BUILD.bazel

@@ -26,7 +26,6 @@ go_library(
     visibility = ["//visibility:public"],
     deps = [
         "//pkg/cloud",
-        "//pkg/clusterversion",
         "//pkg/col/coldata",
         "//pkg/crosscluster",
         "//pkg/featureflag",
@@ -50,9 +49,7 @@ go_library(
         "//pkg/sql/catalog/dbdesc",
         "//pkg/sql/catalog/descpb",
         "//pkg/sql/catalog/descs",
-        "//pkg/sql/catalog/ingesting",
         "//pkg/sql/catalog/resolver",
-        "//pkg/sql/catalog/rewrite",
         "//pkg/sql/catalog/schemadesc",
         "//pkg/sql/catalog/schemaexpr",
         "//pkg/sql/catalog/tabledesc",
@@ -65,23 +62,19 @@ go_library(
         "//pkg/sql/gcjob",
         "//pkg/sql/isql",
         "//pkg/sql/lexbase",
-        "//pkg/sql/opt/memo",
         "//pkg/sql/pgwire/pgcode",
         "//pkg/sql/pgwire/pgerror",
         "//pkg/sql/physicalplan",
         "//pkg/sql/privilege",
         "//pkg/sql/row",
         "//pkg/sql/rowenc",
         "//pkg/sql/rowexec",
-        "//pkg/sql/sem/catconstants",
         "//pkg/sql/sem/catid",
         "//pkg/sql/sem/eval",
         "//pkg/sql/sem/idxtype",
         "//pkg/sql/sem/tree",
         "//pkg/sql/sessiondata",
-        "//pkg/sql/sqlclustersettings",
         "//pkg/sql/sqltelemetry",
-        "//pkg/sql/stats",
         "//pkg/sql/types",
         "//pkg/util",
         "//pkg/util/bufalloc",