kv: remove server-side support of InitPuts

We removed client-side usage and support of InitPut requests in
46787b3 which merged during 25.1 cycle.
Given that we no longer need to maintain compatibility with 24.3
versions, we can remove server-side support as well.

Release note: None

Author: yuzefovich

docs/generated/metrics/metrics.yaml

@@ -2990,18 +2990,6 @@ layers:
       unit: COUNT
       aggregation: AVG
       derivative: NON_NEGATIVE_DERIVATIVE
-    - name: distsender.rpc.initput.sent
-      exported_name: distsender_rpc_initput_sent
-      description: |-
-        Number of InitPut requests processed.
-
-        This counts the requests in batches handed to DistSender, not the RPCs
-        sent to individual Ranges as a result.
-      y_axis_label: RPCs
-      type: COUNTER
-      unit: COUNT
-      aggregation: AVG
-      derivative: NON_NEGATIVE_DERIVATIVE
     - name: distsender.rpc.isspanempty.sent
       exported_name: distsender_rpc_isspanempty_sent
       description: |-
@@ -15838,14 +15826,6 @@ layers:
       unit: COUNT
       aggregation: AVG
       derivative: NON_NEGATIVE_DERIVATIVE
-    - name: rpc.method.initput.recv
-      exported_name: rpc_method_initput_recv
-      description: Number of InitPut requests processed
-      y_axis_label: RPCs
-      type: COUNTER
-      unit: COUNT
-      aggregation: AVG
-      derivative: NON_NEGATIVE_DERIVATIVE
     - name: rpc.method.isspanempty.recv
       exported_name: rpc_method_isspanempty_recv
       description: Number of IsSpanEmpty requests processed

pkg/kv/batch.go

@@ -225,12 +225,6 @@ func (b *Batch) fillResults(ctx context.Context) {
 				if result.Err == nil {
 					row.Value = &req.Value
 				}
-			case *kvpb.InitPutRequest:
-				row := &result.Rows[k]
-				row.Key = []byte(req.Key)
-				if result.Err == nil {
-					row.Value = &req.Value
-				}
 			case *kvpb.IncrementRequest:
 				row := &result.Rows[k]
 				row.Key = []byte(req.Key)

pkg/kv/kvclient/kvcoord/txn_interceptor_pipeliner_test.go

@@ -218,9 +218,9 @@ func TestTxnPipelinerTrackInFlightWrites(t *testing.T) {
 	cputArgs := kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}}
 	cputArgs.Sequence = 2
 	ba.Add(&cputArgs)
-	initPutArgs := kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyB}}
-	initPutArgs.Sequence = 3
-	ba.Add(&initPutArgs)
+	putArgs = kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyB}}
+	putArgs.Sequence = 3
+	ba.Add(&putArgs)
 	incArgs := kvpb.IncrementRequest{RequestHeader: kvpb.RequestHeader{Key: keyC}}
 	incArgs.Sequence = 4
 	ba.Add(&incArgs)
@@ -235,7 +235,7 @@ func TestTxnPipelinerTrackInFlightWrites(t *testing.T) {
 		require.True(t, ba.AsyncConsensus)
 		require.IsType(t, &kvpb.QueryIntentRequest{}, ba.Requests[0].GetInner())
 		require.IsType(t, &kvpb.ConditionalPutRequest{}, ba.Requests[1].GetInner())
-		require.IsType(t, &kvpb.InitPutRequest{}, ba.Requests[2].GetInner())
+		require.IsType(t, &kvpb.PutRequest{}, ba.Requests[2].GetInner())
 		require.IsType(t, &kvpb.IncrementRequest{}, ba.Requests[3].GetInner())
 		require.IsType(t, &kvpb.DeleteRequest{}, ba.Requests[4].GetInner())
 
@@ -260,7 +260,7 @@ func TestTxnPipelinerTrackInFlightWrites(t *testing.T) {
 	require.NotNil(t, br)
 	require.Len(t, br.Responses, 4) // QueryIntent response stripped
 	require.IsType(t, &kvpb.ConditionalPutResponse{}, br.Responses[0].GetInner())
-	require.IsType(t, &kvpb.InitPutResponse{}, br.Responses[1].GetInner())
+	require.IsType(t, &kvpb.PutResponse{}, br.Responses[1].GetInner())
 	require.IsType(t, &kvpb.IncrementResponse{}, br.Responses[2].GetInner())
 	require.IsType(t, &kvpb.DeleteResponse{}, br.Responses[3].GetInner())
 	require.Nil(t, pErr)

pkg/kv/kvclient/kvcoord/txn_interceptor_seq_num_allocator_test.go

@@ -62,7 +62,7 @@ func TestSequenceNumberAllocation(t *testing.T) {
 	ba.Requests = nil
 	ba.Add(&kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.GetRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
-	ba.Add(&kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
+	ba.Add(&kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.ScanRequest{RequestHeader: kvpb.RequestHeader{Key: keyA, EndKey: keyB}})
 
 	mockSender.MockSend(func(ba *kvpb.BatchRequest) (*kvpb.BatchResponse, *kvpb.Error) {
@@ -153,7 +153,7 @@ func TestSequenceNumberAllocationWithStep(t *testing.T) {
 			ba.Requests = nil
 			ba.Add(&kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 			ba.Add(&kvpb.GetRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
-			ba.Add(&kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
+			ba.Add(&kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 			ba.Add(&kvpb.ScanRequest{RequestHeader: kvpb.RequestHeader{Key: keyA, EndKey: keyB}})
 
 			mockSender.MockSend(func(ba *kvpb.BatchRequest) (*kvpb.BatchResponse, *kvpb.Error) {
@@ -204,7 +204,7 @@ func TestSequenceNumberAllocationWithStep(t *testing.T) {
 	ba.Header = kvpb.Header{Txn: &txn}
 	ba.Add(&kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.GetRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
-	ba.Add(&kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
+	ba.Add(&kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.ScanRequest{RequestHeader: kvpb.RequestHeader{Key: keyA, EndKey: keyB}})
 
 	mockSender.MockSend(func(ba *kvpb.BatchRequest) (*kvpb.BatchResponse, *kvpb.Error) {
@@ -409,7 +409,7 @@ func TestSequenceNumberAllocationAfterEpochBump(t *testing.T) {
 	ba.Header = kvpb.Header{Txn: &txn}
 	ba.Add(&kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.GetRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
-	ba.Add(&kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
+	ba.Add(&kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 
 	mockSender.MockSend(func(ba *kvpb.BatchRequest) (*kvpb.BatchResponse, *kvpb.Error) {
 		require.Len(t, ba.Requests, 3)
@@ -435,7 +435,7 @@ func TestSequenceNumberAllocationAfterEpochBump(t *testing.T) {
 	ba.Add(&kvpb.GetRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.ConditionalPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 	ba.Add(&kvpb.ScanRequest{RequestHeader: kvpb.RequestHeader{Key: keyA, EndKey: keyB}})
-	ba.Add(&kvpb.InitPutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
+	ba.Add(&kvpb.PutRequest{RequestHeader: kvpb.RequestHeader{Key: keyA}})
 
 	mockSender.MockSend(func(ba *kvpb.BatchRequest) (*kvpb.BatchResponse, *kvpb.Error) {
 		require.Len(t, ba.Requests, 4)

pkg/kv/kvclient/kvcoord/txn_interceptor_write_buffer_test.go

@@ -1977,17 +1977,6 @@ func TestTxnWriteBufferBatchRequestValidation(t *testing.T) {
 				return &kvpb.BatchRequest{Header: header}
 			},
 		},
-		{
-			name: "batch with InitPut",
-			ba: func() *kvpb.BatchRequest {
-				b := &kvpb.BatchRequest{Header: kvpb.Header{Txn: &txn}}
-				b.Add(&kvpb.InitPutRequest{
-					RequestHeader: kvpb.RequestHeader{Key: keyA, Sequence: txn.Sequence},
-					Value:         roachpb.Value{},
-				})
-				return b
-			},
-		},
 		{
 			name: "batch with ReturnRawMVCCValues Scan",
 			ba: func() *kvpb.BatchRequest {

pkg/kv/kvpb/api.go

@@ -333,13 +333,6 @@ func (cpr *ConditionalPutRequest) WriteBytes() int64 {
 	return int64(len(cpr.Key)) + int64(cpr.Value.Size())
 }
 
-var _ SizedWriteRequest = (*InitPutRequest)(nil)
-
-// WriteBytes makes InitPutRequest implement SizedWriteRequest.
-func (pr *InitPutRequest) WriteBytes() int64 {
-	return int64(len(pr.Key)) + int64(pr.Value.Size())
-}
-
 var _ SizedWriteRequest = (*IncrementRequest)(nil)
 
 // WriteBytes makes IncrementRequest implement SizedWriteRequest.
@@ -857,9 +850,6 @@ func (*PutRequest) Method() Method { return Put }
 // Method implements the Request interface.
 func (*ConditionalPutRequest) Method() Method { return ConditionalPut }
 
-// Method implements the Request interface.
-func (*InitPutRequest) Method() Method { return InitPut }
-
 // Method implements the Request interface.
 func (*IncrementRequest) Method() Method { return Increment }
 
@@ -1013,12 +1003,6 @@ func (cpr *ConditionalPutRequest) ShallowCopy() Request {
 	return &shallowCopy
 }
 
-// ShallowCopy implements the Request interface.
-func (pr *InitPutRequest) ShallowCopy() Request {
-	shallowCopy := *pr
-	return &shallowCopy
-}
-
 // ShallowCopy implements the Request interface.
 func (ir *IncrementRequest) ShallowCopy() Request {
 	shallowCopy := *ir
@@ -1307,12 +1291,6 @@ func (cpr *ConditionalPutResponse) ShallowCopy() Response {
 	return &shallowCopy
 }
 
-// ShallowCopy implements the Response interface.
-func (pr *InitPutResponse) ShallowCopy() Response {
-	shallowCopy := *pr
-	return &shallowCopy
-}
-
 // ShallowCopy implements the Response interface.
 func (ir *IncrementResponse) ShallowCopy() Response {
 	shallowCopy := *ir
@@ -1888,17 +1866,6 @@ func (*ConditionalPutRequest) flags() flag {
 		canParallelCommit
 }
 
-// InitPut, like ConditionalPut, effectively reads without writing if it hits a
-// ConditionFailedError, so it must update the timestamp cache in this case.
-// InitPuts do not require a refresh because on write-too-old errors, they
-// return an error immediately instead of continuing a serializable transaction
-// to be retried at end transaction.
-func (*InitPutRequest) flags() flag {
-	return isRead | isWrite | isTxn | isLocking | isIntentWrite |
-		appliesTSCache | updatesTSCache | updatesTSCacheOnErr | canBackpressure |
-		canPipeline | canParallelCommit
-}
-
 // Increment reads the existing value, but always leaves an intent so
 // it does not need to update the timestamp cache. Increments do not
 // require a refresh because on write-too-old errors, they return an

pkg/kv/kvpb/api.proto

@@ -381,30 +381,6 @@ message ConditionalPutResponse {
   ResponseHeader header = 1 [(gogoproto.nullable) = false, (gogoproto.embed) = true];
 }
 
-// An InitPutRequest is the argument to the InitPut() method.
-//
-// - If key doesn't exist, sets value.
-// - If key exists, returns a ConditionFailedError if value != existing value
-//   If failOnTombstones is set to true, tombstone values count as mismatched
-//   values and will cause a ConditionFailedError.
-// TODO(yuzefovich): this can be removed once the compatibility with 24.3 is no
-// longer needed.
-message InitPutRequest {
-  RequestHeader header = 1 [(gogoproto.nullable) = false, (gogoproto.embed) = true];
-  Value value = 2 [(gogoproto.nullable) = false];
-  // NOTE: For internal use only! Set to indicate that the put is
-  // writing to virgin keyspace and no reads are necessary to
-  // rationalize MVCC.
-  bool blind = 3;
-  // If true, tombstones cause ConditionFailedErrors.
-  bool failOnTombstones = 4;
-}
-
-// A InitPutResponse is the return value from the InitPut() method.
-message InitPutResponse {
-  ResponseHeader header = 1 [(gogoproto.nullable) = false, (gogoproto.embed) = true];
-}
-
 // An IncrementRequest is the argument to the Increment() method. It
 // increments the value for key, and returns the new value. If no
 // value exists for a key, incrementing by 0 is not a noop, but will
@@ -2511,7 +2487,6 @@ message RequestUnion {
     ReverseScanRequest reverse_scan = 21;
     ComputeChecksumRequest compute_checksum = 22;
     CheckConsistencyRequest check_consistency = 24;
-    InitPutRequest init_put = 26;
     TransferLeaseRequest transfer_lease = 28;
     LeaseInfoRequest lease_info = 30;
     ExportRequest export = 32;
@@ -2533,7 +2508,7 @@ message RequestUnion {
     LinkExternalSSTableRequest link_external_sstable = 57;
     ExciseRequest excise = 58;
   }
-  reserved 8, 15, 23, 25, 27, 31, 34, 49, 52;
+  reserved 8, 15, 23, 25, 26, 27, 31, 34, 49, 52;
 }
 
 // A ResponseUnion contains exactly one of the responses.
@@ -2568,7 +2543,6 @@ message ResponseUnion {
     ReverseScanResponse reverse_scan = 21;
     ComputeChecksumResponse compute_checksum = 22;
     CheckConsistencyResponse check_consistency = 24;
-    InitPutResponse init_put = 26;
     LeaseInfoResponse lease_info = 30;
     ExportResponse export = 32;
     QueryTxnResponse query_txn = 33;
@@ -2589,7 +2563,7 @@ message ResponseUnion {
     LinkExternalSSTableResponse link_external_sstable = 57;
     ExciseResponse excise = 58;
   }
-  reserved 8, 15, 23, 25, 27, 28, 31, 34, 49, 52;
+  reserved 8, 15, 23, 25, 26, 27, 28, 31, 34, 49, 52;
 }
 
 // A Header is attached to a BatchRequest, encapsulating routing and auxiliary