Skip to content

Commit 729bfdc

Browse files
craig[bot]miraradeva
andcommitted
Merge #152587
152587: kvserver: deflake TestRaftForceCampaignPreVoteCheckQuorum r=pav-kv a=miraradeva The test seems to fail if `ForceCampaign` is called while there are still pending config changes. This commit adds a check for this case. Fixes: #152555 Release note: None Co-authored-by: Mira Radeva <[email protected]>
2 parents 2a8bdf5 + 0ded94a commit 729bfdc

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

pkg/kv/kvserver/client_raft_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6165,6 +6165,9 @@ func TestRaftForceCampaignPreVoteCheckQuorum(t *testing.T) {
61656165
// Create a range, upreplicate it, and replicate a write.
61666166
key := tc.ScratchRange(t)
61676167
desc := tc.AddVotersOrFatal(t, key, tc.Targets(1, 2)...)
6168+
// Wait for the config changes corresponding to adding voters to be finalized.
6169+
// Otherwise, the forced campaign can fail and not retry. See #152555.
6170+
require.NoError(t, tc.WaitForVoters(key, tc.Targets(0, 1, 2)...))
61686171
_, pErr := kv.SendWrapped(ctx, sender, incrementArgs(key, 1))
61696172
require.NoError(t, pErr.GoError())
61706173
tc.WaitForValues(t, key, []int64{1, 1, 1})

0 commit comments

Comments
 (0)