Merge #152981

152981: clisqlclient: ensure allow_unsafe_internals is on during metadata checks r=alyshanjahani-crl a=alyshanjahani-crl

Previously some cli commands (ex/ `cockroach sql`) would error if the `allow_unsafe_internals` session variable was set to false/off (the `allow_unsafe_internals` session var is globally defaulted to false in 26.1)

This is because constructing a `clisqlclient.sqlConn` involves performing metadata checks that access internal/system tables.

This commit ensures `allow_unsafe_internals` is true/on while doing these checks.

Fixes: #152754
Relase note: None

Co-authored-by: Alyshan Jahani <[email protected]>

Author: craig[bot]

pkg/cli/clisqlclient/conn.go

@@ -436,6 +436,23 @@ func (c *sqlConn) checkServerMetadata(ctx context.Context) error {
 	defer func(prev bool) { c.alwaysInferResultTypes = prev }(c.alwaysInferResultTypes)
 	c.alwaysInferResultTypes = false
 
+	// Metadata checks require allow_unsafe_internals to be on.
+	allowUnsafeInternals, err := c.getSessionVariable(ctx, "allow_unsafe_internals")
+	if err != nil {
+		fmt.Fprintf(c.errw, "warning: unable to retrieve allow_unsafe_internals setting: %v\n", err)
+	} else if allowUnsafeInternals == "off" {
+		// Temporarily turn on allow_unsafe_internals.
+		if err := c.Exec(ctx, "SET allow_unsafe_internals = on"); err != nil {
+			fmt.Fprintf(c.errw, "warning: unable to set allow_unsafe_internals to true: %v\n", err)
+		} else {
+			defer func() {
+				if resetErr := c.Exec(ctx, "SET allow_unsafe_internals = off"); resetErr != nil {
+					fmt.Fprintf(c.errw, "warning: unable to reset allow_unsafe_internals to false: %v\n", resetErr)
+				}
+			}()
+		}
+	}
+
 	_, newServerVersion, newClusterID, err := c.GetServerMetadata(ctx)
 	if c.conn.IsClosed() {
 		return MarkWithConnectionClosed(err)
@@ -546,6 +563,15 @@ func (c *sqlConn) GetServerValue(
 	return dbVals[0], true
 }
 
+// getSessionVariable retrieves the value of a session variable.
+func (c *sqlConn) getSessionVariable(ctx context.Context, varName string) (string, error) {
+	val, ok := c.GetServerValue(ctx, varName, fmt.Sprintf("SHOW %s", varName))
+	if !ok {
+		return "", errors.Newf("unable to retrieve session variable %s", varName)
+	}
+	return toString(val), nil
+}
+
 func (c *sqlConn) GetLastQueryStatistics(ctx context.Context) (results QueryStats, resErr error) {
 	if !c.connCtx.EnableServerExecutionTimings || c.lastQueryStatsMode == modeDisabled {
 		return results, nil