Skip to content

Commit 7c76c3c

Browse files
roachtest/tpce: openmetrics bytes emitting wrong new line character
This commit addresses an issue in the TPC-E roachtest where the OpenMetrics bytes were emitting incorrect newline characters. Epic: none Release note: None
1 parent 75f4731 commit 7c76c3c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/cmd/roachtest/tests/tpce.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ func GetTpceOpenmetricsBytes(
400400
buffer.WriteString("# HELP tpce_latency Latency metrics for TPC-E transactions\n")
401401

402402
latencyString := func(quantile, latency string) string {
403-
return fmt.Sprintf(`tpce_latency{%s,unit="ms",is_higher_better="false",quantile="%s"} %s %d\n`, labelString, quantile, latency, now)
403+
return fmt.Sprintf("tpce_latency{%s,unit=\"ms\",is_higher_better=\"false\",quantile=\"%s\"} %s %d\n", labelString, quantile, latency, now)
404404
}
405405

406406
buffer.WriteString(latencyString("0.5", metrics.P50Latency))
@@ -411,7 +411,7 @@ func GetTpceOpenmetricsBytes(
411411
buffer.WriteString(fmt.Sprintf("tpce_latency_sum{%s} %d %d\n", labelString, 0, now))
412412
buffer.WriteString(fmt.Sprintf("tpce_latency_count{%s} %s %d\n", labelString, countOfLatencies, now))
413413
buffer.WriteString("# TYPE tpce_avg_latency gauge\n")
414-
buffer.WriteString(fmt.Sprintf(`tpce_avg_latency{%s,unit="ms",is_higher_better="false"} %s %d\n`, labelString, metrics.AvgLatency, now))
414+
buffer.WriteString(fmt.Sprintf("tpce_avg_latency{%s,unit=\"ms\",is_higher_better=\"false\"} %s %d\n", labelString, metrics.AvgLatency, now))
415415
buffer.WriteString("# EOF")
416416

417417
metricsBytes := buffer.Bytes()

0 commit comments

Comments
 (0)