tree: remove DOidWrapper support for DArrays

Long time ago we implemented `int2vector` and `oidvector` types using
DOidWrapper around the arrays. Some time later, but also long time ago
in 3f4d1a0 we removed those usages by
pushing the "custom" Oid directly into DArray datum, which made the code
for supporting DOidWrapper for arrays redundant. This commit removes
that dead code as well as `AsDArray` function in favor of explicit type
cast.

Release note: None

Author: yuzefovich

pkg/ccl/changefeedccl/encoder_test.go

@@ -1284,7 +1284,7 @@ func TestJsonRountrip(t *testing.T) {
 			// In this case, we can just compare strings.
 			if isFloatOrDecimal(test.datum.ResolvedType()) {
 				require.Equal(t, d.String(), j.String())
-			} else if dArr, ok := tree.AsDArray(test.datum); ok && isFloatOrDecimal(dArr.ParamTyp) {
+			} else if dArr, ok := test.datum.(*tree.DArray); ok && isFloatOrDecimal(dArr.ParamTyp) {
 				require.Equal(t, d.String(), j.String())
 			} else {
 				cmp, err := d.Compare(j)

pkg/server/admin.go

@@ -3529,7 +3529,7 @@ func (rs resultScanner) ScanIndex(row tree.Datums, index int, dst interface{}) e
 		*d = &val
 
 	case *[]int64:
-		s, ok := tree.AsDArray(src)
+		s, ok := src.(*tree.DArray)
 		if !ok {
 			return errors.Errorf("source type assertion failed")
 		}
@@ -3542,7 +3542,7 @@ func (rs resultScanner) ScanIndex(row tree.Datums, index int, dst interface{}) e
 		}
 
 	case *[]descpb.ID:
-		s, ok := tree.AsDArray(src)
+		s, ok := src.(*tree.DArray)
 		if !ok {
 			return errors.Errorf("source type assertion failed")
 		}

pkg/sql/sem/builtins/builtins.go

@@ -5734,7 +5734,7 @@ DO NOT USE -- USE 'CREATE VIRTUAL CLUSTER' INSTEAD`,
 				}
 				descIDMightExist := func(id descpb.ID) bool { return true }
 				if args[1] != tree.DNull {
-					descIDs, ok := tree.AsDArray(args[1])
+					descIDs, ok := args[1].(*tree.DArray)
 					if !ok {
 						return nil, errors.Newf("expected array value, got %T", args[1])
 					}
@@ -5753,7 +5753,7 @@ DO NOT USE -- USE 'CREATE VIRTUAL CLUSTER' INSTEAD`,
 				}
 				nonTerminalJobIDMightExist := func(id jobspb.JobID) bool { return true }
 				if args[2] != tree.DNull {
-					jobIDs, ok := tree.AsDArray(args[2])
+					jobIDs, ok := args[2].(*tree.DArray)
 					if !ok {
 						return nil, errors.Newf("expected array value, got %T", args[2])
 					}
@@ -5775,7 +5775,7 @@ DO NOT USE -- USE 'CREATE VIRTUAL CLUSTER' INSTEAD`,
 					return true
 				}
 				if args[3] != tree.DNull {
-					roles, ok := tree.AsDArray(args[3])
+					roles, ok := args[3].(*tree.DArray)
 					if !ok {
 						return nil, errors.Newf("expected array value, got %T", args[3])
 					}
@@ -11410,7 +11410,7 @@ func arrayLength(arr *tree.DArray, dim int64) tree.Datum {
 	if dim == 1 {
 		return tree.NewDInt(tree.DInt(arr.Len()))
 	}
-	a, ok := tree.AsDArray(arr.Array[0])
+	a, ok := arr.Array[0].(*tree.DArray)
 	if !ok {
 		return tree.DNull
 	}
@@ -11426,7 +11426,7 @@ func arrayLower(arr *tree.DArray, dim int64) tree.Datum {
 	if dim == 1 {
 		return intOne
 	}
-	a, ok := tree.AsDArray(arr.Array[0])
+	a, ok := arr.Array[0].(*tree.DArray)
 	if !ok {
 		return tree.DNull
 	}

pkg/sql/sem/eval/comparison.go

@@ -26,7 +26,7 @@ func ComparisonExprWithSubOperator(
 		return tree.DNull, nil
 	} else if tuple, ok := tree.AsDTuple(right); ok {
 		datums = tuple.D
-	} else if array, ok := tree.AsDArray(right); ok {
+	} else if array, ok := right.(*tree.DArray); ok {
 		datums = array.Array
 	} else {
 		return nil, errors.AssertionFailedf("unhandled right expression %s", right)

pkg/sql/sem/tree/datum.go

@@ -5121,24 +5121,10 @@ func NewDArrayFromDatums(paramTyp *types.T, datums Datums) *DArray {
 	return d
 }
 
-// AsDArray attempts to retrieve a *DArray from an Expr, returning a *DArray and
-// a flag signifying whether the assertion was successful. The function should
-// be used instead of direct type assertions wherever a *DArray wrapped by a
-// *DOidWrapper is possible.
-func AsDArray(e Expr) (*DArray, bool) {
-	switch t := e.(type) {
-	case *DArray:
-		return t, true
-	case *DOidWrapper:
-		return AsDArray(t.Wrapped)
-	}
-	return nil, false
-}
-
 // MustBeDArray attempts to retrieve a *DArray from an Expr, panicking if the
 // assertion fails.
 func MustBeDArray(e Expr) *DArray {
-	i, ok := AsDArray(e)
+	i, ok := e.(*DArray)
 	if !ok {
 		panic(errors.AssertionFailedf("expected *DArray, found %T", e))
 	}
@@ -6024,14 +6010,13 @@ func wrapWithOid(d Datum, oid oid.Oid) Datum {
 	case *DInt:
 	case *DString:
 	case *DCollatedString:
-	case *DArray:
 	case dNull, *DOidWrapper:
 		panic(errors.AssertionFailedf("cannot wrap %T with an Oid", v))
 	default:
-		// Currently only *DInt, *DString, *DCollatedString, *DArray are hooked up to work with
-		// *DOidWrapper. To support another base Datum type, replace all type
-		// assertions to that type with calls to functions like AsDInt and
-		// MustBeDInt.
+		// Currently only *DInt, *DString, and *DCollatedString are hooked up to
+		// work with *DOidWrapper. To support another base Datum type, replace
+		// all type assertions to that type with calls to functions like AsDInt
+		// and MustBeDInt.
 		panic(errors.AssertionFailedf("unsupported Datum type passed to wrapWithOid: %T", d))
 	}
 	return &DOidWrapper{

pkg/util/parquet/write_functions.go

@@ -181,7 +181,7 @@ func writeArray(d tree.Datum, w file.ColumnChunkWriter, a *batchAlloc, wFn write
 	if d == tree.DNull {
 		return wFn(tree.DNull, w, a, nilArrayDefLevel, newEntryRepLevel)
 	}
-	di, ok := tree.AsDArray(d)
+	di, ok := d.(*tree.DArray)
 	if !ok {
 		return pgerror.Newf(pgcode.DatatypeMismatch, "expected DArray, found %T", d)
 	}