Merge #146726

146726: sql/schemachanger: support partitions and RBR tables for alter PK r=fqazi a=fqazi

Previously, ALTER PRIMARY KEY in the declarative schema changer did not
support partitioned / RBR tables, which would cause it to fallback. This
meant that ALTER PRIMARY KEY would always use the legacy schema changer
on multi-region environments. To address this, this patch adds
partitioning and RBR support into the declarative ALTER PRIMARY KEY.
This includes logic to generate subzone config for replacement indexes
and generating zone configurations for new primary keys.

Additionally, to help support this change we are going to refactor logic used to generated partitioned zone configurations to work on top of indexSpec and introduce a indexSpecMutator for index column management. This allows us to also simplify and de-duplicate code.

Fixes: #146725
Release note: None


Co-authored-by: Faizan Qazi <[email protected]>

Author: craig[bot]

pkg/ccl/partitionccl/zone_test.go

@@ -1022,10 +1022,12 @@ func TestPrimaryKeyChangeZoneConfigs(t *testing.T) {
 	// dropped copy of i2, new copy of i1, and new copy of i2.
 	// These have ID's 2, 3, 6 and 8 respectively.
 	expectedSpans := []roachpb.Key{
-		table.IndexSpan(codec, 2 /* indexID */).Key,
-		table.IndexSpan(codec, 3 /* indexID */).Key,
-		table.IndexSpan(codec, 6 /* indexID */).Key,
-		table.IndexSpan(codec, 8 /* indexID */).Key,
+		table.IndexSpan(codec, 2 /* indexID */).Key, // index: old_i1
+		table.IndexSpan(codec, 3 /* indexID */).Key, // index: old_i2
+		table.IndexSpan(codec, 4 /* indexID */).Key, // index: i1
+		table.IndexSpan(codec, 5 /* indexID */).Key, // index: i1_tmp
+		table.IndexSpan(codec, 6 /* indexID */).Key, // index: i2
+		table.IndexSpan(codec, 7 /* indexID */).Key, // index: i2_tmp
 	}
 	if len(zone.SubzoneSpans) != len(expectedSpans) {
 		t.Fatalf("expected subzones to have length %d", len(expectedSpans))