Skip to content

Commit 8ac8fbb

Browse files
committed
batcheval: fix BenchmarkRefreshRange
Recent storage change: #152358 made it that a cluster version must be provided if min version file exists. This seems to have caused BenchmarkRefreshRange to fail. This commit specifies the version when calling fs.InitEnv() Fixes: #153529 Release note: None
1 parent e4db2dd commit 8ac8fbb

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pkg/kv/kvserver/batcheval/cmd_refresh_range_bench_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,11 +178,15 @@ type benchOptions struct {
178178
type engineMaker func(testing.TB, string, int64, fs.RWMode) storage.Engine
179179

180180
func setupMVCCPebble(b testing.TB, dir string, lBaseMaxBytes int64, rw fs.RWMode) storage.Engine {
181-
env, err := fs.InitEnv(context.Background(), vfs.Default, dir, fs.EnvConfig{RW: rw}, nil /* statsCollector */)
181+
settings := cluster.MakeTestingClusterSettings()
182+
env, err := fs.InitEnv(context.Background(), vfs.Default, dir, fs.EnvConfig{
183+
RW: rw,
184+
Version: settings.Version,
185+
}, nil /* statsCollector */)
182186
if err != nil {
183187
b.Fatalf("could not initialize fs env at %s: %+v", dir, err)
184188
}
185-
eng, err := storage.Open(context.Background(), env, cluster.MakeTestingClusterSettings(), storage.LBaseMaxBytes(lBaseMaxBytes))
189+
eng, err := storage.Open(context.Background(), env, settings, storage.LBaseMaxBytes(lBaseMaxBytes))
186190
if err != nil {
187191
env.Close()
188192
b.Fatalf("could not create new pebble instance at %s: %+v", dir, err)

0 commit comments

Comments
 (0)