Merge pull request #153699 from spilchen/blathers/backport-release-24.3-153665

release-24.3: workload: detect self-referencing FK for column dependency

Author: github-actions[bot]

pkg/workload/schemachange/error_screening.go

@@ -289,7 +289,8 @@ func (og *operationGenerator) columnIsDependedOn(
 	// so performing unions and joins is easier.
 	//
 	// To check if any foreign key references exist to this table, we use pg_constraint
-	// and check if any columns are dependent.
+	// and check if any columns are dependent. We check both confrelid (table is referenced)
+	// and self-referential foreign keys (where conrelid = confrelid).
 	return og.scanBool(ctx, tx, `SELECT EXISTS(
 		SELECT source.column_id
 			FROM (
@@ -318,6 +319,12 @@ func (og *operationGenerator) columnIsDependedOn(
 			             FROM pg_catalog.pg_constraint
 			            WHERE confrelid = $1::REGCLASS
 			          )
+			   UNION  (
+			           SELECT unnest(conkey) AS column_id
+			             FROM pg_catalog.pg_constraint
+			            WHERE conrelid = $1::REGCLASS
+			              AND confrelid = $1::REGCLASS
+			          )
 			 ) AS cons
 			 INNER JOIN (
 			   SELECT ordinal_position AS column_id