Merge #153369

153369: backup: use ioctx.ReadAll when reading index metadata r=msbutler a=kev-cao

We currently use `io.Reader`'s `Read` to read the index metadata file. However, `Read` behavior w.r.t to returning an EOF after reading the entire file is not consistent --- S3's implementation returns EOF even if bytes are read, whereas GCS's implementation returns EOF only if a read is attempted after reading the file. The correct solution is to use `ioctx.ReadAll` whenever performing reads.

Fixes: #153215

Fixes: #153214 

Fixes: #153213 

Fixes: #153212

Release note: None

Co-authored-by: Kevin Cao <[email protected]>

Author: craig[bot]

pkg/backup/backupdest/backup_index.go

@@ -25,6 +25,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql"
 	"github.com/cockroachdb/cockroach/pkg/util/ctxgroup"
 	"github.com/cockroachdb/cockroach/pkg/util/hlc"
+	"github.com/cockroachdb/cockroach/pkg/util/ioctx"
 	"github.com/cockroachdb/cockroach/pkg/util/metamorphic"
 	"github.com/cockroachdb/cockroach/pkg/util/protoutil"
 	"github.com/cockroachdb/cockroach/pkg/util/tracing"
@@ -239,17 +240,17 @@ func GetBackupTreeIndexMetadata(
 			if err != nil {
 				return err
 			}
-			reader, size, err := store.ReadFile(
+			reader, _, err := store.ReadFile(
 				ctx, path.Join(indexDir, basename), cloud.ReadOptions{},
 			)
 			if err != nil {
 				return errors.Wrapf(err, "reading index file %s", basename)
 			}
 			defer reader.Close(ctx)
 
-			bytes := make([]byte, size)
-			if _, err := reader.Read(ctx, bytes); err != nil {
-				return errors.Wrapf(err, "reading index file %s bytes", basename)
+			bytes, err := ioctx.ReadAll(ctx, reader)
+			if err != nil {
+				return errors.Wrapf(err, "reading index file %s", basename)
 			}
 
 			index := backuppb.BackupIndexMetadata{}