mmaprototype: rename from UpdateStoreStatus to UpdateStoresStatuses

Author: wenyihu6

pkg/kv/kvserver/allocator/mmaprototype/allocator.go

@@ -60,10 +60,10 @@ type Allocator interface {
 	// associated node in the cluster.
 	ProcessStoreLoadMsg(ctx context.Context, msg *StoreLoadMsg)
 
-	// UpdateStoreStatus updates the health and disposition for the stores in storeStatuses according to the statuses in storeStatuses.
-	// Stores not known to the allocator are ignored with logging.
-	// TODO(wenyihu6): if this is too expensive, we should only update status for stores that have changed.
-	UpdateStoreStatus(ctx context.Context, storeStatuses map[roachpb.StoreID]Status)
+	// UpdateStoresStatuses updates the health and disposition for the stores in
+	// storeStatuses. Stores unknown to the allocator are ignored with logging.
+	// to the allocator are ignored with logging.
+	UpdateStoresStatuses(ctx context.Context, storeStatuses map[roachpb.StoreID]Status)
 
 	// Methods related to making changes.
 

pkg/kv/kvserver/allocator/mmaprototype/allocator_state.go

@@ -204,8 +204,8 @@ func (a *allocatorState) ProcessStoreLoadMsg(ctx context.Context, msg *StoreLoad
 	a.cs.processStoreLoadMsg(ctx, msg)
 }
 
-// UpdateStoreStatus implements the Allocator interface.
-func (a *allocatorState) UpdateStoreStatus(
+// UpdateStoresStatus implements the Allocator interface.
+func (a *allocatorState) UpdateStoresStatuses(
 	ctx context.Context, storeStatuses map[roachpb.StoreID]Status,
 ) {
 	a.mu.Lock()

pkg/kv/kvserver/asim/mmaintegration/mma_store_rebalancer.go

@@ -156,7 +156,7 @@ func (msr *MMAStoreRebalancer) Tick(ctx context.Context, tick time.Time, s state
 			// This uses the real production RefreshStoreStatus, which queries
 			// StorePool (backed by StatusTracker via NodeLivenessFn) and
 			// translates to MMA's status model.
-			msr.allocator.UpdateStoreStatus(ctx, msr.as.GetMMAStoreStatuses())
+			msr.allocator.UpdateStoresStatuses(ctx, msr.as.GetMMAStoreStatuses())
 			storeLeaseholderMsg := MakeStoreLeaseholderMsgFromState(s, msr.localStoreID)
 			pendingChanges := msr.allocator.ComputeChanges(ctx, &storeLeaseholderMsg, mmaprototype.ChangeOptions{
 				LocalStoreID: roachpb.StoreID(msr.localStoreID),

pkg/kv/kvserver/mma_store_rebalancer.go

@@ -125,7 +125,7 @@ func (m *mmaStoreRebalancer) start(ctx context.Context, stopper *stop.Stopper) {
 // rebalance may return true if errors happen in the process and fail to apply
 // the changes successfully.
 func (m *mmaStoreRebalancer) rebalance(ctx context.Context, periodicCall bool) bool {
-	m.mma.UpdateStoreStatus(ctx, m.as.GetMMAStoreStatuses())
+	m.mma.UpdateStoresStatuses(ctx, m.as.GetMMAStoreStatuses())
 	knownStoresByMMA := m.mma.KnownStores()
 	storeLeaseholderMsg, numIgnoredRanges := m.store.MakeStoreLeaseholderMsg(ctx, knownStoresByMMA)
 	if numIgnoredRanges > 0 {