jobs: fix off-by-one error in checkStateChangeLog causing slice bounds panic

dt · dt · commit 8c64d5a3f504 · 2025-08-26T14:30:05.000Z
The calculation len(logs)-i+1 was requesting more logs to be marked unread
than actually existed, causing lastReadIdx to go negative and panic on
subsequent GetUnreadLogs calls.

Release note: None

Epic: None
diff --git a/pkg/jobs/jobs_test.go b/pkg/jobs/jobs_test.go
@@ -377,7 +377,7 @@ func (rts *registryTestSuite) checkStateChangeLog(
 				jobEventsLog.PreviousStatus == string(expectedPrevState) &&
 				jobEventsLog.NewStatus == string(expectedNewState) &&
 				strings.Contains(jobEventsLog.Error, expectedError) {
-				rts.statusChangeLogSpy.SetLastNLogsAsUnread(logpb.Channel_OPS, len(logs)-i+1)
+				rts.statusChangeLogSpy.SetLastNLogsAsUnread(logpb.Channel_OPS, len(logs)-i)
 				return nil
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -377,7 +377,7 @@ func (rts *registryTestSuite) checkStateChangeLog(`
`377`	`377`	`jobEventsLog.PreviousStatus == string(expectedPrevState) &&`
`378`	`378`	`jobEventsLog.NewStatus == string(expectedNewState) &&`
`379`	`379`	`strings.Contains(jobEventsLog.Error, expectedError) {`
`380`		`- rts.statusChangeLogSpy.SetLastNLogsAsUnread(logpb.Channel_OPS, len(logs)-i+1)`
	`380`	`+ rts.statusChangeLogSpy.SetLastNLogsAsUnread(logpb.Channel_OPS, len(logs)-i)`
`381`	`381`	`return nil`
`382`	`382`	`}`
`383`	`383`	`}`