util/stop: add tracing case to stopper benchmarks

This is helpful for measuring impact of changes when tracing is
enabled.

Epic: None
Release note: None

Author: dhartunian

pkg/util/stop/stopper_bench_test.go

@@ -10,7 +10,9 @@ import (
 	"sync"
 	"testing"
 
+	"github.com/cockroachdb/cockroach/pkg/testutils"
 	"github.com/cockroachdb/cockroach/pkg/util/leaktest"
+	"github.com/cockroachdb/cockroach/pkg/util/tracing"
 )
 
 func BenchmarkStopper(b *testing.B) {
@@ -19,52 +21,64 @@ func BenchmarkStopper(b *testing.B) {
 	s := NewStopper()
 	defer s.Stop(ctx)
 
-	opts := TaskOpts{
-		TaskName: "testTask",
-	}
+	tracer := tracing.NewTracer()
 
-	b.Run("RunTask", func(b *testing.B) {
-		b.ReportAllocs()
-		var wg sync.WaitGroup // for fairness
-		wg.Add(b.N)
-		for i := 0; i < b.N; i++ {
-			if err := s.RunTask(ctx, opts.TaskName, func(context.Context) { wg.Done() }); err != nil {
-				b.Fatal(err)
-			}
+	testutils.RunTrueAndFalse(b, "tracing", func(b *testing.B, tracingEnabled bool) {
+		ctx := context.Background()
+		opts := TaskOpts{
+			TaskName: "testTask",
 		}
-		wg.Wait() // noop
-	})
-
-	b.Run("AsyncTaskEx", func(b *testing.B) {
-		b.ReportAllocs()
-		var wg sync.WaitGroup
-		for i := 0; i < b.N; i++ {
-			wg.Add(1)
-			if err := s.RunAsyncTaskEx(ctx, opts, func(ctx context.Context) {
-				defer wg.Done()
-			}); err != nil {
-				b.Fatal(err)
-			}
-			wg.Wait()
+		if tracingEnabled {
+			opts.SpanOpt = ChildSpan
+			sp := tracer.StartSpan("test span")
+			defer sp.Finish()
+			ctx = tracing.ContextWithSpan(ctx, sp)
 		}
-	})
 
-	hdlf := func(ctx context.Context, hdl *Handle, wg *sync.WaitGroup) {
-		defer hdl.Activate(ctx).Release(ctx)
-		defer wg.Done()
-	}
+		b.Run("RunTask", func(b *testing.B) {
+			b.ReportAllocs()
+			var wg sync.WaitGroup // for fairness
+			wg.Add(b.N)
+			for i := 0; i < b.N; i++ {
+				if err := s.RunTask(ctx, opts.TaskName, func(context.Context) { wg.Done() }); err != nil {
+					b.Fatal(err)
+				}
+			}
+			wg.Wait() // noop
+		})
 
-	b.Run("Handle", func(b *testing.B) {
-		b.ReportAllocs()
-		var wg sync.WaitGroup
-		for i := 0; i < b.N; i++ {
-			ctx, hdl, err := s.GetHandle(ctx, opts)
-			if err != nil {
-				b.Fatal(err)
+		b.Run("AsyncTaskEx", func(b *testing.B) {
+			b.ReportAllocs()
+			var wg sync.WaitGroup
+			for i := 0; i < b.N; i++ {
+				wg.Add(1)
+				if err := s.RunAsyncTaskEx(ctx, opts, func(ctx context.Context) {
+					defer wg.Done()
+				}); err != nil {
+					b.Fatal(err)
+				}
+				wg.Wait()
 			}
-			wg.Add(1)
-			go hdlf(ctx, hdl, &wg)
-			wg.Wait()
+		})
+
+		hdlf := func(ctx context.Context, hdl *Handle, wg *sync.WaitGroup) {
+			defer hdl.Activate(ctx).Release(ctx)
+			defer wg.Done()
 		}
+
+		b.Run("Handle", func(b *testing.B) {
+			b.ReportAllocs()
+			var wg sync.WaitGroup
+			for i := 0; i < b.N; i++ {
+				ctx, hdl, err := s.GetHandle(ctx, opts)
+				if err != nil {
+					b.Fatal(err)
+				}
+				wg.Add(1)
+				go hdlf(ctx, hdl, &wg)
+				wg.Wait()
+			}
+		})
 	})
+
 }