roachprod: default --insecure to true

As of [1], [2], `roachprod` defaulted to
"secure" mode to keep it in one-to-one
correspondence with `roachtest`. However,
upon further reflection (see an internal thread [3]),
"secure mode" adds an unnecessary friction.

As of this change, `roachprod` now defaults to
"insecure" mode while `roachtest` _continues_ to
default to "secure". Further, `drtprod` also
continues to default to "secure" mode.

[1] #123593
[2] #123826
[3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB

Epic: none
Release note: None

Author: srosenberg

pkg/cmd/drtprod/cli/commands/BUILD.bazel

@@ -11,6 +11,7 @@ go_library(
     deps = [
         "//pkg/build",
         "//pkg/cmd/drtprod/helpers",
+        "//pkg/cmd/roachprod/cli",
         "//pkg/roachprod",
         "//pkg/roachprod/config",
         "//pkg/roachprod/install",

pkg/cmd/drtprod/cli/commands/yamlprocessor.go

@@ -18,6 +18,7 @@ import (
 	"time"
 
 	"github.com/cockroachdb/cockroach/pkg/cmd/drtprod/helpers"
+	"github.com/cockroachdb/cockroach/pkg/cmd/roachprod/cli"
 	"github.com/cockroachdb/cockroach/pkg/roachprod"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/config"
 	"github.com/cockroachdb/cockroach/pkg/roachprod/install"
@@ -64,7 +65,7 @@ You can also specify the rollback commands in case of a step failure.
 `,
 		Args: cobra.ExactArgs(1),
 		// Wraps the command execution with additional error handling
-		Run: helpers.Wrap(func(cmd *cobra.Command, args []string) (retErr error) {
+		Run: cli.Wrap(func(cmd *cobra.Command, args []string) (retErr error) {
 			_, err := exec.LookPath("drtprod")
 			if err != nil {
 				// drtprod is needed in the path to run yaml commands

pkg/cmd/drtprod/cli/handlers.go

@@ -45,6 +45,8 @@ func init() {
 
 // Initialize sets up the environment and initializes the command-line interface.
 func Initialize(ctx context.Context) {
+	// Apply our flag defaults.
+	cli.UpdateFlagDefaults()
 	// Disable command sorting in Cobra (command-line parser).
 	cobra.EnableCommandSorting = false
 

pkg/cmd/drtprod/helpers/BUILD.bazel

@@ -5,8 +5,4 @@ go_library(
     srcs = ["utils.go"],
     importpath = "github.com/cockroachdb/cockroach/pkg/cmd/drtprod/helpers",
     visibility = ["//visibility:public"],
-    deps = [
-        "//pkg/roachprod/errors",
-        "@com_github_spf13_cobra//:cobra",
-    ],
 )

pkg/cmd/drtprod/helpers/utils.go

@@ -9,37 +9,9 @@ import (
 	"bufio"
 	"context"
 	"fmt"
-	"os"
 	"os/exec"
-
-	rperrors "github.com/cockroachdb/cockroach/pkg/roachprod/errors"
-	"github.com/spf13/cobra"
 )
 
-// Wrap provide `cobra.Command` functions with a standard return code handler.
-// Exit codes come from rperrors.Error.ExitCode().
-//
-// If the wrapped error tree of an error does not contain an instance of
-// rperrors.Error, the error will automatically be wrapped with
-// rperrors.Unclassified.
-func Wrap(f func(cmd *cobra.Command, args []string) error) func(cmd *cobra.Command, args []string) {
-	return func(cmd *cobra.Command, args []string) {
-		var err error
-		err = f(cmd, args)
-		if err != nil {
-			drtprodError, ok := rperrors.AsError(err)
-			if !ok {
-				drtprodError = rperrors.Unclassified{Err: err}
-				err = drtprodError
-			}
-
-			cmd.Printf("Error: %+v\n", err)
-
-			os.Exit(drtprodError.ExitCode())
-		}
-	}
-}
-
 // ExecuteCmdWithPrefix runs a shell command with the given arguments and streams the output.
 // it also adds the specified prefixes
 func ExecuteCmdWithPrefix(ctx context.Context, logPrefix string, cmd string, args ...string) error {