Merge #150234

150234: roachtests/allocation_bench: improve logging in runAllocationBench r=tbg a=wenyihu6

Previously, the logs from allocation_bench were difficult to interpret. This
commit improves clarity by making the log messages more descriptive.

Epic: none
Release note: none

Co-authored-by: wenyihu6 <[email protected]>

Author: craig[bot]

pkg/cmd/roachtest/tests/allocation_bench.go

@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"math"
 	"sort"
+	"strings"
 	"time"
 
 	"github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster"
@@ -330,13 +331,18 @@ func runAllocationBench(
 	}
 	samples := make([]*clusterstats.ClusterStatRun, spec.samples)
 
+	t.L().Printf("cpu(%) means: average of (max-min) node cpu utilization across intervals")
+	t.L().Printf("write(%) means: average of (max-min) write disk utilization across intervals")
+	t.L().Printf("cost(gb) means: GBs sent for rebalancing operations between initial and end")
+
 	for i := 0; i < spec.samples; i++ {
 		statCollector, cleanupFunc := setupAllocationBench(ctx, t, c, spec)
 		stats, err := runAllocationBenchSample(ctx, t, c, spec, statCollector)
 		if err != nil {
 			t.L().PrintfCtx(ctx, "unable to collect allocation bench sample %s", err.Error())
 		} else {
 			samples[i] = stats
+			t.L().Printf("sample %d: %v", i+1, stats.Total)
 		}
 		// Completely wipe the cluster after each go. This avoid spurious
 		// results where prior information / statistics could influence the
@@ -544,11 +550,21 @@ func findMinDistanceClusterStatRun(
 		}
 	}
 
-	t.L().Printf("Selected row(%d) %v from samples (normalized) %v", minSample, samples[minSample].Total, resultMatrix)
-	t.L().Printf("Sample range %v", minMaxs)
-	t.L().Printf("Sample stddev %v", stddevs)
-	for _, sample := range samples {
-		t.L().Printf("%v", sample.Total)
+	t.L().Printf("normalized result matrix:")
+	var buf strings.Builder
+	for i := 0; i < n; i++ {
+		fmt.Fprintf(&buf, "\tsample run %v [", i+1)
+		for j := 0; j < len(resultMatrix[i]); j++ {
+			if j > 0 {
+				fmt.Fprintf(&buf, ", ")
+			}
+			fmt.Fprintf(&buf, "%v: %.3f", tags[j], resultMatrix[i][j])
+		}
+		fmt.Fprintf(&buf, "]\n")
 	}
+	t.L().Printf(buf.String())
+	t.L().Printf("selected sample %v (1-indexed) with total %v", minSample+1, samples[minSample].Total)
+	t.L().Printf("max-min differences across samples per tag: %v", minMaxs)
+	t.L().Printf("standard deviations across samples per tag: %v", stddevs)
 	return samples[minSample], stddevs
 }