Merge #151480 #151820 #151829 #151903

151480: changefeedccl: protobuf encoder optimization r=andyyang890 a=elizaMkraule

This change introduces heap allocation optimizations
for the protobuf encoder.

Fixes: [#151412](#151412)

Release note: None

151820: kvcoord: include destination node ID in mux rangefeed recv errors r=log-head,wenyihu6 a=andyyang890

Previously, when mux rangefeed connections encountered gRPC recv errors,
the error messages did not include the destination node ID, making it
difficult to troubleshoot which node was causing connection issues.

This change wraps mux rangefeed recv errors with the destination node ID
information in the `receiveEventsFromNode` function.

Fixes #149926

Release note: None

🤖 Generated with [Claude Code](https://claude.ai/code)

151829: kvclient: de-flake tests due to metamorphic max_buffer_size r=yuzefovich a=yuzefovich

This commit adjusts the relevant tests that can produce a different output if the txnWriteBuffer size is set too low (by ensuring a lower bound on the cluster setting). All affected tests need at most 2KiB which is the value I decided to use everywhere for consistency.

Additionally, in order to improve the test coverage, it reduces the allowed range of metamorphic values to be in 1B-10KiB range.

`buffered_writes_lock_loss` test seemingly deadlocks with 1B buffer size, so a separate issue is filed to investigate that.

Fixes: #150632.
Fixes: #151725.
Touches: #151895.

Release note: None

151903: geomfn: prevent crash with st_snap on empty geometries r=yuzefovich a=yuzefovich

After we've upgraded to GEOS 3.12+, apparently we picked up a regression with the library where it could result in a crash when evaluating `Snap` on an empty geometry. In such a scenario, the input parameter should be returned unchanged, so we simply add a short-circuiting logic.

Fixes: #151103.

Release note: None

Co-authored-by: Eliza Kraule <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>

Author: 4 people

DEPS.bzl

@@ -1730,10 +1730,10 @@ def go_deps():
         ],
         build_file_proto_mode = "default",
         importpath = "github.com/cockroachdb/changefeedpb",
-        sha256 = "94533028aec2a4a56b8c5e6ea0e43513dcc160075765cbc6fbe720a0fcafc6a5",
-        strip_prefix = "github.com/cockroachdb/[email protected]20250807204158-c4f634c8d95c",
+        sha256 = "64915c79d12f6979066a3ea8208c418daa02b89a4421e888fc1b832397fa4a55",
+        strip_prefix = "github.com/cockroachdb/[email protected]20250807205816-647db5c731b8",
         urls = [
-            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/changefeedpb/com_github_cockroachdb_changefeedpb-v0.0.0-20250807204158-c4f634c8d95c.zip",
+            "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/changefeedpb/com_github_cockroachdb_changefeedpb-v0.0.0-20250807205816-647db5c731b8.zip",
         ],
     )
     go_repository(

build/bazelutil/distdir_files.bzl

@@ -344,7 +344,7 @@ DISTDIR_FILES = {
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/apd/com_github_cockroachdb_apd-v1.1.0.zip": "fef7ec2fae220f84bfacb17fbfc1b04a666ab7f6fc04f3ff6d2b1e05c380777d",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/apd/v3/com_github_cockroachdb_apd_v3-v3.2.1.zip": "6ad54bb71a36fba8ca6725a00d916e51815a4c68de54096313ca6fffda6c87c2",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/bubbletea/com_github_cockroachdb_bubbletea-v0.23.1-bracketed-paste2.zip": "d7916a0e7d8d814566e8f8d162c3764aea947296396a0a669564ff3ee53414bc",
-    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/changefeedpb/com_github_cockroachdb_changefeedpb-v0.0.0-20250807204158-c4f634c8d95c.zip": "94533028aec2a4a56b8c5e6ea0e43513dcc160075765cbc6fbe720a0fcafc6a5",
+    "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/changefeedpb/com_github_cockroachdb_changefeedpb-v0.0.0-20250807205816-647db5c731b8.zip": "64915c79d12f6979066a3ea8208c418daa02b89a4421e888fc1b832397fa4a55",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/client_golang/com_github_cockroachdb_client_golang-v0.0.0-20250124161916-2d4b7d300341.zip": "b4fc2d09aab49c3315b442db09b08bbc7f164d5536404443cbb57203d1cd461f",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/cmux/com_github_cockroachdb_cmux-v0.0.0-20250514152509-914d3bf9ec58.zip": "c1cf4cd99a1ad6a00f2ccd4188cbcf004cb0d56895670b2c171061ce564cd791",
     "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/cockroach-go/v2/com_github_cockroachdb_cockroach_go_v2-v2.4.1.zip": "ba646db91152f3121a6812c7b74d12d8c0e126f7b4d3b927618b159692ceb424",

go.mod

@@ -128,7 +128,7 @@ require (
 	github.com/blevesearch/snowballstem v0.9.0
 	github.com/charmbracelet/bubbles v0.15.1-0.20230123181021-a6a12c4a31eb
 	github.com/cockroachdb/apd/v3 v3.2.1
-	github.com/cockroachdb/changefeedpb v0.0.0-20250807204158-c4f634c8d95c
+	github.com/cockroachdb/changefeedpb v0.0.0-20250807205816-647db5c731b8
 	github.com/cockroachdb/cmux v0.0.0-20250514152509-914d3bf9ec58
 	github.com/cockroachdb/cockroach-go/v2 v2.4.1
 	github.com/cockroachdb/crlib v0.0.0-20250718215705-7ff5051265b9

go.sum

@@ -549,8 +549,8 @@ github.com/cockroachdb/apd/v3 v3.2.1 h1:U+8j7t0axsIgvQUqthuNm82HIrYXodOV2iWLWtEa
 github.com/cockroachdb/apd/v3 v3.2.1/go.mod h1:klXJcjp+FffLTHlhIG69tezTDvdP065naDsHzKhYSqc=
 github.com/cockroachdb/bubbletea v0.23.1-bracketed-paste2 h1:OmQDBlTg1DU5OaKjIuEBt4K+40i9RqtxAwK1P/0OVjI=
 github.com/cockroachdb/bubbletea v0.23.1-bracketed-paste2/go.mod h1:JAfGK/3/pPKHTnAS8JIE2u9f61BjWTQY57RbT25aMXU=
-github.com/cockroachdb/changefeedpb v0.0.0-20250807204158-c4f634c8d95c h1:92Sd4x3IQbEiOZQ9vUo+cwWS6m/saC53tofAknPBWBA=
-github.com/cockroachdb/changefeedpb v0.0.0-20250807204158-c4f634c8d95c/go.mod h1:Czh2+FFDUUKdsxZ7aYZSW0W/E0Dx2sQXf1UUkeMkzxw=
+github.com/cockroachdb/changefeedpb v0.0.0-20250807205816-647db5c731b8 h1:HyB05dr0r7f9ex6sPwcQSE1y0gIBtDbYWqUPwcXDl30=
+github.com/cockroachdb/changefeedpb v0.0.0-20250807205816-647db5c731b8/go.mod h1:Czh2+FFDUUKdsxZ7aYZSW0W/E0Dx2sQXf1UUkeMkzxw=
 github.com/cockroachdb/client_golang v0.0.0-20250124161916-2d4b7d300341 h1:VQDZhIT4rPz6OhMeiD/2kXfE2PLHJzX2QUd1wsGdjxM=
 github.com/cockroachdb/client_golang v0.0.0-20250124161916-2d4b7d300341/go.mod h1:Zsulrv/L9oM40tJ7T815tM89lFEugiJ9HzIqaAx4LKc=
 github.com/cockroachdb/cmux v0.0.0-20250514152509-914d3bf9ec58 h1:DQM99rWou5NZoKKKgSFUtO10FmeK8jbetLIdaH2LHE8=