Skip to content

Commit 9309b20

Browse files
committed
roachtest: increase kv.closed_timestamp.target_duration for copyfrom
Per PR #117091, the roachtest copyfrom test frequently runs in an overloaded environment, causing transactions to time out. That PR attempted to add a retry loop around the transaction, but the test is failed by a log watcher anyway. Consulting the CRDB documentation on "Transaction Retry Error Reference" reveals a suggested course of action of increasing kv.closed_timestamp.target_duration, with some caveats regarding AS OF SYSTEM TIME and changefeeds that we don't care about for the purposes of this test. The most recent test failure indicates a 40s overage, so we set the target_duration to 60s (up from a default of 3s) and hope for the best. Fixes: #133797 Release note: None
1 parent c724a42 commit 9309b20

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/cmd/roachtest/tests/copyfrom.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,9 @@ func runCopyFromCRDB(ctx context.Context, t test.Test, c cluster.Cluster, sf int
148148
// Enable the verbose logging on relevant files to have better understanding
149149
// in case the test fails.
150150
startOpts.RoachprodOpts.ExtraArgs = append(startOpts.RoachprodOpts.ExtraArgs, "--vmodule=copy_from=2,insert=2")
151-
c.Start(ctx, t.L(), startOpts, install.MakeClusterSettings(), c.All())
151+
// roachtest frequently runs on overloaded instances and can timeout as a result
152+
clusterSettings := install.MakeClusterSettings(install.ClusterSettingsOption{"kv.closed_timestamp.target_duration": "60s"})
153+
c.Start(ctx, t.L(), startOpts, clusterSettings, c.All())
152154
initTest(ctx, t, c, sf)
153155
db, err := c.ConnE(ctx, t.L(), 1)
154156
require.NoError(t, err)

0 commit comments

Comments
 (0)