logictest: add new config local-leased-descriptors

Previously, we didn't have much coverage for testing leased descriptors
with pg_catalog / crdb_internal functions. This patch adds a new config
to enable this feature on a subset of pg_catalog / crdb_internal tests.

Release note: None

Author: fqazi

pkg/BUILD.bazel

@@ -521,6 +521,7 @@ ALL_TESTS = [
     "//pkg/sql/logictest/tests/fakedist-disk:fakedist-disk_test",
     "//pkg/sql/logictest/tests/fakedist-vec-off:fakedist-vec-off_test",
     "//pkg/sql/logictest/tests/fakedist:fakedist_test",
+    "//pkg/sql/logictest/tests/local-leased-descriptors:local-leased-descriptors_test",
     "//pkg/sql/logictest/tests/local-legacy-schema-changer:local-legacy-schema-changer_test",
     "//pkg/sql/logictest/tests/local-mixed-25.2:local-mixed-25_2_test",
     "//pkg/sql/logictest/tests/local-mixed-25.3:local-mixed-25_3_test",
@@ -2091,6 +2092,7 @@ GO_TARGETS = [
     "//pkg/sql/logictest/tests/fakedist-disk:fakedist-disk_test",
     "//pkg/sql/logictest/tests/fakedist-vec-off:fakedist-vec-off_test",
     "//pkg/sql/logictest/tests/fakedist:fakedist_test",
+    "//pkg/sql/logictest/tests/local-leased-descriptors:local-leased-descriptors_test",
     "//pkg/sql/logictest/tests/local-legacy-schema-changer:local-legacy-schema-changer_test",
     "//pkg/sql/logictest/tests/local-mixed-25.2:local-mixed-25_2_test",
     "//pkg/sql/logictest/tests/local-mixed-25.3:local-mixed-25_3_test",

pkg/sql/logictest/logic.go

@@ -1825,6 +1825,18 @@ func (t *logicTest) newCluster(
 				t.Fatal(err)
 			}
 		}
+		if cfg.EnableLeasedDescriptorSupport {
+			if _, err := conn.Exec(
+				"SET CLUSTER SETTING sql.catalog.allow_leased_descriptors.enabled = true",
+			); err != nil {
+				t.Fatal(err)
+			}
+			if _, err := conn.Exec(
+				"SET CLUSTER SETTING sql.catalog.descriptor_lease.use_locked_timestamps.enabled = true",
+			); err != nil {
+				t.Fatal(err)
+			}
+		}
 		// We disable the automatic stats collection in order to have
 		// deterministic tests.
 		//

pkg/sql/logictest/logictestbase/logictestbase.go

@@ -95,6 +95,9 @@ type TestClusterConfig struct {
 	DisableSchemaLockedByDefault bool
 	// PrepareQueries executes queries and statements with Prepare and Execute.
 	PrepareQueries bool
+	// EnableLeasedDescriptorSupport enables leased descriptors for pg_catalog /
+	// crdb_internal and locked leasing behavior.
+	EnableLeasedDescriptorSupport bool
 }
 
 // TenantMode is the type of the UseSecondaryTenant field in TestClusterConfig.
@@ -546,6 +549,19 @@ var LogicTestConfigs = []TestClusterConfig{
 		BootstrapVersion:         clusterversion.V25_3,
 		NumNodes:                 3,
 	},
+	{
+		Name:                "local-leased-descriptors",
+		NumNodes:            1,
+		OverrideDistSQLMode: "off",
+		// local is the configuration where we run all tests which have bad
+		// interactions with the default test tenant.
+		//
+		// TODO(#76378): We should review this choice. Why can't we use "Random"
+		// here? If there are specific tests that are incompatible, we can
+		// flag them to run only in a separate config.
+		UseSecondaryTenant:            Never,
+		EnableLeasedDescriptorSupport: true,
+	},
 }
 
 // ConfigIdx is an index in the above slice.

pkg/sql/logictest/testdata/logic_test/comment_on

@@ -1,4 +1,4 @@
-# LogicTest: !local-prepared
+# LogicTest: default-configs !local-prepared local-leased-descriptors 3node-tenant
 
 statement ok
 CREATE DATABASE db

pkg/sql/logictest/testdata/logic_test/pg_catalog

@@ -1,4 +1,4 @@
-# LogicTest: local
+# LogicTest: local local-leased-descriptors
 
 # Set the distsql_workmem to the default production value because of a problem
 # with losing 'name' attribute when spilling to disk (#78547).

pkg/sql/logictest/testdata/logic_test/privileges_comments

@@ -1,3 +1,5 @@
+# LogicTest: default-configs 3node-tenant local-leased-descriptors
+
 subtest regression45707
 
 user root

pkg/sql/logictest/testdata/logic_test/show_create

@@ -1,3 +1,5 @@
+# LogicTest: default-configs 3node-tenant local-leased-descriptors
+
 statement ok
 SET experimental_enable_unique_without_index_constraints = true
 

pkg/sql/logictest/testdata/logic_test/show_create_all_routines

@@ -1,3 +1,5 @@
+# LogicTest: default-configs 3node-tenant local-leased-descriptors
+
 statement ok
 CREATE DATABASE d
 

pkg/sql/logictest/testdata/logic_test/show_create_all_schemas

@@ -1,3 +1,5 @@
+# LogicTest: default-configs 3node-tenant local-leased-descriptors
+
 statement ok
 CREATE DATABASE d
 

pkg/sql/logictest/testdata/logic_test/show_create_all_tables

@@ -1,3 +1,5 @@
+# LogicTest: default-configs 3node-tenant local-leased-descriptors
+
 statement ok
 CREATE DATABASE d