Merge #148412

148412: storage: set LastUpdateNanos in ComputeSSTStatsDiff r=stevendanna a=msbutler

ComputeSSTStatsDiff needs to set LastUpdateNanos, which it forgot to do when it was introduced in #147861.

Epic: none

Release note: none

Co-authored-by: Michael Butler <[email protected]>

Author: craig[bot]

pkg/storage/sst.go

@@ -356,6 +356,7 @@ func ComputeSSTStatsDiff(
 		prevSSTKey.Timestamp = sstIterKey.Timestamp
 		sstIter.Next()
 	}
+	ms.LastUpdateNanos = nowNanos
 	return ms, nil
 }
 

pkg/storage/sst_stats_diff_test.go

@@ -186,19 +186,22 @@ func TestMVCCComputeSSTStatsDiff(t *testing.T) {
 				sstEncoded, startUnversioned, endUnversioned := storageutils.MakeSST(t, st, sst)
 				start := storage.MVCCKey{Key: startUnversioned}
 				end := storage.MVCCKey{Key: endUnversioned}
+				updateTime := now + 1
 
 				statsDelta, err := storage.ComputeSSTStatsDiff(
-					ctx, sstEncoded, engine, now, start, end)
+					ctx, sstEncoded, engine, updateTime, start, end)
 				require.NoError(t, err)
 
 				require.NoError(t, fs.WriteFile(engine.Env(), "sst", sstEncoded, fs.UnspecifiedWriteCategory))
 				require.NoError(t, engine.IngestLocalFiles(ctx, []string{"sst"}))
 
-				expStats, err := storage.ComputeStats(ctx, engine, keys.LocalMax, roachpb.KeyMax, now)
+				expStats, err := storage.ComputeStats(ctx, engine, keys.LocalMax, roachpb.KeyMax, updateTime)
 				require.NoError(t, err)
 
 				baseStats.Add(statsDelta)
 
+				require.Equal(t, baseStats.LastUpdateNanos, updateTime)
+
 				t.Logf("sst %s, eng %s", sst, eng)
 				if !baseStats.Equal(expStats) {
 					t.Log("test, expected")