Merge pull request #153595 from jbowens/24.1-diskstall-walfailover-2s

jbowens · web-flow · commit 979a6a5bdbf8 · 2025-09-17T07:21:45.000-04:00
release-24.1: roachtest: relax WAL failover latency requirement
diff --git a/pkg/cmd/roachtest/tests/disk_stall.go b/pkg/cmd/roachtest/tests/disk_stall.go
@@ -163,7 +163,7 @@ func runDiskStalledWALFailover(
 		})
 
 	for _, dp := range data.Results[0].Datapoints {
-		if dur := time.Duration(dp.Value); dur > time.Second {
+		if dur := time.Duration(dp.Value); dur > 2*time.Second {
 			t.Errorf("unexpectedly high p99.99 latency %s at %s", dur, timeutil.Unix(0, dp.TimestampNanos).Format(time.RFC3339))
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ func runDiskStalledWALFailover(`
`163`	`163`	`})`
`164`	`164`
`165`	`165`	`for _, dp := range data.Results[0].Datapoints {`
`166`		`- if dur := time.Duration(dp.Value); dur > time.Second {`
	`166`	`+ if dur := time.Duration(dp.Value); dur > 2*time.Second {`
`167`	`167`	`t.Errorf("unexpectedly high p99.99 latency %s at %s", dur, timeutil.Unix(0, dp.TimestampNanos).Format(time.RFC3339))`
`168`	`168`	`}`
`169`	`169`	`}`