Skip to content

Commit 98a04d3

Browse files
craig[bot]rafiss
andcommitted
Merge #150415
150415: roachtest: fix nodejs install helper function r=rafiss a=rafiss The -exec action in find requires a terminating semicolon (`\;`) to indicate the end of the command. Without it, find doesn't know when the command ends, so this instalation check could fail. fixes #150322 follow up from #150191 Release note: None Co-authored-by: Rafi Shamim <[email protected]>
2 parents fcc68f2 + 4a14bc0 commit 98a04d3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

pkg/cmd/roachtest/tests/javascript_helpers.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ func installNode18(
3535
if err := c.RunE(
3636
ctx, option.WithNodes(node), `
3737
sudo npm i -g npm && \
38-
sudo find /usr/local/lib/node_modules/npm -type d -exec chmod 755 {} && \
39-
sudo find /usr/local/lib/node_modules/npm -type f -exec chmod 644 {} && \
40-
sudo find /usr/local/lib/node_modules/npm/bin -type f -exec chmod 755 {}
38+
sudo find /usr/local/lib/node_modules/npm -type d -exec chmod 755 {} \; && \
39+
sudo find /usr/local/lib/node_modules/npm -type f -exec chmod 644 {} \; && \
40+
sudo find /usr/local/lib/node_modules/npm/bin -type f -exec chmod 755 {} \;
4141
`,
4242
); err != nil {
4343

0 commit comments

Comments
 (0)