Skip to content

Commit 98c956c

Browse files
roachtest: Skip flaky endpoint and fix retry logic for db-console/endpoints
This commit skips the rangelog endpoint on the admin server. This failure mode is described in: #148112 (comment) This commit also sets an initial backoff when retrying endpoints. The default of 50ms resulted in the 10 retries being exhausted too quickly. In mixed version tests nodes are taken down and brought up, and so we observed many 404 failures due to this. Fixes: #148187 Release note: None
1 parent 71bcba2 commit 98c956c

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pkg/cmd/roachtest/tests/db-console/admin_endpoints.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
{
7979
"url": "/_admin/v1/rangelog",
8080
"method": "GET"
81+
"skip": "https://github.com/cockroachdb/cockroach/pull/148112#issuecomment-2960322577"
8182
},
8283
{
8384
"url": "/_admin/v1/rangelog/{range_id}",

pkg/cmd/roachtest/tests/db_console_endpoints.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ func testEndpoint(
248248
return nil
249249
}
250250

251-
return withRetries(ctx, retry.Options{MaxRetries: 10}, f)
251+
return withRetries(ctx, retry.Options{InitialBackoff: time.Second, MaxRetries: 10}, f)
252252
}
253253

254254
// withRetries runs the given function f with the provided retry options.

0 commit comments

Comments
 (0)