schemachanger: implement RENAME COLUMN in the declarative schema changer

Release note: None

Author: annrpom

pkg/ccl/schemachangerccl/sctestbackupccl/backup_base_generated_test.go

@@ -804,7 +804,7 @@ func (n *alterTableNode) startExec(params runParams) error {
 				tableDesc.GetRowLevelTTL().HasDurationExpr() {
 				return pgerror.Newf(
 					pgcode.InvalidTableDefinition,
-					`cannot rename column %s while ttl_expire_after is set`,
+					`cannot alter column %s while ttl_expire_after is set`,
 					columnName,
 				)
 			}

pkg/sql/alter_table.go

@@ -199,3 +199,34 @@ query II
 SELECT j, k FROM foo;
 ----
 1  2
+
+# Test that mixed-case column names are handled correctly for rename operations.
+statement ok
+CREATE TABLE mixed_case_table (
+    "CamelCase" INT PRIMARY KEY,
+    "snake_case" TEXT,
+    "UPPERCASE" DECIMAL
+);
+
+statement error column "UPPERCASE" of relation "mixed_case_table" already exists
+ALTER TABLE mixed_case_table RENAME COLUMN "CamelCase" TO "UPPERCASE";
+
+statement ok
+ALTER TABLE mixed_case_table RENAME COLUMN "CamelCase" TO "CamelCase";
+
+statement ok
+ALTER TABLE mixed_case_table RENAME COLUMN "CamelCase" TO "NewCamelCase";
+
+statement ok
+ALTER TABLE mixed_case_table RENAME COLUMN "snake_case" TO "SnakeCase";
+
+statement ok
+ALTER TABLE mixed_case_table RENAME COLUMN "UPPERCASE" TO "decimal_value";
+
+query T colnames
+SELECT column_name FROM [SHOW COLUMNS FROM mixed_case_table] ORDER BY column_name;
+----
+column_name
+NewCamelCase
+SnakeCase
+decimal_value

pkg/sql/logictest/testdata/logic_test/rename_column

@@ -227,7 +227,7 @@ subtest alter_column_crdb_internal_expiration_rename
 statement ok
 CREATE TABLE alter_column_crdb_internal_expiration_rename() WITH (ttl_expire_after='10 minutes')
 
-statement error cannot rename column crdb_internal_expiration while ttl_expire_after is set
+statement error cannot alter column crdb_internal_expiration while ttl_expire_after is set
 ALTER TABLE alter_column_crdb_internal_expiration_rename RENAME COLUMN crdb_internal_expiration TO crdb_internal_expiration_2
 
 subtest end

pkg/sql/logictest/testdata/logic_test/row_level_ttl

@@ -253,7 +253,7 @@ ALTER TABLE tab3 SET (schema_locked=true)
 
 subtest alter_commands
 
-statement error pq: cannot rename system column "crdb_internal_mvcc_timestamp"
+statement error pq: cannot alter system column "crdb_internal_mvcc_timestamp"
 ALTER TABLE tab3 RENAME crdb_internal_mvcc_timestamp TO blah;
 
 statement error pq: cannot alter system column "crdb_internal_mvcc_timestamp"

pkg/sql/logictest/testdata/logic_test/system_columns

@@ -105,7 +105,7 @@ func (p *planner) findColumnToRename(
 	if col.IsSystemColumn() {
 		return nil, pgerror.Newf(
 			pgcode.FeatureNotSupported,
-			"cannot rename system column %q", col.ColName(),
+			"cannot alter system column %q", col.ColName(),
 		)
 	}
 	for _, tableRef := range tableDesc.DependedOnBy {

pkg/sql/rename_column.go

@@ -15,6 +15,7 @@ go_library(
         "alter_table_alter_primary_key.go",
         "alter_table_drop_column.go",
         "alter_table_drop_constraint.go",
+        "alter_table_rename_column.go",
         "alter_table_set_rls_mode.go",
         "alter_table_validate_constraint.go",
         "comment_on.go",

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/BUILD.bazel

@@ -38,10 +38,11 @@ var supportedAlterTableStatements = map[reflect.Type]supportedAlterTableCommand{
 	reflect.TypeOf((*tree.AlterTableDropConstraint)(nil)):     {fn: alterTableDropConstraint, on: true, checks: nil},
 	reflect.TypeOf((*tree.AlterTableValidateConstraint)(nil)): {fn: alterTableValidateConstraint, on: true, checks: nil},
 	reflect.TypeOf((*tree.AlterTableSetDefault)(nil)):         {fn: alterTableSetDefault, on: true, checks: nil},
-	reflect.TypeOf((*tree.AlterTableSetOnUpdate)(nil)):        {fn: alterTableSetOnUpdate, on: true, checks: isV254Active},
 	reflect.TypeOf((*tree.AlterTableAlterColumnType)(nil)):    {fn: alterTableAlterColumnType, on: true, checks: nil},
 	reflect.TypeOf((*tree.AlterTableSetRLSMode)(nil)):         {fn: alterTableSetRLSMode, on: true, checks: isV252Active},
 	reflect.TypeOf((*tree.AlterTableDropNotNull)(nil)):        {fn: alterTableDropNotNull, on: true, checks: isV253Active},
+	reflect.TypeOf((*tree.AlterTableSetOnUpdate)(nil)):        {fn: alterTableSetOnUpdate, on: true, checks: isV254Active},
+	reflect.TypeOf((*tree.AlterTableRenameColumn)(nil)):       {fn: alterTableRenameColumn, on: true, checks: isV254Active},
 }
 
 func init() {

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table.go

@@ -93,7 +93,7 @@ func alterTableAlterColumnType(
 		case *scpb.PolicyUsingExpr, *scpb.PolicyWithCheckExpr:
 			panic(sqlerrors.NewAlterDependsOnPolicyExprError(op, objType, t.Column.String()))
 		}
-	})
+	}, false /* allowPartialIdxPredicateRef */)
 
 	var err error
 	newColType.Type, err = schemachange.ValidateAlterColumnTypeChecks(
@@ -309,7 +309,7 @@ func handleGeneralColumnConversion(
 		case *scpb.SecondaryIndex:
 			panic(sqlerrors.NewAlterColumnTypeColInIndexNotSupportedErr())
 		}
-	})
+	}, false /* allowPartialIdxPredicateRef */)
 
 	// This code path should never be reached for virtual columns, as their values
 	// are always computed dynamically on access and are never stored on disk.
@@ -505,7 +505,7 @@ func maybeWriteNoticeForFKColTypeMismatch(b BuildCtx, col *scpb.Column, colType
 		case *scpb.ForeignKeyConstraintUnvalidated:
 			writeNoticeHelper(e.ColumnIDs, e.ReferencedColumnIDs, e.ReferencedTableID)
 		}
-	})
+	}, false /* allowPartialIdxPredicateRef */)
 }
 
 func getComputeExpressionForBackfill(

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/alter_table_alter_column_type.go

@@ -1149,7 +1149,7 @@ func checkIfColumnCanBeDropped(b BuildCtx, columnToDrop *scpb.Column) bool {
 				canBeDropped = false
 			}
 		}
-	})
+	}, false /* allowPartialIdxPredicateRef */)
 	return canBeDropped
 }