microbench-ci: fix status reporting

Previously, in some cases we did not set `NoChange` if the benchmark was
unchanged. The regression marker file should also only be written to the New
revision.

Author: herkolategan

pkg/cmd/microbench-ci/run.go

@@ -103,6 +103,7 @@ func (b *Benchmark) run() error {
 		// iterations. Retries are run once a benchmark has regressed or improved,
 		// on the first try, to ensure that the change is not a fluke.
 		if currentStatus == NoChange {
+			status = currentStatus
 			break
 		}
 
@@ -122,12 +123,10 @@ func (b *Benchmark) run() error {
 
 	// Write change marker file if the benchmark changed.
 	if status != NoChange {
-		for _, revision := range []Revision{New, Old} {
-			marker := strings.ToUpper(status.String())
-			err := os.WriteFile(path.Join(suite.artifactsDir(revision), "."+marker), nil, 0644)
-			if err != nil {
-				return err
-			}
+		marker := strings.ToUpper(status.String())
+		err := os.WriteFile(path.Join(suite.artifactsDir(New), "."+marker), nil, 0644)
+		if err != nil {
+			return err
 		}
 	}
 

pkg/cmd/microbench-ci/testdata/regression.txt

@@ -147,7 +147,6 @@ tree
 
 /abcdef123
 /abcdef123/artifacts
-/abcdef123/artifacts/.REGRESSED
 /abcdef123/artifacts/cleaned_Sysbench_SQL_3node_oltp_read_write.log
 /abcdef123/artifacts/cpu_Sysbench_SQL_3node_oltp_read_write_merged.prof
 /abcdef123/artifacts/memory_Sysbench_SQL_3node_oltp_read_write_merged.prof

pkg/cmd/microbench-ci/testdata/summary.txt

@@ -127,7 +127,6 @@ tree
 
 /abcdef123
 /abcdef123/artifacts
-/abcdef123/artifacts/.REGRESSED
 /abcdef123/artifacts/cleaned_Sysbench_SQL_3node_oltp_read_write.log
 /abcdef123/artifacts/cpu_Sysbench_SQL_3node_oltp_read_write_merged.prof
 /abcdef123/artifacts/memory_Sysbench_SQL_3node_oltp_read_write_merged.prof
@@ -136,7 +135,6 @@ tree
 /github-summary.md
 /qwerty456
 /qwerty456/artifacts
-/qwerty456/artifacts/.REGRESSED
 /qwerty456/artifacts/cleaned_Sysbench_SQL_3node_oltp_read_write.log
 /qwerty456/artifacts/cpu_Sysbench_SQL_3node_oltp_read_write_merged.prof
 /qwerty456/artifacts/memory_Sysbench_SQL_3node_oltp_read_write_merged.prof