upgrades: add 25.3 migration for hot range logging job

In #143775, we added a hot range logging job which is meant to run on
multi-tenant clusters. Here we add the requisite migrations, to versions
25.3 and beyond to add the job to clusters.

Fixes: #143527
Epic: CRDB-43150

Release note (general change): For multi-tenant deployments, changes hot
range logging to be a job, run from a single node, rather than a task
run from every node.

Author: angles-n-daemons

docs/generated/settings/settings-for-tenants.txt

@@ -418,4 +418,4 @@ trace.zipkin.collector	string		the address of a Zipkin instance to receive trace
 ui.database_locality_metadata.enabled	boolean	true	if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute	application
 ui.default_timezone	string		the default timezone used to format timestamps in the ui	application
 ui.display_timezone	enumeration	etc/utc	the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the 'ui.default_timezone' setting instead. 'ui.default_timezone' takes precedence over this setting. [etc/utc = 0, america/new_york = 1]	application
-version	version	1000025.2-upgrading-to-1000025.3-step-006	set the active cluster version in the format '<major>.<minor>'	application
+version	version	1000025.2-upgrading-to-1000025.3-step-008	set the active cluster version in the format '<major>.<minor>'	application

docs/generated/settings/settings.html

@@ -376,6 +376,6 @@
 <tr><td><div id="setting-ui-database-locality-metadata-enabled" class="anchored"><code>ui.database_locality_metadata.enabled</code></div></td><td>boolean</td><td><code>true</code></td><td>if enabled shows extended locality data about databases and tables in DB Console which can be expensive to compute</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-ui-default-timezone" class="anchored"><code>ui.default_timezone</code></div></td><td>string</td><td><code></code></td><td>the default timezone used to format timestamps in the ui</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 <tr><td><div id="setting-ui-display-timezone" class="anchored"><code>ui.display_timezone</code></div></td><td>enumeration</td><td><code>etc/utc</code></td><td>the timezone used to format timestamps in the ui. This setting is deprecatedand will be removed in a future version. Use the &#39;ui.default_timezone&#39; setting instead. &#39;ui.default_timezone&#39; takes precedence over this setting. [etc/utc = 0, america/new_york = 1]</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
-<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000025.2-upgrading-to-1000025.3-step-006</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
+<tr><td><div id="setting-version" class="anchored"><code>version</code></div></td><td>version</td><td><code>1000025.2-upgrading-to-1000025.3-step-008</code></td><td>set the active cluster version in the format &#39;&lt;major&gt;.&lt;minor&gt;&#39;</td><td>Serverless/Dedicated/Self-Hosted</td></tr>
 </tbody>
 </table>

pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/BUILD.bazel

@@ -34,6 +34,7 @@ go_test(
         "//pkg/testutils/skip",
         "//pkg/testutils/sqlutils",
         "//pkg/testutils/testcluster",
+        "//pkg/upgrade/upgradebase",
         "//pkg/util/leaktest",
         "//pkg/util/log",
         "//pkg/util/randutil",

pkg/ccl/spanconfigccl/spanconfigsqltranslatorccl/datadriven_test.go

@@ -33,6 +33,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/testutils/skip"
 	"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
 	"github.com/cockroachdb/cockroach/pkg/testutils/testcluster"
+	"github.com/cockroachdb/cockroach/pkg/upgrade/upgradebase"
 	"github.com/cockroachdb/cockroach/pkg/util/leaktest"
 	"github.com/cockroachdb/cockroach/pkg/util/log"
 	"github.com/cockroachdb/cockroach/pkg/util/syncutil"
@@ -120,6 +121,9 @@ func TestDataDriven(t *testing.T) {
 					GCJob:       gcTestingKnobs,
 					SpanConfig:  scKnobs,
 					SQLExecutor: sqlExecutorKnobs,
+					UpgradeManager: &upgradebase.TestingKnobs{
+						SkipHotRangesLoggerJobBootstrap: true,
+					},
 				},
 				StoreSpecs: []base.StoreSpec{
 					{InMemory: true, Attributes: []string{attr}},

pkg/cli/testdata/doctor/test_examine_cluster

@@ -3,5 +3,5 @@ debug doctor examine cluster
 debug doctor examine cluster
 Examining 69 descriptors and 68 namespace entries...
   ParentID 100, ParentSchemaID 101: relation "foo" (105): expected matching namespace entry, found none
-Examining 12 jobs...
+Examining 13 jobs...
 ERROR: validation failed

pkg/cli/testdata/doctor/test_examine_cluster_dropped

@@ -2,5 +2,5 @@ debug doctor examine cluster
 ----
 debug doctor examine cluster
 Examining 68 descriptors and 68 namespace entries...
-Examining 10 jobs...
+Examining 11 jobs...
 No problems found!

pkg/cli/testdata/doctor/test_examine_cluster_jobs

@@ -7,5 +7,5 @@ Examining 68 descriptors and 69 namespace entries...
   ParentID 183, ParentSchemaID 381: relation "foo" (104): expected matching namespace entry, found none
   ParentID 183, ParentSchemaID 381: relation "foo" (104): mutation job 962952277419655169: job 962952277419655169 not found
   ParentID 100, ParentSchemaID 101: namespace entry "foo" (104): mismatched name "foo" in relation descriptor
-Examining 10 jobs...
+Examining 11 jobs...
 ERROR: validation failed

pkg/clusterversion/cockroach_versions.go

@@ -217,6 +217,8 @@ const (
 	V25_3_AddEventLogColumnAndIndex
 
 	V25_3_AddEstimatedLastLoginTime
+
+	V25_3_AddHotRangeLoggerJob
 	// *************************************************
 	// Step (1) Add new versions above this comment.
 	// Do not add new versions to a patch release.
@@ -275,6 +277,8 @@ var versionTable = [numKeys]roachpb.Version{
 
 	V25_3_AddEstimatedLastLoginTime: {Major: 25, Minor: 2, Internal: 6},
 
+	V25_3_AddHotRangeLoggerJob: {Major: 25, Minor: 2, Internal: 8},
+
 	// *************************************************
 	// Step (2): Add new versions above this comment.
 	// Do not add new versions to a patch release.

pkg/jobs/jobspb/wrap.go

@@ -372,6 +372,8 @@ func WrapProgressDetails(details ProgressDetails) interface {
 		return &Progress_StandbyReadTsPoller{StandbyReadTsPoller: &d}
 	case SqlActivityFlushProgress:
 		return &Progress_SqlActivityFlush{SqlActivityFlush: &d}
+	case HotRangesLoggerProgress:
+		return &Progress_HotRangesLogger{HotRangesLogger: &d}
 	default:
 		panic(errors.AssertionFailedf("WrapProgressDetails: unknown progress type %T", d))
 	}

pkg/jobs/registry.go

@@ -321,6 +321,10 @@ const (
 	UpdateTableMetadataCacheJobID = jobspb.JobID(105)
 
 	SqlActivityFlushJobID = jobspb.JobID(106)
+
+	// HotRangesLoggerJobID A static job ID which is used for the
+	// hot ranges logger job.
+	HotRangesLoggerJobID = jobspb.JobID(107)
 )
 
 // MakeJobID generates a new job ID.