Skip to content

Commit 9e36b27

Browse files
craig[bot]edwardguo-crltbg
committed
146829: sql,externalconn: add ALTER EXTERNAL CONNECTION r=msbutler a=edwardguo-crl ## Summary Add AST parser support for the new SQL command `ALTER EXTERNAL CONNECTION`, allowing users to modify existing external connections. Fixes #98610 149890: asim: add .txt ending r=tbg a=tbg We're having issues with Goland and Reviewable classifying some files as binary. ``` find ./pkg/kv/kvserver/asim/tests/testdata -type f -exec mv {} {}.txt ';' ``` Epic: CRDB-25222 Co-authored-by: Edward Guo <[email protected]> Co-authored-by: Tobias Grieger <[email protected]>
3 parents c994ab7 + 85546d5 + 53bd82e commit 9e36b27

33 files changed

+101
-6
lines changed

docs/generated/sql/bnf/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ FILES = [
2525
"alter_database_to_schema_stmt",
2626
"alter_ddl_stmt",
2727
"alter_default_privileges_stmt",
28+
"alter_external_connection_stmt",
2829
"alter_func_stmt",
2930
"alter_func_options_stmt",
3031
"alter_func_rename_stmt",
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
alter_external_connection_stmt ::=
2+
'ALTER' 'EXTERNAL' 'CONNECTION' label_spec 'AS' string_or_placeholder
3+
| 'ALTER' 'EXTERNAL' 'CONNECTION' 'IF' 'EXISTS' label_spec 'AS' string_or_placeholder
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
alter_stmt ::=
22
alter_ddl_stmt
3+
| alter_external_connection_stmt
34
| alter_role_stmt
45
| alter_virtual_cluster_stmt

docs/generated/sql/bnf/stmt_block.bnf

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,7 @@ legacy_end_stmt ::=
193193

194194
alter_stmt ::=
195195
alter_ddl_stmt
196+
| alter_external_connection_stmt
196197
| alter_role_stmt
197198
| alter_virtual_cluster_stmt
198199

@@ -560,6 +561,10 @@ alter_ddl_stmt ::=
560561
| alter_policy_stmt
561562
| alter_job_stmt
562563

564+
alter_external_connection_stmt ::=
565+
'ALTER' 'EXTERNAL' 'CONNECTION' label_spec 'AS' string_or_placeholder
566+
| 'ALTER' 'EXTERNAL' 'CONNECTION' 'IF' 'EXISTS' label_spec 'AS' string_or_placeholder
567+
563568
alter_role_stmt ::=
564569
'ALTER' role_or_group_or_user role_spec opt_role_options
565570
| 'ALTER' role_or_group_or_user 'IF' 'EXISTS' role_spec opt_role_options
@@ -1804,6 +1809,10 @@ alter_policy_stmt ::=
18041809
alter_job_stmt ::=
18051810
'ALTER' 'JOB' a_expr 'OWNER' 'TO' role_spec
18061811

1812+
label_spec ::=
1813+
string_or_placeholder
1814+
| 'IF' 'NOT' 'EXISTS' string_or_placeholder
1815+
18071816
role_or_group_or_user ::=
18081817
'ROLE'
18091818
| 'USER'
@@ -1936,10 +1945,6 @@ target_list ::=
19361945
changefeed_target_expr ::=
19371946
insert_target
19381947

1939-
label_spec ::=
1940-
string_or_placeholder
1941-
| 'IF' 'NOT' 'EXISTS' string_or_placeholder
1942-
19431948
logical_replication_resources ::=
19441949
'TABLE' db_object_name
19451950
| 'TABLES' '(' logical_replication_resources_list ')'

pkg/gen/bnf.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ BNF_SRCS = [
2525
"//docs/generated/sql/bnf:alter_database_to_schema_stmt.bnf",
2626
"//docs/generated/sql/bnf:alter_ddl_stmt.bnf",
2727
"//docs/generated/sql/bnf:alter_default_privileges_stmt.bnf",
28+
"//docs/generated/sql/bnf:alter_external_connection_stmt.bnf",
2829
"//docs/generated/sql/bnf:alter_func_dep_extension_stmt.bnf",
2930
"//docs/generated/sql/bnf:alter_func_options_stmt.bnf",
3031
"//docs/generated/sql/bnf:alter_func_owner_stmt.bnf",

pkg/gen/diagrams.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ DIAGRAMS_SRCS = [
2626
"//docs/generated/sql/bnf:alter_database_to_schema.html",
2727
"//docs/generated/sql/bnf:alter_ddl.html",
2828
"//docs/generated/sql/bnf:alter_default_privileges.html",
29+
"//docs/generated/sql/bnf:alter_external_connection.html",
2930
"//docs/generated/sql/bnf:alter_func.html",
3031
"//docs/generated/sql/bnf:alter_func_dep_extension.html",
3132
"//docs/generated/sql/bnf:alter_func_options.html",

pkg/gen/docs.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ DOCS_SRCS = [
3535
"//docs/generated/sql/bnf:alter_database_to_schema_stmt.bnf",
3636
"//docs/generated/sql/bnf:alter_ddl_stmt.bnf",
3737
"//docs/generated/sql/bnf:alter_default_privileges_stmt.bnf",
38+
"//docs/generated/sql/bnf:alter_external_connection_stmt.bnf",
3839
"//docs/generated/sql/bnf:alter_func_dep_extension_stmt.bnf",
3940
"//docs/generated/sql/bnf:alter_func_options_stmt.bnf",
4041
"//docs/generated/sql/bnf:alter_func_owner_stmt.bnf",
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)