Skip to content

Commit 9f1cdec

Browse files
committed
storage: clarify a TODO
This TODO was missing a word which made it confusing. Epic: none Release note: None
1 parent 9e0ba6b commit 9f1cdec

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

pkg/storage/pebble_mvcc_scanner.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -938,10 +938,9 @@ func (p *pebbleMVCCScanner) getOne(ctx context.Context) (ok, added bool) {
938938
if len(p.meta.RawBytes) != 0 {
939939
// 7. Emit immediately if the value is inline.
940940
//
941-
// TODO(ssd): We error if we find an inline when
942-
// ReturnRawMVCCValues is set. Anyone scanning with
943-
// that option set should not be encountering inline
944-
// values.
941+
// TODO(ssd): We should error if we find an inline value when
942+
// ReturnRawMVCCValues is set. Anyone scanning with that option set should
943+
// not be scanning keyspace that includes inline values.
945944
//
946945
// https://github.com/cockroachdb/cockroach/issues/131667
947946
return p.add(ctx, p.curUnsafeKey.Key, p.curRawKey, p.meta.RawBytes, p.meta.RawBytes)

0 commit comments

Comments
 (0)