Skip to content

Commit a68f71f

Browse files
committed
logical: batch handler exhaustive test
This reworks the crud table handler's exhaustive test so that it runs against the batch handler interface. That allows it to test all of the LDR handler implementations. The test was extended to metamorphically define a unique index/constraint and swap the primary key column id. This allows the test to reproduce #145994. Informs: #145994 Release note: none
1 parent 6d6e8d5 commit a68f71f

File tree

3 files changed

+532
-297
lines changed

3 files changed

+532
-297
lines changed

pkg/crosscluster/logical/BUILD.bazel

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@ go_library(
119119
go_test(
120120
name = "logical_test",
121121
srcs = [
122+
"batch_handler_test.go",
122123
"create_logical_replication_stmt_test.go",
123124
"dead_letter_queue_test.go",
124125
"logical_replication_job_test.go",
@@ -153,6 +154,7 @@ go_test(
153154
"//pkg/crosscluster/streamclient/randclient",
154155
"//pkg/jobs",
155156
"//pkg/jobs/jobspb",
157+
"//pkg/keys",
156158
"//pkg/kv",
157159
"//pkg/kv/kvpb",
158160
"//pkg/kv/kvserver",
@@ -171,6 +173,7 @@ go_test(
171173
"//pkg/sql/catalog/desctestutils",
172174
"//pkg/sql/catalog/lease",
173175
"//pkg/sql/catalog/resolver",
176+
"//pkg/sql/catalog/tabledesc",
174177
"//pkg/sql/execinfra",
175178
"//pkg/sql/execinfrapb",
176179
"//pkg/sql/isql",
@@ -199,6 +202,7 @@ go_test(
199202
"//pkg/util/hlc",
200203
"//pkg/util/leaktest",
201204
"//pkg/util/log",
205+
"//pkg/util/metamorphic",
202206
"//pkg/util/metric",
203207
"//pkg/util/protoutil",
204208
"//pkg/util/randutil",

0 commit comments

Comments
 (0)