Skip to content

Commit a7ed241

Browse files
committed
roachtest: increase closed TS lag in copyfrom roachtest
The atomic COPY writes the whole thing as a single txn, and we've seen cases where this txn can be on the order of 2 minutes. We've already increased the closed TS target duration to 60s, but that means that the closed TS system could push the COPY txn. To avoid this kind of flake we bump the target duration to 5 minutes. Release note: None
1 parent cc6e099 commit a7ed241

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

pkg/cmd/roachtest/tests/copyfrom.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,12 @@ func runCopyFromCRDB(ctx context.Context, t test.Test, c cluster.Cluster, sf int
148148
// Enable the verbose logging on relevant files to have better understanding
149149
// in case the test fails.
150150
startOpts.RoachprodOpts.ExtraArgs = append(startOpts.RoachprodOpts.ExtraArgs, "--vmodule=copy_from=2,insert=2")
151-
// roachtest frequently runs on overloaded instances and can timeout as a result
152-
clusterSettings := install.MakeClusterSettings(install.ClusterSettingsOption{"kv.closed_timestamp.target_duration": "60s"})
151+
// The roachtest frequently runs on overloaded instances and can timeout as
152+
// a result. We've seen cases where the atomic COPY takes about 2 minutes to
153+
// complete, so we set the closed TS to 5 minutes (to give enough safety
154+
// gap, otherwise the closed TS system might continuously push the COPY txn
155+
// not allowing it ever to complete).
156+
clusterSettings := install.MakeClusterSettings(install.ClusterSettingsOption{"kv.closed_timestamp.target_duration": "300s"})
153157
c.Start(ctx, t.L(), startOpts, clusterSettings, c.All())
154158
initTest(ctx, t, c, sf)
155159
db, err := c.ConnE(ctx, t.L(), 1)

0 commit comments

Comments
 (0)