sql: turn stored proc extended protocol fix on

This commit flips `use_proc_txn_control_extended_protocol_fix` on by
default. This will make the fix active in v25.3+.

Informs #147701

Release note: None

Author: DrewKimball

pkg/sql/logictest/testdata/logic_test/information_schema

@@ -4137,7 +4137,7 @@ unsafe_allow_triggers_modifying_cascades                         off
 use_cputs_on_non_unique_indexes                                  off
 use_improved_routine_dependency_tracking                         on
 use_pre_25_2_variadic_builtins                                   off
-use_proc_txn_control_extended_protocol_fix                       off
+use_proc_txn_control_extended_protocol_fix                       on
 variable_inequality_lookup_join_enabled                          on
 vector_search_beam_size                                          32
 xmloption                                                        content

pkg/sql/logictest/testdata/logic_test/pg_catalog

@@ -3132,7 +3132,7 @@ use_cputs_on_non_unique_indexes                                  off
 use_declarative_schema_changer                                   on                  NULL      NULL        NULL        string
 use_improved_routine_dependency_tracking                         on                  NULL      NULL        NULL        string
 use_pre_25_2_variadic_builtins                                   off                 NULL      NULL        NULL        string
-use_proc_txn_control_extended_protocol_fix                       off                 NULL      NULL        NULL        string
+use_proc_txn_control_extended_protocol_fix                       on                  NULL      NULL        NULL        string
 variable_inequality_lookup_join_enabled                          on                  NULL      NULL        NULL        string
 vector_search_beam_size                                          32                  NULL      NULL        NULL        string
 vectorize                                                        on                  NULL      NULL        NULL        string
@@ -3367,7 +3367,7 @@ use_cputs_on_non_unique_indexes                                  off
 use_declarative_schema_changer                                   on                  NULL  user     NULL      on                  on
 use_improved_routine_dependency_tracking                         on                  NULL  user     NULL      on                  on
 use_pre_25_2_variadic_builtins                                   off                 NULL  user     NULL      off                 off
-use_proc_txn_control_extended_protocol_fix                       off                 NULL  user     NULL      off                 off
+use_proc_txn_control_extended_protocol_fix                       on                  NULL  user     NULL      on                  on
 variable_inequality_lookup_join_enabled                          on                  NULL  user     NULL      on                  on
 vector_search_beam_size                                          32                  NULL  user     NULL      32                  32
 vectorize                                                        on                  NULL  user     NULL      on                  on

pkg/sql/logictest/testdata/logic_test/show_source

@@ -246,7 +246,7 @@ use_cputs_on_non_unique_indexes                                  off
 use_declarative_schema_changer                                   on
 use_improved_routine_dependency_tracking                         on
 use_pre_25_2_variadic_builtins                                   off
-use_proc_txn_control_extended_protocol_fix                       off
+use_proc_txn_control_extended_protocol_fix                       on
 variable_inequality_lookup_join_enabled                          on
 vector_search_beam_size                                          32
 vectorize                                                        on

pkg/sql/pgwire/testdata/pgtest/procedure

@@ -75,16 +75,6 @@ ReadyForQuery
 {"Type":"CommandComplete","CommandTag":"CALL"}
 {"Type":"ReadyForQuery","TxStatus":"I"}
 
-send crdb_only
-Query {"String": "SET use_proc_txn_control_extended_protocol_fix = true"}
-----
-
-until crdb_only
-ReadyForQuery
-----
-{"Type":"CommandComplete","CommandTag":"SET"}
-{"Type":"ReadyForQuery","TxStatus":"I"}
-
 send
 Parse {"Name": "foo", "Query": "CALL p()"}
 Bind {"DestinationPortal": "foo", "PreparedStatement": "foo"}
@@ -104,13 +94,3 @@ ReadyForQuery
 {"Severity":"NOTICE","SeverityUnlocalized":"NOTICE","Code":"00000","Message":"baz","Detail":"","Hint":"","Position":0,"InternalPosition":0,"InternalQuery":"","Where":"","SchemaName":"","TableName":"","ColumnName":"","DataTypeName":"","ConstraintName":"","File":"builtins.go","Line":0,"Routine":"func378","UnknownFields":null}
 {"Type":"CommandComplete","CommandTag":"CALL"}
 {"Type":"ReadyForQuery","TxStatus":"I"}
-
-send crdb_only
-Query {"String": "RESET use_proc_txn_control_extended_protocol_fix"}
-----
-
-until crdb_only
-ReadyForQuery
-----
-{"Type":"CommandComplete","CommandTag":"RESET"}
-{"Type":"ReadyForQuery","TxStatus":"I"}

pkg/sql/vars.go

@@ -4158,7 +4158,7 @@ var varGen = map[string]sessionVar{
 		Get: func(evalCtx *extendedEvalContext, _ *kv.Txn) (string, error) {
 			return formatBoolAsPostgresSetting(evalCtx.SessionData().UseProcTxnControlExtendedProtocolFix), nil
 		},
-		GlobalDefault: globalFalse,
+		GlobalDefault: globalTrue,
 	},
 }