asim: fix under-replication in rand testing

Previously, the simulator assumed that the LoadRangeInfo will include a range
with min key as 0 (the first range created by initFirstRange relies on
LoadRangeInfo to handle up-replication). When rand tests overrode this
assumption, it led to under replication and failed assertion. This commit goes
around this by setting defaultMinKey = 0 and disallowing the rand framework from
overriding. We should fix the simulator assumption eventually.

Epic: none
Release note: none

Author: wenyihu6

pkg/kv/kvserver/asim/tests/default_settings.go

@@ -24,7 +24,7 @@ const defaultKeyspace = 200000
 const (
 	defaultRwRatio, defaultRate      = 0.0, 0.0
 	defaultMinBlock, defaultMaxBlock = 1, 1
-	defaultMinKey, defaultMaxKey     = int64(1), int64(defaultKeyspace)
+	defaultMinKey, defaultMaxKey     = int64(0), int64(defaultKeyspace)
 	defaultSkewedAccess              = false
 )
 

pkg/kv/kvserver/asim/tests/rand_test.go

@@ -182,7 +182,15 @@ func TestRandomized(t *testing.T) {
 				scanIfExists(t, d, "rate", &staticOptionSettings.rate)
 				scanIfExists(t, d, "min_block", &staticOptionSettings.minBlock)
 				scanIfExists(t, d, "max_block", &staticOptionSettings.maxBlock)
-				scanIfExists(t, d, "min_key", &staticOptionSettings.minKey)
+				if hasMinKey := scanIfExists(t, d, "min_key", &staticOptionSettings.minKey); hasMinKey && staticOptionSettings.minKey != int64(0) {
+					// TODO(wenyihu6): the simulator assumes the first range starts at 0.
+					// If we allow ranges to be created with minKey > 0, we need to modify
+					// initFirstRange() to properly up-replicate the first range.
+					// Currently, it relies on LoadRangeInfo to properly up-replicate the
+					// first range since that tells the simulator which stores to add
+					// replicas to.
+					panic("min_key is not supported for randomied testing")
+				}
 				scanIfExists(t, d, "max_key", &staticOptionSettings.maxKey)
 				scanIfExists(t, d, "skewed_access", &staticOptionSettings.skewedAccess)
 				scanIfExists(t, d, "ranges", &staticOptionSettings.ranges)

pkg/kv/kvserver/asim/tests/testdata/rand/default_settings

@@ -20,69 +20,24 @@ generating cluster configurations using static option
 generating ranges configurations using randomized option
 	placement_type=weighted_rand, range_gen_type=uniform, key_space=uniform, replication_factor=3, weightedRand=[0.1 0.2 0.7]
 generating load configurations using static option
-	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=1, max_key=200000, skewed_access=false
+	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option
 generating settings configurations using static option
 ----------------------------------
 sample1: start running
-configurations generated using seed 5571782338101878760
-	basic cluster with nodes=1, stores_per_node=3
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0.1 0.2 0.7], ranges=563, min_key=1, max_key=160411, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
-	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(3)=[s1n1=(replicas(563)),s2n1=(replicas(563)),s3n1=(replicas(563))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1]
-no events were scheduled
-sample1: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample1: pass
 ----------------------------------
 sample2: start running
-configurations generated using seed 4299969443970870044
-	basic cluster with nodes=1, stores_per_node=3
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0.1 0.2 0.7], ranges=299, min_key=1, max_key=9542, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
-	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(3)=[s1n1=(replicas(299)),s2n1=(replicas(299)),s3n1=(replicas(299))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1]
-no events were scheduled
-sample2: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample2: pass
 ----------------------------------
 sample3: start running
-configurations generated using seed 4157513341729910236
-	basic cluster with nodes=1, stores_per_node=3
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0.1 0.2 0.7], ranges=521, min_key=1, max_key=82660, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
-	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(3)=[s1n1=(replicas(521)),s2n1=(replicas(521)),s3n1=(replicas(521))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1]
-no events were scheduled
-sample3: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample3: pass
 ----------------------------------
 
 clear
@@ -107,67 +62,37 @@ generating cluster configurations using static option
 generating ranges configurations using randomized option
 	placement_type=weighted_rand, range_gen_type=uniform, key_space=uniform, replication_factor=3, weightedRand=[0 0 0 0.3 0.3 0.4]
 generating load configurations using static option
-	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=1, max_key=200000, skewed_access=false
+	rw_ratio=0.00, rate=0.00, min_block=1, max_block=1, min_key=0, max_key=200000, skewed_access=false
 generating events configurations using static option
 generating settings configurations using static option
 ----------------------------------
 sample1: start running
 configurations generated using seed 5571782338101878760
 	basic cluster with nodes=3, stores_per_node=2
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=563, min_key=1, max_key=160411, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
+	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=563, min_key=0, max_key=160411, replication_factor=3, bytes=0
+	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=0, max_key=200000
 	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(6)=[s1n1=(replicas(22)),s2n1=(replicas(23)),s3n2=(replicas(23)),s4n2=(replicas(529)),s5n3=(replicas(563)),s6n3=(replicas(529))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1 2 3]
-no events were scheduled
-sample1: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample1: pass
 ----------------------------------
 sample2: start running
 configurations generated using seed 4299969443970870044
 	basic cluster with nodes=3, stores_per_node=2
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=299, min_key=1, max_key=9542, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
+	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=299, min_key=0, max_key=9542, replication_factor=3, bytes=0
+	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=0, max_key=200000
 	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(6)=[s1n1=(replicas(53)),s2n1=(replicas(52)),s3n2=(replicas(52)),s4n2=(replicas(299)),s5n3=(replicas(142)),s6n3=(replicas(299))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1 2 3]
-no events were scheduled
-sample2: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample2: pass
 ----------------------------------
 sample3: start running
 configurations generated using seed 4157513341729910236
 	basic cluster with nodes=3, stores_per_node=2
-	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=521, min_key=1, max_key=82660, replication_factor=3, bytes=0
-	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=1, max_key=200000
+	weighted randomized ranges with placement_type=weighted_rand, weighted_rand=[0 0 0 0.3 0.3 0.4], ranges=521, min_key=0, max_key=82660, replication_factor=3, bytes=0
+	basic load with rw_ratio=0.00, rate=0.00, skewed_access=false, min_block_size=1, max_block_size=1, min_key=0, max_key=200000
 	number of mutation events=0, number of assertion events=0
 initial state at 2022-03-21 11:00:00:
 	stores(6)=[s1n1=(replicas(91)),s2n1=(replicas(91)),s3n2=(replicas(92)),s4n2=(replicas(521)),s5n3=(replicas(247)),s6n3=(replicas(521))]
-topology:
-AU_EAST
-  AU_EAST_1
-    └── [1 2 3]
-no events were scheduled
-sample3: failed assertion
-  conformance unavailable=0 under=0 over=0 violating=0 lease-violating=0 lease-less-preferred=0 
-  actual unavailable=1 under=1, over=0 violating=0 lease-violating=0 lease-less-preferred=0
-unavailable:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3under replicated:
-  r1:000000000{0-1} [<no replicas>] applying ttl_seconds=0 num_voters=3
+sample3: pass
 ----------------------------------