sql: remove deprecated cols from crdb_internal.jobs, SHOW

The 'stated' column in SHOW JOBS just duplicated the value of returned in the 'created' column.
The removed columns in the internal table were always populated with fixed null placeholders since 25.1.

Release note (sql change): the 'started' column in SHOW JOBS, which was just a duplicate of the 'created' column, has been removed.
Epic: none.

Author: dt

pkg/cli/zip_table_registry.go

@@ -382,25 +382,21 @@ var zipInternalTablesPerCluster = DebugZipTableRegistry{
 	},
 	// `statement` column can contain customer URI params such as
 	// AWS_ACCESS_KEY_ID.
-	// `error`, `execution_errors`, and `execution_events` columns contain
-	// error text that may contain sensitive data.
+	// `error` column contains error text that may contain sensitive data.
 	"crdb_internal.jobs": {
 		nonSensitiveCols: NonSensitiveColumns{
 			"job_id",
 			"job_type",
 			"description",
 			"user_name",
-			"descriptor_ids",
 			"status",
 			"running_status",
 			"created",
-			"started",
 			"finished",
 			"modified",
 			"fraction_completed",
 			"high_water_timestamp",
 			"coordinator_id",
-			"trace_id",
 		},
 	},
 	"crdb_internal.system_jobs": {

pkg/server/admin.go

@@ -2271,7 +2271,6 @@ SELECT
   fraction_completed,
   high_water_timestamp,
   error,
-  execution_events::string,
   coordinator_id
 FROM crdb_internal.jobs
 WHERE true`) // Simplifies filter construction below.
@@ -2368,7 +2367,6 @@ func scanRowIntoJob(scanner resultScanner, row tree.Datums, job *serverpb.JobRes
 	var fractionCompletedOrNil *float32
 	var highwaterOrNil *apd.Decimal
 	var runningStatusOrNil *string
-	var executionFailuresOrNil *string
 	var coordinatorOrNil *int64
 	if err := scanner.ScanAll(
 		row,
@@ -2385,7 +2383,6 @@ func scanRowIntoJob(scanner resultScanner, row tree.Datums, job *serverpb.JobRes
 		&fractionCompletedOrNil,
 		&highwaterOrNil,
 		&job.Error,
-		&executionFailuresOrNil,
 		&coordinatorOrNil,
 	); err != nil {
 		return errors.Wrap(err, "scan")
@@ -2438,7 +2435,7 @@ func jobHelper(
 	const query = `
 	        SELECT job_id, job_type, description, statement, user_name, status,
 	  						 running_status, created, finished, modified,
-	  						 fraction_completed, high_water_timestamp, error, execution_events::string, coordinator_id
+	  						 fraction_completed, high_water_timestamp, error, coordinator_id
 	          FROM crdb_internal.jobs
 	         WHERE job_id = $1`
 	row, cols, err := sqlServer.internalExecutor.QueryRowExWithCols(

pkg/sql/crdb_internal.go

@@ -1152,20 +1152,15 @@ CREATE TABLE crdb_internal.jobs (
   description           STRING,
   statement             STRING,
   user_name             STRING,
-  descriptor_ids        INT[],
   status                STRING,
   running_status        STRING,
   created               TIMESTAMPTZ,
-  started               TIMESTAMPTZ,
   finished              TIMESTAMPTZ,
   modified              TIMESTAMPTZ,
   fraction_completed    FLOAT,
   high_water_timestamp  DECIMAL,
   error                 STRING,
   coordinator_id        INT,
-  trace_id              INT,
-  execution_errors      STRING[],
-  execution_events      JSONB,
   INDEX(job_id),
   INDEX(status),
   INDEX(job_type)
@@ -1347,20 +1342,15 @@ LEFT OUTER JOIN system.public.job_status AS s ON j.id = s.job_id
 			desc,
 			desc,
 			ownerStr,
-			tree.DNull, // deperecated "descriptor_ids"
 			state,
 			status,
 			created,
-			created, // deprecated "started" field.
 			finished,
 			modified,
 			fraction,
 			resolved,
 			errorMsg,
 			instanceID,
-			tree.DNull, // deprecated "trace_id" field.
-			tree.DNull, // deprecated "executionErrors" field.
-			tree.DNull, // deprecated "executionEvents" field.
 		); err != nil {
 			return emitted, err
 		}

pkg/sql/delegate/show_changefeed_jobs.go

@@ -37,7 +37,7 @@ SELECT
   status,
   running_status,
   created,
-  started,
+  created as started,
   finished,
   modified,
   high_water_timestamp,

pkg/sql/delegate/show_jobs.go

@@ -28,14 +28,10 @@ func constructSelectQuery(n *tree.ShowJobs) string {
 		baseQuery.WriteString(`description, statement, `)
 	}
 	baseQuery.WriteString(`user_name, status, running_status, `)
-	baseQuery.WriteString(`date_trunc('second', created) as created, date_trunc('second', started) as started, `)
+	baseQuery.WriteString(`date_trunc('second', created) as created, date_trunc('second', created) as started, `)
 	baseQuery.WriteString(`date_trunc('second', finished) as finished, date_trunc('second', modified) as modified, `)
 	baseQuery.WriteString(`fraction_completed, error, coordinator_id`)
 
-	if n.Jobs != nil {
-		baseQuery.WriteString(`, trace_id, execution_errors`)
-	}
-
 	// Check if there are any SHOW JOBS options that we need to add columns for.
 	if n.Options != nil {
 		if n.Options.ExecutionDetails {