sql/inspect: add placeholder values to logged queries

Previously, INSPECT only logged the query text without placeholder
values in issue reports, making debugging more difficult. This change
includes the actual placeholder values in the logged query output.

This also addes a test for INSPECT and LTREE[] handling.

Informs: #155483
Epic: CRDB-55075

Release note: none

Author: spilchen

pkg/sql/inspect/index_consistency_check.go

@@ -96,6 +96,9 @@ type indexConsistencyCheck struct {
 	// lastQuery stores the SQL query executed for this check to help
 	// debug internal errors by providing context about the span bounds.
 	lastQuery string
+
+	// lastQueryPlaceholders stores the placeholder values used in lastQuery.
+	lastQueryPlaceholders []interface{}
 }
 
 var _ inspectCheck = (*indexConsistencyCheck)(nil)
@@ -272,8 +275,9 @@ func (c *indexConsistencyCheck) Start(
 	// Wrap the query with AS OF SYSTEM TIME to ensure it uses the specified timestamp
 	queryWithAsOf := fmt.Sprintf("SELECT * FROM (%s) AS OF SYSTEM TIME %s", checkQuery, c.asOf.AsOfSystemTime())
 
-	// Store the query for error reporting
+	// Store the query and placeholders for error reporting.
 	c.lastQuery = queryWithAsOf
+	c.lastQueryPlaceholders = queryArgs
 
 	// Execute the query with AS OF SYSTEM TIME embedded in the SQL
 	qos := getInspectQoS(&c.flowCtx.Cfg.Settings.SV)
@@ -327,6 +331,7 @@ func (c *indexConsistencyCheck) Next(
 		details["error_type"] = "internal_query_error"
 		details["index_name"] = c.secIndex.GetName()
 		details["query"] = c.lastQuery // Store the query that caused the error
+		details["query_placeholders"] = formatPlaceholders(c.lastQueryPlaceholders)
 
 		return &inspectIssue{
 			ErrorType:  InternalError,
@@ -391,6 +396,7 @@ func (c *indexConsistencyCheck) Next(
 	details := make(map[redact.RedactableString]interface{})
 	details["row_data"] = extractRowData(c.rowIter.Cur(), c.columns, dataStartIdx)
 	details["index_name"] = c.secIndex.GetName()
+	details["query_placeholders"] = formatPlaceholders(c.lastQueryPlaceholders)
 
 	return &inspectIssue{
 		ErrorType:  errorType,
@@ -920,3 +926,16 @@ func isQueryConstructionError(err error) bool {
 		return false
 	}
 }
+
+// formatPlaceholders converts query placeholder values to a string slice for JSON serialization.
+func formatPlaceholders(placeholders []interface{}) []string {
+	result := make([]string, len(placeholders))
+	for i, placeholder := range placeholders {
+		if datum, ok := placeholder.(tree.Datum); ok {
+			result[i] = tree.AsStringWithFlags(datum, tree.FmtParsable)
+		} else {
+			result[i] = fmt.Sprintf("%v", placeholder)
+		}
+	}
+	return result
+}

pkg/sql/logictest/testdata/logic_test/distsql_inspect

@@ -5,6 +5,19 @@ subtest setup
 statement ok
 SET enable_scrub_job = true;
 
+statement ok
+SET enable_inspect_command = true;
+
+statement ok
+CREATE VIEW last_inspect_job AS
+SELECT status, COALESCE(jsonb_array_length(
+    crdb_internal.pb_to_json('cockroach.sql.jobs.jobspb.Payload', payload)->'inspectDetails'->'checks'
+  ), 0) AS num_checks
+FROM crdb_internal.system_jobs
+WHERE job_type = 'INSPECT'
+ORDER BY created DESC
+LIMIT 1
+
 statement ok
 CREATE TABLE data (a INT, b INT, c FLOAT, d DECIMAL, e BOOL, PRIMARY KEY (a, b, c, d), INDEX c_idx (c, d))
 
@@ -56,6 +69,49 @@ EXPERIMENTAL SCRUB TABLE data AS OF SYSTEM TIME '-1us'  succeeded  true
 
 subtest end
 
+subtest ltree_array_pk_column
+
+statement ok
+CREATE TABLE table_ltree_array_leading (
+    pk_ltree_array LTREE[] NOT NULL,
+    pk_name NAME NOT NULL,
+    val INT,
+    PRIMARY KEY (pk_ltree_array, pk_name),
+    INDEX idx_val (val)
+);
+
+statement ok
+INSERT INTO table_ltree_array_leading VALUES
+    (ARRAY['a.b.c']::LTREE[], 'key1', 1),
+    (ARRAY['d.e.f']::LTREE[], 'key2', 2),
+    (ARRAY['g.h.i']::LTREE[], 'key3', 3),
+    (ARRAY['j.k.l']::LTREE[], 'key4', 4),
+    (ARRAY['m.n.o']::LTREE[], 'key5', 5),
+    (ARRAY['p.q.r']::LTREE[], 'key6', 6);
+
+# Split the table into multiple ranges to force distributed INSPECT queries.
+statement ok
+ALTER TABLE table_ltree_array_leading SPLIT AT VALUES (ARRAY['d.e.f']::LTREE[], 'key2');
+
+statement ok
+ALTER TABLE table_ltree_array_leading SPLIT AT VALUES (ARRAY['j.k.l']::LTREE[], 'key4');
+
+statement ok
+ALTER TABLE table_ltree_array_leading SCATTER;
+
+statement ok
+INSPECT TABLE table_ltree_array_leading;
+
+query TI
+SELECT * FROM last_inspect_job;
+----
+succeeded 1
+
+statement ok
+DROP TABLE table_ltree_array_leading;
+
+subtest end
+
 subtest cleanup
 
 statement ok