Merge #155396

craig[bot] · DarrylWong · craig[bot] · commit ae63facef43c · 2025-10-16T15:54:01.000Z
155396: mixedversion: increase auto_upgrade verbosity in mixed version tests r=herkolategan a=DarrylWong

We sometimes see the auto upgrade process hang, and it would be nice to see additionally logging to help debug.

Epic: none
Release note: none
Fixes: none

Co-authored-by: DarrylWong &lt;darryl@cockroachlabs.com&gt;
diff --git a/pkg/cmd/roachtest/roachtestutil/mixedversion/steps.go b/pkg/cmd/roachtest/roachtestutil/mixedversion/steps.go
@@ -779,9 +779,12 @@ func quoteVersionForPresentation(v string) string {
 // we should change the default and add an API for tests to opt-out of
 // the default scheduled backup if necessary.
 func startOpts(opts ...option.StartStopOption) option.StartOpts {
-	return option.NewStartOpts(
+	startOpts := option.NewStartOpts(
 		startStopOpts(opts...)...,
 	)
+	// Enable verbose logging for auto_upgrade to help debug upgrade-related issues.
+	startOpts.RoachprodOpts.ExtraArgs = append(startOpts.RoachprodOpts.ExtraArgs, "--vmodule=auto_upgrade=2")
+	return startOpts
 }
 
 // startStopOpts does the same as `startOpts` but returns StartStopOptions

Original file line number	Diff line number	Diff line change
`@@ -779,9 +779,12 @@ func quoteVersionForPresentation(v string) string {`
`779`	`779`	`// we should change the default and add an API for tests to opt-out of`
`780`	`780`	`// the default scheduled backup if necessary.`
`781`	`781`	`func startOpts(opts ...option.StartStopOption) option.StartOpts {`
`782`		`- return option.NewStartOpts(`
	`782`	`+ startOpts := option.NewStartOpts(`
`783`	`783`	`startStopOpts(opts...)...,`
`784`	`784`	`)`
	`785`	`+ // Enable verbose logging for auto_upgrade to help debug upgrade-related issues.`
	`786`	`+ startOpts.RoachprodOpts.ExtraArgs = append(startOpts.RoachprodOpts.ExtraArgs, "--vmodule=auto_upgrade=2")`
	`787`	`+ return startOpts`
`785`	`788`	`}`
`786`	`789`
`787`	`790`	// startStopOpts does the same as `startOpts` but returns StartStopOptions