Merge #148246

148246: scripts: update check-pebble-dep.sh r=RaduBerinde a=RaduBerinde

Fix a typo in the script and improve the output; also autodetect
release branches instead of hardcoding them.

Epic: none
Release note: None

Co-authored-by: Radu Berinde <[email protected]>

Author: craig[bot]

.github/workflows/check-pebble-dep.yml

@@ -1,7 +1,7 @@
 name: Check Pebble dep
 on:
   schedule:
-    - cron: '0 8 * * 0,3' # Every Sun and Wed at 8:00 UTC
+    - cron: '0 8 * * *' # Every day at 8:00 UTC
   workflow_dispatch:
 
 jobs:
@@ -38,7 +38,5 @@ jobs:
           payload: |
             {
               "channel": "C08JE13CM9S",
-              "text": ${{ toJson(format(
-                'Some Pebble dependencies are not up to date. Details below:\n```{0}```',
-                steps.run_script.outputs.output)) }}
+              "text": ${{ toJson(steps.run_script.outputs.output) }}
             }

scripts/check-pebble-dep.sh

@@ -9,34 +9,38 @@
 set -euo pipefail
 #set -x
 
-RELEASES="23.2 24.1 24.3 25.1 25.2 master"
+# Find all release-xx.y branches where xx >= 24.
+BRANCHES=$(git branch -r --format='%(refname)' \
+    | grep '^refs\/remotes/\origin\/release-2[4-9]\.[0-9]$' \
+    | sed 's/^refs\/remotes\/origin\///' \
+    | sort -V)
 
 EXIT_CODE=0
-for REL in $RELEASES; do
-  if [ "$REL" = "master" ]; then
-    BRANCH=master
-    PEBBLE_BRANCH=master
-  else
-    BRANCH="release-$REL"
-    PEBBLE_BRANCH="crl-release-$REL"
-  fi
+for BRANCH in $BRANCHES; do
+  PEBBLE_BRANCH="crl-$BRANCH"
   DEP_SHA=$(git show "origin/$BRANCH:go.mod" |
     grep 'github.com/cockroachdb/pebble' |
     grep -o -E '[a-f0-9]{12}$')
   TIP_SHA=$(git ls-remote --heads 'https://github.com/cockroachdb/pebble' |
     grep "refs/heads/$PEBBLE_BRANCH" |
     grep -o -E '^[a-f0-9]{12}')
 
-  if [ "$DEP_SHA" != "$TIP_SHA" ]; then
-    echo Branch $BRANCH pebble dependency up to date.
+  if [ "$DEP_SHA" = "$TIP_SHA" ]; then
     continue
   fi
 
-  echo Branch $BRANCH pebble dependency not up to date: $DEP_SHA vs current $TIP_SHA
-  if [ "$REL" != "master" ]; then
-    # Return an error if a release branch is not up to date.
-    EXIT_CODE=1
+  if [ $EXIT_CODE -eq 0 ]; then
+    echo "Some release branches have out-of-date Pebble dependencies:"
   fi
+  echo "  - $BRANCH: dependency set at $DEP_SHA, but $PEBBLE_BRANCH tip is $TIP_SHA"
+  EXIT_CODE=1
 done
 
-exit $EXIT_CODE
+if [ $EXIT_CODE -ne 0 ]; then
+  exit $EXIT_CODE
+fi
+
+echo "All release branches have up-to-date Pebble dependencies:"
+for BRANCH in $BRANCHES; do
+  echo " - $BRANCH"
+done